Skip to content

Commit 80f0e95

Browse files
committed
rpcapd: Fix parameter name validation in the configuration file.
Apparently, one of the changes in commit ac0abe3 lost the negation of the test condition and made any parameter name that starts with a letter (which is every parameter name currently implemented in rpcapd) invalid: $ cat rpcapd.conf NullAuthPermit = NO $ ./rpcapd -f rpcapd.conf rpcapd: error: rpcapd.conf, line 1 doesn't have a valid parameter name Press CTRL + C to stop the server... Negate the condition to fix this.
1 parent 9442f39 commit 80f0e95

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

CHANGES

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ DayOfTheWeek, Month DD, YYYY / The Tcpdump Group
6969
another incorporate-remote-capture project. (issue #1120)
7070
rpcapd: Refine SSL options in printusage().
7171
Fix a possible buffer overflow (Coverity CID 1619148).
72+
Fix parameter name validation in the configuration file.
7273
Documentation:
7374
Document a standard format for writing out BPF filter programs.
7475
Add a README.hurd.md file.

rpcapd/fileconf.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ void fileconf_read(void)
142142
// Is the next character alphabetic? If not,
143143
// this isn't a valid parameter name.
144144
//
145-
if (FILECONF_ISALPHA(*ptr))
145+
if (! FILECONF_ISALPHA(*ptr))
146146
{
147147
rpcapd_log(LOGPRIO_ERROR,
148148
"%s, line %u doesn't have a valid parameter name",

0 commit comments

Comments
 (0)