Skip to content

Commit 4c7a353

Browse files
committed
Performance imporvment
1 parent fdab4d2 commit 4c7a353

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

util/util.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -844,13 +844,12 @@ def translateClaim(self, wikidata_claim):
844844
# comparing two claims together with their qualifiers and references
845845
def compare_claim_with_qualifiers_and_references(self, wikidata_claim, wikibase_claim, translate):
846846
# compare mainsnak
847-
found = False
848847
found_equal_value = False
849848
(claim_found, main_claim_found_equal_value) = self.compare_claim(wikidata_claim.get('mainsnak'),
850849
wikibase_claim.get('mainsnak'), translate)
851850
# compare qualifiers
852851
qualifiers_equal = True
853-
if ('qualifiers' in wikidata_claim) and ('qualifiers' in wikibase_claim):
852+
if main_claim_found_equal_value and ('qualifiers' in wikidata_claim) and ('qualifiers' in wikibase_claim):
854853
for q1 in wikidata_claim.get('qualifiers'):
855854
for q_wikidata in wikidata_claim.get('qualifiers').get(q1):
856855
qualifier_equal = False
@@ -866,7 +865,7 @@ def compare_claim_with_qualifiers_and_references(self, wikidata_claim, wikibase_
866865
qualifier_equal = True
867866
if qualifier_equal == False:
868867
qualifiers_equal = False
869-
if ('qualifiers' in wikidata_claim and not ('qualifiers' in wikibase_claim) or (
868+
if main_claim_found_equal_value and ('qualifiers' in wikidata_claim and not ('qualifiers' in wikibase_claim) or (
870869
not 'qualifiers' in wikidata_claim) and 'qualifiers' in wikibase_claim):
871870
qualifiers_equal = False
872871

0 commit comments

Comments
 (0)