issue #1 add missing efree() call

gregor-j · gregor-j · commit 0d74441d0f68 · 2018-10-09T10:48:39.000+02:00
diff --git a/pam.c b/pam.c
@@ -255,6 +255,7 @@ PHP_FUNCTION(pam_auth) {
       spprintf(&error_msg, 0, "%s (in %s)", (char *) pam_strerror(pamh, result), "pam_start");
       zval_dtor(status);
       ZVAL_STRING(status, error_msg);
+      efree(error_msg);
     }
     RETURN_FALSE;
   }
@@ -275,6 +276,7 @@ PHP_FUNCTION(pam_auth) {
       spprintf(&error_msg, 0, "%s (in %s)", (char *) pam_strerror(pamh, result), "pam_authenticate");
       zval_dtor(status);
       ZVAL_STRING(status, error_msg);
+      efree(error_msg);
     }
     pam_end(pamh, PAM_SUCCESS);
     RETURN_FALSE;
@@ -286,6 +288,7 @@ PHP_FUNCTION(pam_auth) {
         spprintf(&error_msg, 0, "%s (in %s)", (char *) pam_strerror(pamh, result), "pam_acct_mgmt");
         zval_dtor(status);
         ZVAL_STRING(status, error_msg);
+        efree(error_msg);
       }
       pam_end(pamh, PAM_SUCCESS);
       RETURN_FALSE;
@@ -327,6 +330,7 @@ PHP_FUNCTION(pam_chpass) {
       spprintf(&error_msg, 0, "%s (in %s)", (char *) pam_strerror(pamh, result), "pam_start");
       zval_dtor(status);
       ZVAL_STRING(status, error_msg);
+      efree(error_msg);
     }
     RETURN_FALSE;
   }
@@ -336,6 +340,7 @@ PHP_FUNCTION(pam_chpass) {
       spprintf(&error_msg, 0, "%s (in %s)", (char *) pam_strerror(pamh, result), "pam_authenticate");
       zval_dtor(status);
       ZVAL_STRING(status, error_msg);
+      efree(error_msg);
     }
     pam_end(pamh, PAM_SUCCESS);
     RETURN_FALSE;
@@ -346,6 +351,7 @@ PHP_FUNCTION(pam_chpass) {
       spprintf(&error_msg, 0, "%s (in %s)", (char *) pam_strerror(pamh, result), "pam_chauthtok");
       zval_dtor(status);
       ZVAL_STRING(status, error_msg);
+      efree(error_msg);
     }
     pam_end(pamh, PAM_SUCCESS);
     RETURN_FALSE;

Original file line number	Diff line number	Diff line change
`@@ -255,6 +255,7 @@ PHP_FUNCTION(pam_auth) {`
`255`	`255`	`spprintf(&error_msg, 0, "%s (in %s)", (char *) pam_strerror(pamh, result), "pam_start");`
`256`	`256`	`zval_dtor(status);`
`257`	`257`	`ZVAL_STRING(status, error_msg);`
	`258`	`+ efree(error_msg);`
`258`	`259`	`}`
`259`	`260`	`RETURN_FALSE;`
`260`	`261`	`}`
`@@ -275,6 +276,7 @@ PHP_FUNCTION(pam_auth) {`
`275`	`276`	`spprintf(&error_msg, 0, "%s (in %s)", (char *) pam_strerror(pamh, result), "pam_authenticate");`
`276`	`277`	`zval_dtor(status);`
`277`	`278`	`ZVAL_STRING(status, error_msg);`
	`279`	`+ efree(error_msg);`
`278`	`280`	`}`
`279`	`281`	`pam_end(pamh, PAM_SUCCESS);`
`280`	`282`	`RETURN_FALSE;`
`@@ -286,6 +288,7 @@ PHP_FUNCTION(pam_auth) {`
`286`	`288`	`spprintf(&error_msg, 0, "%s (in %s)", (char *) pam_strerror(pamh, result), "pam_acct_mgmt");`
`287`	`289`	`zval_dtor(status);`
`288`	`290`	`ZVAL_STRING(status, error_msg);`
	`291`	`+ efree(error_msg);`
`289`	`292`	`}`
`290`	`293`	`pam_end(pamh, PAM_SUCCESS);`
`291`	`294`	`RETURN_FALSE;`
`@@ -327,6 +330,7 @@ PHP_FUNCTION(pam_chpass) {`
`327`	`330`	`spprintf(&error_msg, 0, "%s (in %s)", (char *) pam_strerror(pamh, result), "pam_start");`
`328`	`331`	`zval_dtor(status);`
`329`	`332`	`ZVAL_STRING(status, error_msg);`
	`333`	`+ efree(error_msg);`
`330`	`334`	`}`
`331`	`335`	`RETURN_FALSE;`
`332`	`336`	`}`
`@@ -336,6 +340,7 @@ PHP_FUNCTION(pam_chpass) {`
`336`	`340`	`spprintf(&error_msg, 0, "%s (in %s)", (char *) pam_strerror(pamh, result), "pam_authenticate");`
`337`	`341`	`zval_dtor(status);`
`338`	`342`	`ZVAL_STRING(status, error_msg);`
	`343`	`+ efree(error_msg);`
`339`	`344`	`}`
`340`	`345`	`pam_end(pamh, PAM_SUCCESS);`
`341`	`346`	`RETURN_FALSE;`
`@@ -346,6 +351,7 @@ PHP_FUNCTION(pam_chpass) {`
`346`	`351`	`spprintf(&error_msg, 0, "%s (in %s)", (char *) pam_strerror(pamh, result), "pam_chauthtok");`
`347`	`352`	`zval_dtor(status);`
`348`	`353`	`ZVAL_STRING(status, error_msg);`
	`354`	`+ efree(error_msg);`
`349`	`355`	`}`
`350`	`356`	`pam_end(pamh, PAM_SUCCESS);`
`351`	`357`	`RETURN_FALSE;`