Using trajopt_sqp on Windows fails

[Astraaaaaaa]

At file: trajopt_sqp\types.h

enum class CostPenaltyType
{
  SQUARED,
  ABSOLUTE, // conflict with macro defined in #include <wingdi.h>
  HINGE
};

// ...

double best_exact_merit{ std::numeric_limits<double>::max() };  // conflict with macro defined in minwindef.h

when I use the trajopt_sqp package would encounter with: error C2143: syntax error : missing '}' before 'constant'

how do you feel about adding those lines before CostPenaltyType?

#if (_WIN32 || _WIN64)
#undef ABSOLUTE
#undef max(a,b)
#endif

[Levi-Armstrong]

@johnwason Thoughts?

[johnwason]

@Astraaaaaaa can you place the trajopt_sqp code in a separate C++ utility file (compilation unit) that doesn't include Windows.h, and then call that utility file from your Windows code? Dealing with this type of issue is a rabbit hole that should be avoidable.