Skip to content

Commit 29b571d

Browse files
committed
Fix TaskComposerPluginFactory incomplete type deletion error
1 parent 55a2911 commit 29b571d

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

tesseract_task_composer/core/include/tesseract_task_composer/core/task_composer_plugin_factory.h

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -93,15 +93,19 @@ class TaskComposerExecutorFactory
9393

9494
class TaskComposerPluginFactory
9595
{
96+
private:
97+
struct Implementation;
98+
std::unique_ptr<Implementation> impl_;
99+
96100
public:
97101
using PluginInfoMap = std::map<std::string, tesseract_common::PluginInfo>;
98102

99103
TaskComposerPluginFactory();
100104
~TaskComposerPluginFactory();
101105
TaskComposerPluginFactory(const TaskComposerPluginFactory&) = delete;
102106
TaskComposerPluginFactory& operator=(const TaskComposerPluginFactory&) = delete;
103-
TaskComposerPluginFactory(TaskComposerPluginFactory&&) = default;
104-
TaskComposerPluginFactory& operator=(TaskComposerPluginFactory&&) = default;
107+
TaskComposerPluginFactory(TaskComposerPluginFactory&&);
108+
TaskComposerPluginFactory& operator=(TaskComposerPluginFactory&&);
105109

106110
/**
107111
* @brief Load plugins from a configuration object
@@ -303,10 +307,6 @@ class TaskComposerPluginFactory
303307
* @return The plugin information config yaml node/
304308
*/
305309
YAML::Node getConfig() const;
306-
307-
private:
308-
struct Implementation;
309-
std::unique_ptr<Implementation> impl_;
310310
};
311311
} // namespace tesseract_planning
312312
#endif // TESSERACT_TASK_COMPOSER_TASK_COMPOSER_FACTORY_H

tesseract_task_composer/core/src/task_composer_plugin_factory.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,8 @@ TaskComposerPluginFactory::TaskComposerPluginFactory(const std::string& config)
9191
// This prevents it from being defined inline.
9292
// If not the forward declare of PluginLoader cause compiler error.
9393
TaskComposerPluginFactory::~TaskComposerPluginFactory() = default;
94+
TaskComposerPluginFactory::TaskComposerPluginFactory(TaskComposerPluginFactory&&) = default;
95+
TaskComposerPluginFactory& TaskComposerPluginFactory::operator=(TaskComposerPluginFactory&&) = default;
9496

9597
void TaskComposerPluginFactory::loadConfig(const tesseract_common::TaskComposerPluginInfo& config)
9698
{

0 commit comments

Comments
 (0)