Add tests

Author: terremoth

.gitignore

@@ -6,3 +6,4 @@ composer.phar
 # composer.lock
 .idea
 .vscode
+.phpunit.cache

composer.json

@@ -3,7 +3,7 @@
     "description": "",
     "type": "library",
     "require": {
-        "php": "^8.1"
+        "php": "^8.0"
     },
     "keywords": [
         "dsv",

src/DSV/DSV.php

@@ -4,7 +4,6 @@
 
 class DSV
 {
-
     /**
      * @var non-empty-string
      */

src/DSV/DSVWriter.php

@@ -17,6 +17,7 @@ public function write(array $data, string $mode = 'wb'): void
     {
         $file = fopen($this->outputFile, $mode);
         $size = count($data);
+        $lastRowNumber = $size - 1;
 
         /**
          * @var int $rowNumber
@@ -26,7 +27,7 @@ public function write(array $data, string $mode = 'wb'): void
             $newRow = implode($this->delimiter, $row);
 
             // the record separator shouldn't be added to the end of the file:
-            if ($rowNumber !== $size - 1) {
+            if ($rowNumber !== $lastRowNumber) {
                 $newRow .= $this->recordSeparator;
             }
 

tests/DSV/.gitkeep

@@ -0,0 +1,43 @@
+<?php
+
+namespace DSV;
+
+use Exception;
+use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\TestCase;
+
+#[CoversClass(DSVReader::class)]
+class DSVReaderTest extends TestCase
+{
+    /**
+     * @throws Exception
+     */
+    public function testRead(): void
+    {
+        $mockStr = "NameCommentAliceShe said, \"Hello\" and waved.BobThis is a multi-line" .
+            "comment\r\nspanning two lines.CharlieMore fun with\ntwo lines.DianaHow about some" .
+            "UTF-8: café, naïve, résumé. 📝Edwardアップル";
+
+        $tempFile = tempnam(sys_get_temp_dir(), 'dsv-test-data');
+        $handle = fopen($tempFile, "w");
+        fwrite($handle, $mockStr);
+        fclose($handle);
+
+        $totalFileLines = 6;
+
+        $reader = new DSVReader($tempFile);
+        $result = $reader->read();
+        $this->assertEquals(count($result), $totalFileLines);
+        unlink($tempFile);
+    }
+
+    /**
+     * @throws Exception
+     */
+    public function testException(): void
+    {
+        $this->expectException(Exception::class);
+        $reader = new DSVReader(random_int(0, 999999) . '.dsv');
+        $reader->read();
+    }
+}

tests/DSV/DSVReaderTest.php

@@ -0,0 +1,22 @@
+<?php
+
+namespace DSV;
+
+use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\TestCase;
+
+#[CoversClass(DSV::class)]
+class DSVTest extends TestCase
+{
+    public function testDelimiter(): void
+    {
+        $dsv = new DSV();
+        $this->assertEquals("\x1F", $dsv->delimiter);
+    }
+
+    public function testSeparator(): void
+    {
+        $dsv = new DSV();
+        $this->assertEquals("\x1E", $dsv->recordSeparator);
+    }
+}

tests/DSV/DSVTest.php

@@ -0,0 +1,57 @@
+<?php
+
+namespace DSV;
+
+use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\Attributes\DataProvider;
+use PHPUnit\Framework\TestCase;
+
+#[CoversClass(DSVWriter::class)]
+class DSVWriterTest extends TestCase
+{
+    /**
+     * @return array[]
+     */
+    public static function dataProvider(): array
+    {
+        return [
+            [
+                [
+                    ['alpha', "fun with\ntwo lines"],
+                    ['beta', 'café, résumé 📝'],
+                    ['gamma', 'アップル']
+                ], "alphafun with\ntwo linesbetacafé, résumé 📝gammaアップル"
+            ],
+            [
+                [
+                    ['alpha']
+                ], "alpha"
+            ],
+            [
+                [
+                    ['alpha', 'beta']
+                ], "alphabeta"
+            ],
+            [
+                [
+                    ['']
+                ], ''
+            ],
+            [
+                [
+                    []
+                ], ''
+            ]
+        ];
+    }
+
+    #[DataProvider('dataProvider')]
+    public function testWrite(array $data, string $result): void
+    {
+        $file = tempnam(sys_get_temp_dir(), 'dsv-test-data');
+        $writer = new DSVWriter($file);
+        $writer->write($data);
+        $this->assertEquals($result, file_get_contents($file));
+        unlink($file);
+    }
+}