fix: error in tests

Author: Jordan-Williams2

tests/other_test.go

@@ -33,6 +33,10 @@ func TestRunAgentVpcOcp(t *testing.T) {
 	t.Parallel()
 
 	options := setupOptions(t, "logs-agent-roks", terraformDirLogsAgentROKS)
+
+	// Keep costs down by using the cloud_pak entitlement
+	options.TerraformVars["ocp_entitlement"] = "cloud_pak"
+
 	output, err := options.RunTestConsistency()
 	assert.Nil(t, err, "This should not have errored")
 	assert.NotNil(t, output, "Expected some output")

tests/pr_test.go

@@ -58,11 +58,6 @@ func setupOptions(t *testing.T, prefix string, terraformDir string) *testhelper.
 		CloudInfoService: sharedInfoSvc,
 	})
 
-	// add ocp entitlement to keep costs down for tests
-	if terraformDir == terraformDirLogsAgentROKS {
-		options.TerraformVars["ocp_entitlement"] = "cloud_pak"
-	}
-
 	return options
 }