feat: add support for terraform >= 1.3 (#264)

terraform-ibm-modules-ops · web-flow · commit 5d071ddd6771 · 2023-01-27T11:45:29.000Z
BREAKING CHANGE: module is no longer supported on terraform versions lower than 1.3
diff --git a/README.md b/README.md
@@ -888,7 +888,7 @@ statement instead the previous block.
 
 | Name | Version |
 |------|---------|
-| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.0.0 |
+| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.3.0 |
 | <a name="requirement_ibm"></a> [ibm](#requirement\_ibm) | >= 1.49.0 |
 | <a name="requirement_random"></a> [random](#requirement\_random) | >= 3.4.3 |
 | <a name="requirement_time"></a> [time](#requirement\_time) | 0.9.1 |
@@ -897,15 +897,15 @@ statement instead the previous block.
 
 | Name | Source | Version |
 |------|--------|---------|
-| <a name="module_bastion_host"></a> [bastion\_host](#module\_bastion\_host) | git::https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vsi.git | v1.1.7 |
+| <a name="module_bastion_host"></a> [bastion\_host](#module\_bastion\_host) | git::https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vsi.git | v2.0.0 |
 | <a name="module_dynamic_values"></a> [dynamic\_values](#module\_dynamic\_values) | ./dynamic_values | n/a |
-| <a name="module_f5_vsi"></a> [f5\_vsi](#module\_f5\_vsi) | git::https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vsi.git | v1.1.7 |
+| <a name="module_f5_vsi"></a> [f5\_vsi](#module\_f5\_vsi) | git::https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vsi.git | v2.0.0 |
 | <a name="module_key_management"></a> [key\_management](#module\_key\_management) | ./kms | n/a |
 | <a name="module_placement_group_map"></a> [placement\_group\_map](#module\_placement\_group\_map) | ./dynamic_values/config_modules/list_to_map | n/a |
 | <a name="module_ssh_keys"></a> [ssh\_keys](#module\_ssh\_keys) | ./ssh_key | n/a |
 | <a name="module_teleport_config"></a> [teleport\_config](#module\_teleport\_config) | ./teleport_config | n/a |
-| <a name="module_vpc"></a> [vpc](#module\_vpc) | git::https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vpc.git | v2.3.5 |
-| <a name="module_vsi"></a> [vsi](#module\_vsi) | git::https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vsi.git | v1.1.7 |
+| <a name="module_vpc"></a> [vpc](#module\_vpc) | git::https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vpc.git | v3.0.0 |
+| <a name="module_vsi"></a> [vsi](#module\_vsi) | git::https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vsi.git | v2.0.0 |
 
 ## Resources
 
diff --git a/bastion_host.tf b/bastion_host.tf
@@ -41,7 +41,7 @@ module "teleport_config" {
 ##############################################################################
 
 module "bastion_host" {
-  source                = "git::https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vsi.git?ref=v1.1.7"
+  source                = "git::https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vsi.git?ref=v2.0.0"
   for_each              = local.bastion_vsi_map
   resource_group_id     = each.value.resource_group == null ? null : local.resource_groups[each.value.resource_group]
   create_security_group = each.value.security_group == null ? false : true
diff --git a/common-dev-assets b/common-dev-assets
@@ -1 +1 @@
-Subproject commit de46c360b6f021f2da36168cf5a09b3c680da13e
+Subproject commit 73ae5e3b19eca6fa4816f54ec0724c2f1e3bac4c
diff --git a/dynamic_values/config_modules/appid/versions.tf b/dynamic_values/config_modules/appid/versions.tf
@@ -3,8 +3,7 @@
 ##############################################################################
 
 terraform {
-  required_version = ">=1.0"
-  experiments      = [module_variable_optional_attrs]
+  required_version = ">= 1.3.0"
 }
 
 ##############################################################################
diff --git a/dynamic_values/config_modules/bastion_vsi_list_to_map/versions.tf b/dynamic_values/config_modules/bastion_vsi_list_to_map/versions.tf
@@ -3,7 +3,7 @@
 ##############################################################################
 
 terraform {
-  required_version = ">=1.0"
+  required_version = ">= 1.3.0"
 }
 
 ##############################################################################
diff --git a/dynamic_values/config_modules/cluster_worker_pools/versions.tf b/dynamic_values/config_modules/cluster_worker_pools/versions.tf
@@ -3,7 +3,7 @@
 ##############################################################################
 
 terraform {
-  required_version = ">=1.0"
+  required_version = ">= 1.3.0"
 }
 
 ##############################################################################
diff --git a/dynamic_values/config_modules/clusters/versions.tf b/dynamic_values/config_modules/clusters/versions.tf
@@ -3,7 +3,7 @@
 ##############################################################################
 
 terraform {
-  required_version = ">=1.0"
+  required_version = ">= 1.3.0"
 }
 
 ##############################################################################
diff --git a/dynamic_values/config_modules/cos/versions.tf b/dynamic_values/config_modules/cos/versions.tf
@@ -3,7 +3,7 @@
 ##############################################################################
 
 terraform {
-  required_version = ">=1.0"
+  required_version = ">= 1.3.0"
 }
 
 ##############################################################################
diff --git a/dynamic_values/config_modules/f5/versions.tf b/dynamic_values/config_modules/f5/versions.tf
@@ -3,7 +3,7 @@
 ##############################################################################
 
 terraform {
-  required_version = ">=1.0"
+  required_version = ">= 1.3.0"
 }
 
 ##############################################################################
diff --git a/dynamic_values/config_modules/flow_logs/versions.tf b/dynamic_values/config_modules/flow_logs/versions.tf
@@ -3,7 +3,7 @@
 ##############################################################################
 
 terraform {
-  required_version = ">=1.0"
+  required_version = ">= 1.3.0"
 }
 
 ##############################################################################
diff --git a/dynamic_values/config_modules/get_subnets/versions.tf b/dynamic_values/config_modules/get_subnets/versions.tf
@@ -3,7 +3,7 @@
 ##############################################################################
 
 terraform {
-  required_version = ">=1.0"
+  required_version = ">= 1.3.0"
 }
 
 ##############################################################################
diff --git a/dynamic_values/config_modules/list_to_map/versions.tf b/dynamic_values/config_modules/list_to_map/versions.tf
@@ -3,7 +3,7 @@
 ##############################################################################
 
 terraform {
-  required_version = ">=1.0"
+  required_version = ">= 1.3.0"
 }
 
 ##############################################################################
diff --git a/dynamic_values/config_modules/list_to_map_value/versions.tf b/dynamic_values/config_modules/list_to_map_value/versions.tf
@@ -3,7 +3,7 @@
 ##############################################################################
 
 terraform {
-  required_version = ">=1.0"
+  required_version = ">= 1.3.0"
 }
 
 ##############################################################################
diff --git a/dynamic_values/config_modules/nested_list_to_map_and_merge/versions.tf b/dynamic_values/config_modules/nested_list_to_map_and_merge/versions.tf
@@ -3,8 +3,7 @@
 ##############################################################################
 
 terraform {
-  required_version = ">=1.0"
-  experiments      = [module_variable_optional_attrs]
+  required_version = ">= 1.3.0"
 }
 
 ##############################################################################
diff --git a/dynamic_values/config_modules/service_authorizations/versions.tf b/dynamic_values/config_modules/service_authorizations/versions.tf
@@ -3,7 +3,7 @@
 ##############################################################################
 
 terraform {
-  required_version = ">=1.0"
+  required_version = ">= 1.3.0"
 }
 
 ##############################################################################
diff --git a/dynamic_values/config_modules/vpe/versions.tf b/dynamic_values/config_modules/vpe/versions.tf
@@ -3,7 +3,7 @@
 ##############################################################################
 
 terraform {
-  required_version = ">=1.0"
+  required_version = ">= 1.3.0"
 }
 
 ##############################################################################
diff --git a/dynamic_values/config_modules/vpn/versions.tf b/dynamic_values/config_modules/vpn/versions.tf
@@ -3,7 +3,7 @@
 ##############################################################################
 
 terraform {
-  required_version = ">=1.0"
+  required_version = ">= 1.3.0"
 }
 
 ##############################################################################
diff --git a/dynamic_values/config_modules/vsi/versions.tf b/dynamic_values/config_modules/vsi/versions.tf
@@ -3,7 +3,7 @@
 ##############################################################################
 
 terraform {
-  required_version = ">=1.0"
+  required_version = ">= 1.3.0"
 }
 
 ##############################################################################
diff --git a/dynamic_values/versions.tf b/dynamic_values/versions.tf
@@ -3,7 +3,7 @@
 ##############################################################################
 
 terraform {
-  required_version = ">=1.0"
+  required_version = ">= 1.3.0"
 }
 
 ##############################################################################
diff --git a/examples/basic/version.tf b/examples/basic/version.tf
@@ -1,6 +1,5 @@
 terraform {
-  required_version = ">= 1.0.0"
-  experiments      = [module_variable_optional_attrs]
+  required_version = ">= 1.3.0"
   required_providers {
     # Pin to the lowest provider version of the range defined in the main module's version.tf to ensure lowest version still works
     ibm = {
diff --git a/examples/no-compute-example/version.tf b/examples/no-compute-example/version.tf
@@ -1,6 +1,5 @@
 terraform {
-  required_version = ">= 1.0.0"
-  experiments      = [module_variable_optional_attrs]
+  required_version = ">= 1.3.0"
   required_providers {
     # Pin to the lowest provider version of the range defined in the main module's version.tf to ensure lowest version still works
     ibm = {
diff --git a/examples/one-vpc-one-vsi/version.tf b/examples/one-vpc-one-vsi/version.tf
@@ -1,6 +1,5 @@
 terraform {
-  required_version = ">= 1.0.0"
-  experiments      = [module_variable_optional_attrs]
+  required_version = ">= 1.3.0"
   required_providers {
     # Pin to the lowest provider version of the range defined in the main module's version.tf to ensure lowest version still works
     ibm = {
diff --git a/examples/override-example/version.tf b/examples/override-example/version.tf
@@ -1,6 +1,5 @@
 terraform {
-  required_version = ">= 1.0.0"
-  experiments      = [module_variable_optional_attrs]
+  required_version = ">= 1.3.0"
   required_providers {
     # Pin to the lowest provider version of the range defined in the main module's version.tf to ensure lowest version still works
     ibm = {
diff --git a/examples/quickstart/version.tf b/examples/quickstart/version.tf
@@ -1,6 +1,5 @@
 terraform {
-  required_version = ">= 1.0.0"
-  experiments      = [module_variable_optional_attrs]
+  required_version = ">= 1.3.0"
   required_providers {
     # Pin to the lowest provider version of the range defined in the main module's version.tf to ensure lowest version still works
     ibm = {
diff --git a/f5_config/versions.tf b/f5_config/versions.tf
@@ -3,8 +3,7 @@
 ##############################################################################
 
 terraform {
-  required_version = ">=1.0"
-  experiments      = [module_variable_optional_attrs]
+  required_version = ">= 1.3.0"
 }
 
 ##############################################################################
diff --git a/f5_vsi.tf b/f5_vsi.tf
@@ -116,7 +116,7 @@ locals {
 ##############################################################################
 
 module "f5_vsi" {
-  source                      = "git::https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vsi.git?ref=v1.1.7"
+  source                      = "git::https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vsi.git?ref=v2.0.0"
   for_each                    = local.f5_vsi_map
   resource_group_id           = each.value.resource_group == null ? null : local.resource_groups[each.value.resource_group]
   create_security_group       = each.value.security_group == null ? false : true
diff --git a/kms/dynamic_values/versions.tf b/kms/dynamic_values/versions.tf
@@ -3,8 +3,7 @@
 ##############################################################################
 
 terraform {
-  required_version = ">=1.0"
-  experiments      = [module_variable_optional_attrs]
+  required_version = ">= 1.3.0"
 }
 
 ##############################################################################
diff --git a/kms/versions.tf b/kms/versions.tf
@@ -10,8 +10,7 @@ terraform {
       version = ">= 1.49.0"
     }
   }
-  required_version = ">=1.0"
-  experiments      = [module_variable_optional_attrs]
+  required_version = ">= 1.3.0"
 }
 
 ##############################################################################
diff --git a/main.tf b/main.tf
@@ -8,7 +8,7 @@ locals {
 }
 
 module "vpc" {
-  source                      = "git::https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vpc.git?ref=v2.3.5"
+  source                      = "git::https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vpc.git?ref=v3.0.0"
   for_each                    = local.vpc_map
   name                        = each.value.prefix
   tags                        = var.tags
diff --git a/module-metadata.json b/module-metadata.json
@@ -726,7 +726,7 @@
     }
   },
   "required_core": [
-    "\u003e= 1.0.0"
+    "\u003e= 1.3.0"
   ],
   "required_providers": {
     "ibm": {
@@ -1346,7 +1346,7 @@
   "module_calls": {
     "bastion_host": {
       "name": "bastion_host",
-      "source": "git::https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vsi.git?ref=v1.1.7",
+      "source": "git::https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vsi.git?ref=v2.0.0",
       "attributes": {
         "prefix": "prefix"
       },
@@ -1896,7 +1896,7 @@
     },
     "f5_vsi": {
       "name": "f5_vsi",
-      "source": "git::https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vsi.git?ref=v1.1.7",
+      "source": "git::https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vsi.git?ref=v2.0.0",
       "attributes": {
         "prefix": "prefix"
       },
@@ -2418,7 +2418,7 @@
     },
     "vpc": {
       "name": "vpc",
-      "source": "git::https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vpc.git?ref=v2.3.5",
+      "source": "git::https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vpc.git?ref=v3.0.0",
       "attributes": {
         "network_cidr": "network_cidr",
         "prefix": "prefix",
@@ -2650,7 +2650,7 @@
     },
     "vsi": {
       "name": "vsi",
-      "source": "git::https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vsi.git?ref=v1.1.7",
+      "source": "git::https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vsi.git?ref=v2.0.0",
       "attributes": {
         "prefix": "prefix",
         "tags": "tags"
diff --git a/patterns/dynamic_values/config_modules/acl_rules/versions.tf b/patterns/dynamic_values/config_modules/acl_rules/versions.tf
@@ -3,8 +3,7 @@
 ##############################################################################
 
 terraform {
-  required_version = ">=1.0"
-  experiments      = [module_variable_optional_attrs]
+  required_version = ">= 1.3.0"
 }
 
 ##############################################################################
diff --git a/patterns/dynamic_values/config_modules/bastion_gateways/versions.tf b/patterns/dynamic_values/config_modules/bastion_gateways/versions.tf
@@ -3,8 +3,7 @@
 ##############################################################################
 
 terraform {
-  required_version = ">=1.0"
-  experiments      = [module_variable_optional_attrs]
+  required_version = ">= 1.3.0"
 }
 
 ##############################################################################
diff --git a/patterns/dynamic_values/config_modules/bastion_vsi/versions.tf b/patterns/dynamic_values/config_modules/bastion_vsi/versions.tf
@@ -3,8 +3,7 @@
 ##############################################################################
 
 terraform {
-  required_version = ">=1.0"
-  experiments      = [module_variable_optional_attrs]
+  required_version = ">= 1.3.0"
 }
 
 ##############################################################################
diff --git a/patterns/dynamic_values/config_modules/bastion_zone_list/versions.tf b/patterns/dynamic_values/config_modules/bastion_zone_list/versions.tf
@@ -3,8 +3,7 @@
 ##############################################################################
 
 terraform {
-  required_version = ">=1.0"
-  experiments      = [module_variable_optional_attrs]
+  required_version = ">= 1.3.0"
 }
 
 ##############################################################################
diff --git a/patterns/dynamic_values/config_modules/cloud_object_storage/versions.tf b/patterns/dynamic_values/config_modules/cloud_object_storage/versions.tf
@@ -3,8 +3,7 @@
 ##############################################################################
 
 terraform {
-  required_version = ">=1.0"
-  experiments      = [module_variable_optional_attrs]
+  required_version = ">= 1.3.0"
 }
 
 ##############################################################################
diff --git a/patterns/dynamic_values/config_modules/default_security_group_rules/versions.tf b/patterns/dynamic_values/config_modules/default_security_group_rules/versions.tf
@@ -3,8 +3,7 @@
 ##############################################################################
 
 terraform {
-  required_version = ">=1.0"
-  experiments      = [module_variable_optional_attrs]
+  required_version = ">= 1.3.0"
 }
 
 ##############################################################################
diff --git a/patterns/dynamic_values/config_modules/f5_deployments/versions.tf b/patterns/dynamic_values/config_modules/f5_deployments/versions.tf
@@ -3,8 +3,7 @@
 ##############################################################################
 
 terraform {
-  required_version = ">=1.0"
-  experiments      = [module_variable_optional_attrs]
+  required_version = ">= 1.3.0"
 }
 
 ##############################################################################
diff --git a/patterns/dynamic_values/config_modules/f5_security_group_rules/versions.tf b/patterns/dynamic_values/config_modules/f5_security_group_rules/versions.tf
@@ -3,8 +3,7 @@
 ##############################################################################
 
 terraform {
-  required_version = ">=1.0"
-  experiments      = [module_variable_optional_attrs]
+  required_version = ">= 1.3.0"
 }
 
 ##############################################################################
diff --git a/patterns/dynamic_values/config_modules/f5_tiers/versions.tf b/patterns/dynamic_values/config_modules/f5_tiers/versions.tf
diff --git a/patterns/dynamic_values/config_modules/key_management/versions.tf b/patterns/dynamic_values/config_modules/key_management/versions.tf
diff --git a/patterns/dynamic_values/config_modules/network_acls/versions.tf b/patterns/dynamic_values/config_modules/network_acls/versions.tf
diff --git a/patterns/dynamic_values/config_modules/resource_groups/versions.tf b/patterns/dynamic_values/config_modules/resource_groups/versions.tf
diff --git a/patterns/dynamic_values/config_modules/security_groups/versions.tf b/patterns/dynamic_values/config_modules/security_groups/versions.tf
diff --git a/patterns/dynamic_values/config_modules/subnet_cidr/versions.tf b/patterns/dynamic_values/config_modules/subnet_cidr/versions.tf
diff --git a/patterns/dynamic_values/config_modules/vpc/versions.tf b/patterns/dynamic_values/config_modules/vpc/versions.tf
diff --git a/patterns/dynamic_values/config_modules/vpc_address_prefixes/versions.tf b/patterns/dynamic_values/config_modules/vpc_address_prefixes/versions.tf
diff --git a/patterns/dynamic_values/config_modules/vpc_subnet_tiers/versions.tf b/patterns/dynamic_values/config_modules/vpc_subnet_tiers/versions.tf
diff --git a/patterns/dynamic_values/versions.tf b/patterns/dynamic_values/versions.tf
diff --git a/patterns/mixed/versions.tf b/patterns/mixed/versions.tf
diff --git a/patterns/roks/versions.tf b/patterns/roks/versions.tf
diff --git a/patterns/vsi/versions.tf b/patterns/vsi/versions.tf
diff --git a/ssh_key/versions.tf b/ssh_key/versions.tf
diff --git a/teleport_config/versions.tf b/teleport_config/versions.tf
diff --git a/tests/resources/version.tf b/tests/resources/version.tf
diff --git a/version.tf b/version.tf
diff --git a/virtual_servers.tf b/virtual_servers.tf

Original file line number	Diff line number	Diff line change
`@@ -3,8 +3,7 @@`
`3`	`3`	`##############################################################################`
`4`	`4`
`5`	`5`	`terraform {`
`6`		`- required_version = ">=1.0"`
`7`		`- experiments = [module_variable_optional_attrs]`
	`6`	`+ required_version = ">= 1.3.0"`
`8`	`7`	`}`
`9`	`8`
`10`	`9`	`##############################################################################`
Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`	`##############################################################################`
`4`	`4`
`5`	`5`	`terraform {`
`6`		`- required_version = ">=1.0"`
	`6`	`+ required_version = ">= 1.3.0"`
`7`	`7`	`}`
`8`	`8`
`9`	`9`	`##############################################################################`