Merge branch 'main' into deprecate_refs

Author: imprateeksh

README.md

@@ -44,15 +44,13 @@ Expected network connectivity downtime of typically around 20 seconds.
     * [workload-vpc](./modules/workload-vpc)
 * [Examples](./examples)
     * [Basic Example](./examples/basic)
-    * [Custom Security Group Example](./examples/custom_security_group)
-    * [Default Example](./examples/default)
-    * [Existing VPC and subnets Example](./examples/existing_vpc)
+    * [Existing networking resources Example](./examples/existing_vpc)
     * [Hub and Spoke VPC Example](./examples/hub-spoke-delegated-resolver)
     * [Hub and Spoke VPC with manual DNS resolver Example](./examples/hub-spoke-manual-resolver)
     * [Landing Zone example](./examples/landing_zone)
-    * [No Prefix Example](./examples/no-prefix)
     * [Specific Zone Only Example](./examples/specific-zone-only)
     * [VPC with DNS example](./examples/vpc-with-dns)
+    * [VPC with Flow Logs stored in COS Example](./examples/vpc-flow-logs)
 * [Contributing](#contributing)
 <!-- END OVERVIEW HOOK -->
 

examples/basic/README.md

@@ -5,4 +5,6 @@ A simple example to provision a Secure Landing Zone (SLZ) Virtual Private Cloud
 The following resources are provisioned by this example:
 
 * A new resource group, if an existing one is not passed in.
-* An IBM Virtual Private Cloud (VPC) with a publicly exposed subnet.
+* An IBM Virtual Private Cloud (VPC) with:
+  * Publicly exposed subnet.
+  * Custom security group rules.

examples/basic/main.tf

@@ -5,7 +5,7 @@
 
 module "resource_group" {
   source  = "terraform-ibm-modules/resource-group/ibm"
-  version = "1.2.1"
+  version = "1.4.0"
   # if an existing resource group is not set (null) create a new one using prefix
   resource_group_name          = var.resource_group == null ? "${var.prefix}-resource-group" : null
   existing_resource_group_name = var.resource_group
@@ -32,4 +32,11 @@ module "slz_vpc" {
       }
     ]
   }
+  security_group_rules = [{
+    name       = "allow-all-inbound-sg"
+    direction  = "inbound"
+    remote     = "0.0.0.0/0" # source of the traffic. 0.0.0.0/0 traffic from all across the internet.
+    local      = "0.0.0.0/0" # A CIDR block of 0.0.0.0/0 allows traffic to all local IP addresses (or from all local IP addresses, for outbound rules).
+    ip_version = "ipv4"
+  }]
 }

examples/custom_security_group/README.md

@@ -1,3 +1,5 @@
-# Existing VPC and subnets Example
+# Existing networking resources Example
 
-An example of calling the module with an existing VPC and subnets.
+This example demonstrate how to configure the module without creating new resources.
+
+It configures existing VPC, existing subnets and an existing Public Gateway.