Skip to content

Commit 5ec4f07

Browse files
authored
feat: DA updates:<br>- updated the default value for cluster_name to "cluster"<br>- updated the default value of the prefix inputto start with "ocp"<br>- added validation for the default_worker_pool_workers_per_zone<br>- updated some inout to leverage the new rich choise input widget (#862)
1 parent d7ebdda commit 5ec4f07

File tree

3 files changed

+68
-14
lines changed

3 files changed

+68
-14
lines changed

ibm_catalog.json

Lines changed: 66 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@
234234
},
235235
{
236236
"key": "prefix",
237-
"default_value": "dev",
237+
"default_value": "ocp",
238238
"random_string": {
239239
"length": 4
240240
},
@@ -478,7 +478,16 @@
478478
},
479479
{
480480
"key": "default_worker_pool_workers_per_zone",
481-
"required": true
481+
"type": "string",
482+
"default_value": "1",
483+
"required": true,
484+
"value_constraints": [
485+
{
486+
"type": "regex",
487+
"description": "Worker count per zone must be greater than 0.",
488+
"value": "^[1-9][0-9]*$"
489+
}
490+
]
482491
},
483492
{
484493
"key": "default_worker_pool_operating_system",
@@ -505,7 +514,19 @@
505514
},
506515
{
507516
"key": "allow_public_access_to_cluster_management",
508-
"required": true
517+
"required": true,
518+
"options": [
519+
{
520+
"description": "Allow access to the cluster management through a public endpoint.",
521+
"displayname": "True",
522+
"value": true
523+
},
524+
{
525+
"description": "Restrict access to private network only.",
526+
"displayname": "False",
527+
"value": false
528+
}
529+
]
509530
},
510531
{
511532
"key": "enable_platform_metrics",
@@ -719,7 +740,19 @@
719740
]
720741
},
721742
{
722-
"key": "allow_outbound_traffic"
743+
"key": "allow_outbound_traffic",
744+
"options": [
745+
{
746+
"description": "Allows all outbound traffic from the cluster with no restrictions applied.",
747+
"displayname": "True",
748+
"value": true
749+
},
750+
{
751+
"description": "Allows only essential outbound traffic for cluster functionality; blocks all other access.",
752+
"displayname": "False",
753+
"value": false
754+
}
755+
]
723756
},
724757
{
725758
"key": "verify_worker_network_readiness",
@@ -898,8 +931,8 @@
898931
"value": "standard"
899932
},
900933
{
901-
"description": "Try Secrets Manager at no cost for 30 days. Unlimited access to all service capabilities for a limited time. You can have one Trial instance provisioned in your account at any time. After your trial expires, functionality is removed.",
902-
"displayname": "Trial",
934+
"description": "Choose this option only if your account does not already have a Trial plan instance. Only one Trial plan instance is allowed per account. After it expires, upgrade to the Standard plan to keep using Secrets Manager.",
935+
"displayname": "Trial (30 days)",
903936
"value": "trial"
904937
}
905938
]
@@ -1405,7 +1438,7 @@
14051438
{
14061439
"key": "prefix",
14071440
"required": true,
1408-
"default_value": "dev",
1441+
"default_value": "ocp",
14091442
"random_string": {
14101443
"length": 4
14111444
},
@@ -1553,10 +1586,34 @@
15531586
}
15541587
},
15551588
{
1556-
"key": "allow_public_access_to_cluster_management"
1589+
"key": "allow_public_access_to_cluster_management",
1590+
"options": [
1591+
{
1592+
"description": "Allow access to the cluster management through a public endpoint.",
1593+
"displayname": "True",
1594+
"value": true
1595+
},
1596+
{
1597+
"description": "Restrict access to private network only.",
1598+
"displayname": "False",
1599+
"value": false
1600+
}
1601+
]
15571602
},
15581603
{
1559-
"key": "allow_outbound_traffic"
1604+
"key": "allow_outbound_traffic",
1605+
"options": [
1606+
{
1607+
"description": "Allows all outbound traffic from the cluster with no restrictions applied.",
1608+
"displayname": "True",
1609+
"value": true
1610+
},
1611+
{
1612+
"description": "Allows only essential outbound traffic for cluster functionality; blocks all other access.",
1613+
"displayname": "False",
1614+
"value": false
1615+
}
1616+
]
15601617
}
15611618
],
15621619
"dependency_version_2": true,

solutions/fully-configurable/variables.tf

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ variable "prefix" {
3838
}
3939
}
4040

41-
4241
variable "existing_resource_group_name" {
4342
type = string
4443
description = "The name of an existing resource group to provision the resources. [Learn more](https://cloud.ibm.com/docs/account?topic=account-rgs&interface=ui#create_rgs) about how to create a resource group."
@@ -64,7 +63,7 @@ variable "access_tags" {
6463
variable "cluster_name" {
6564
type = string
6665
description = "The name of the new IBM Cloud OpenShift Cluster. If a `prefix` input variable is specified, it is added to this name in the `<prefix>-value` format."
67-
default = "openshift"
66+
default = "cluster"
6867
}
6968

7069
variable "openshift_version" {

solutions/quickstart/variables.tf

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,10 +56,9 @@ variable "openshift_version" {
5656
variable "cluster_name" {
5757
type = string
5858
description = "The name of the new IBM Cloud OpenShift Cluster. If a `prefix` input variable is specified, it is added to this name in the `<prefix>-value` format."
59-
default = "openshift-qs"
59+
default = "cluster"
6060
}
6161

62-
6362
variable "address_prefix" {
6463
description = "The IP range that defines a certain location for the VPC. Use only with manual address prefixes."
6564
type = string
@@ -72,7 +71,6 @@ variable "ocp_entitlement" {
7271
default = null
7372
}
7473

75-
7674
variable "default_worker_pool_operating_system" {
7775
type = string
7876
description = "The operating system installed on the worker nodes. [Learn more](https://cloud.ibm.com/docs/openshift?topic=openshift-vpc-flavors)."

0 commit comments

Comments
 (0)