ci: update the pre commit hook symlink (#268)

Author: ocofaigh

.pre-commit-config.yaml

@@ -1 +1 @@
-common-dev-assets/stack-assets/.pre-commit-config.yaml
+common-dev-assets/module-assets/.pre-commit-config.yaml

common-dev-assets

@@ -149,7 +149,7 @@
               },
               {
                 "title": "Creates an IBM Cloud App Configuration instance with Configuration Aggregator",
-                "description": "Facilitate a Cloud Governance SME with up-to-date configuration data of IBM Cloud resources in one place so that comprehensive information is available for goverance and compliance initiatives."
+                "description": "Facilitate a Cloud Governance SME with up-to-date configuration data of IBM Cloud resources in one place so that comprehensive information is available for governance and compliance initiatives."
               },
               {
                 "title": "Creates a IBM Cloud Security and Compliance Center Workload Protection instance",

ibm_catalog.json

@@ -3,7 +3,6 @@ package tests
 import (
 	"fmt"
 	"log"
-	"math/rand"
 	"os"
 	"strings"
 	"testing"
@@ -53,7 +52,7 @@ func TestProjectsFullTest(t *testing.T) {
 
 	options.StackInputs = map[string]interface{}{
 		"prefix":                         options.Prefix,
-		"region":                         validRegions[rand.Intn(len(validRegions))],
+		"region":                         validRegions[common.CryptoIntn(len(validRegions))],
 		"existing_resource_group_name":   resourceGroup,
 		"secrets_manager_service_plan":   "trial",
 		"ibmcloud_api_key":               options.RequiredEnvironmentVars["TF_VAR_ibmcloud_api_key"], // always required by the stack
@@ -76,7 +75,7 @@ func TestProjectsExistingResourcesTest(t *testing.T) {
 	// Provision RG and EN
 	// ------------------------------------------------------------------------------------
 
-	region := validRegions[rand.Intn(len(validRegions))]
+	region := validRegions[common.CryptoIntn(len(validRegions))]
 	prefix := fmt.Sprintf("css-ext-%s", strings.ToLower(random.UniqueId()))
 	realTerraformDir := "./resources"
 	tempTerraformDir, _ := files.CopyTerraformFolderToTemp(realTerraformDir, fmt.Sprintf(prefix+"-%s", strings.ToLower(random.UniqueId())))

tests/pr_test.go

@@ -30,8 +30,8 @@ module "event_notifications" {
 ##############################################################################
 
 module "key_protect" {
-  source = "terraform-ibm-modules/kms-all-inclusive/ibm"
-  version= "5.5.0"
+  source            = "terraform-ibm-modules/kms-all-inclusive/ibm"
+  version           = "5.5.0"
   resource_group_id = module.resource_group.resource_group_id
-  region = var.region
+  region            = var.region
 }

tests/resources/main.tf

@@ -24,6 +24,6 @@ output "event_notification_instance_crn" {
 }
 
 output "key_project_instance_crn" {
-  value = module.key_protect.key_protect_crn
+  value       = module.key_protect.key_protect_crn
   description = "CRN of created Key Protect instance"
 }