feat: Add support for custom display_name and description #18 (#19)

* Resolves #18

Added support for display_name and description when creating the service acocunts.

* Upped provider version in examples to latest version, since version 2.7.0 of google provider did not support description field.

Author: schostin

CHANGELOG.md

@@ -11,6 +11,7 @@ and this project adheres to
 
 ### Added
 
+- Support for `display_name` and `description` [#18]
 - Use `for_each` instead of `count` [#15]
 
 ## [2.0.2] - 2019-10-09

README.md

@@ -43,6 +43,8 @@ Functional examples are included in the
 | Name | Description | Type | Default | Required |
 |------|-------------|:----:|:-----:|:-----:|
 | billing\_account\_id | If assigning billing role, specificy a billing account (default is to assign at the organizational level). | string | `""` | no |
+| description | Descriptions of the created service accounts (defaults to no description) | string | `""` | no |
+| display\_name | Display names of the created service accounts (defaults to 'Terraform-managed service account') | string | `"Terraform-managed service account"` | no |
 | generate\_keys | Generate keys for service accounts. | bool | `"false"` | no |
 | grant\_billing\_role | Grant billing user role. | bool | `"false"` | no |
 | grant\_xpn\_roles | Grant roles for shared VPC management. | bool | `"true"` | no |

examples/multiple_service_accounts/main.tf

@@ -15,7 +15,7 @@
  */
 
 provider "google" {
-  version = "~> 2.7.0"
+  version = "~> 3.17.0"
 }
 
 module "service_accounts" {
@@ -24,6 +24,8 @@ module "service_accounts" {
   prefix        = ""
   names         = ["test-first", "test-second"]
   generate_keys = true
+  display_name  = "Test Service Accounts"
+  description   = "Test Service Accounts description"
 
   project_roles = [
     "${var.project_id}=>roles/viewer",

examples/single_service_account/main.tf

@@ -15,7 +15,7 @@
  */
 
 provider "google" {
-  version = "~> 2.7.0"
+  version = "~> 3.17.0"
 }
 
 module "service_accounts" {
@@ -24,5 +24,7 @@ module "service_accounts" {
   prefix        = var.prefix
   names         = ["single-account"]
   project_roles = ["${var.project_id}=>roles/viewer"]
+  display_name  = "Single Account"
+  description   = "Single Account Description"
 }
 

main.tf

@@ -37,7 +37,8 @@ locals {
 resource "google_service_account" "service_accounts" {
   for_each     = local.names
   account_id   = "${local.prefix}${lower(each.value)}"
-  display_name = "Terraform-managed service account"
+  display_name = var.display_name
+  description  = var.description
   project      = var.project_id
 }
 

variables.tf

@@ -67,3 +67,14 @@ variable "generate_keys" {
   default     = false
 }
 
+variable "display_name" {
+  type        = string
+  description = "Display names of the created service accounts (defaults to 'Terraform-managed service account')"
+  default     = "Terraform-managed service account"
+}
+
+variable "description" {
+  type        = string
+  description = "Descriptions of the created service accounts (defaults to no description)"
+  default     = ""
+}