From 17937aecce2bcf3d32bff18a30eb2f4de1f4a60e Mon Sep 17 00:00:00 2001
From: Daisy <daisypkhoja@google.com>
Date: Wed, 15 Oct 2025 05:28:24 +0000
Subject: [PATCH] updated description in nodepool field

---
 modules/gke-node-pool/README.md     | 2 +-
 modules/gke-node-pool/metadata.yaml | 4 ++--
 modules/gke-node-pool/variables.tf  | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/modules/gke-node-pool/README.md b/modules/gke-node-pool/README.md
index 0a6fd327f2..ab169b93db 100644
--- a/modules/gke-node-pool/README.md
+++ b/modules/gke-node-pool/README.md
@@ -7,7 +7,7 @@
 | Name | Description | Type | Default | Required |
 |------|-------------|------|---------|:--------:|
 | autoscaling | Configuration required by cluster autoscaler to adjust the size of the node pool to the current cluster usage. | <pre>object({<br>    min_node_count       = optional(number)<br>    max_node_count       = optional(number)<br>    total_min_node_count = optional(number)<br>    total_max_node_count = optional(number)<br>    location_policy      = optional(string)<br>  })</pre> | <pre>{<br>  "max_node_count": 100,<br>  "min_node_count": 1<br>}</pre> | no |
-| cluster | The cluster to create the node pool for. Cluster must be present in location provided for clusters. May be specified in the format projects/{{project\_id}}/locations/{{location}}/clusters/{{cluster}} or as just the name of the cluster. | `string` | n/a | yes |
+| cluster | The cluster to create the node pool for. Cluster must be present in location provided for clusters. May be specified in the format projects/{project\_id}/locations/{location}/clusters/{cluster} or as just the name of the cluster. | `string` | n/a | yes |
 | initial\_node\_count | The initial number of nodes for the pool. In regional or multi-zonal clusters, this is the number of nodes per zone. | `number` | `null` | no |
 | kubernetes\_version | The Kubernetes version for the nodes in this pool. Note that if this field and auto\_upgrade are both specified, they will fight each other for what the node version should be, so setting both is highly discouraged. While a fuzzy version can be specified, it's recommended that you specify explicit versions as Terraform will see spurious diffs when fuzzy versions are used. See the google\_container\_engine\_versions data source's version\_prefix field to approximate fuzzy versions in a Terraform-compatible way. | `string` | `null` | no |
 | location | The location (region or zone) of the cluster. | `string` | `null` | no |
diff --git a/modules/gke-node-pool/metadata.yaml b/modules/gke-node-pool/metadata.yaml
index ebc5802170..d858c59314 100644
--- a/modules/gke-node-pool/metadata.yaml
+++ b/modules/gke-node-pool/metadata.yaml
@@ -127,7 +127,7 @@ spec:
   interfaces:
     variables:
       - name: cluster
-        description: The cluster to create the node pool for. Cluster must be present in location provided for clusters. May be specified in the format projects/{{project_id}}/locations/{{location}}/clusters/{{cluster}} or as just the name of the cluster.
+        description: The cluster to create the node pool for. Cluster must be present in location provided for clusters. May be specified in the format projects/{project_id}/locations/{location}/clusters/{cluster} or as just the name of the cluster.
         varType: string
         required: true
         connections:
@@ -409,9 +409,9 @@ spec:
     roles:
       - level: Project
         roles:
+          - roles/compute.admin
           - roles/container.admin
           - roles/iam.serviceAccountUser
-          - roles/compute.admin
     services:
       - compute.googleapis.com
       - container.googleapis.com
diff --git a/modules/gke-node-pool/variables.tf b/modules/gke-node-pool/variables.tf
index a825a614bc..eb52b1ed0b 100644
--- a/modules/gke-node-pool/variables.tf
+++ b/modules/gke-node-pool/variables.tf
@@ -15,7 +15,7 @@
  */
 
 variable "cluster" {
-  description = "The cluster to create the node pool for. Cluster must be present in location provided for clusters. May be specified in the format projects/{{project_id}}/locations/{{location}}/clusters/{{cluster}} or as just the name of the cluster."
+  description = "The cluster to create the node pool for. Cluster must be present in location provided for clusters. May be specified in the format projects/{project_id}/locations/{location}/clusters/{cluster} or as just the name of the cluster."
   type        = string
 }