diff --git a/README.md b/README.md index 13bce0b766..f5480b2183 100644 --- a/README.md +++ b/README.md @@ -166,6 +166,7 @@ Then perform the following commands on the root folder: | enable\_confidential\_nodes | An optional flag to enable confidential node config. | `bool` | `false` | no | | enable\_cost\_allocation | Enables Cost Allocation Feature and the cluster name and namespace of your GKE workloads appear in the labels field of the billing export to BigQuery | `bool` | `false` | no | | enable\_default\_node\_pools\_metadata | Whether to enable the default node pools metadata key-value pairs such as `cluster_name` and `node_pool` | `bool` | `true` | no | +| enable\_gcfs | Enable image streaming on cluster level. | `bool` | `false` | no | | enable\_identity\_service | (Optional) Enable the Identity Service component, which allows customers to use external identity providers with the K8S API. | `bool` | `false` | no | | enable\_intranode\_visibility | Whether Intra-node visibility is enabled for this cluster. This makes same node pod to pod traffic visible for VPC network | `bool` | `false` | no | | enable\_kubernetes\_alpha | Whether to enable Kubernetes Alpha features for this cluster. Note that when this option is enabled, the cluster cannot be upgraded and will be automatically deleted after 30 days. | `bool` | `false` | no | diff --git a/autogen/main/cluster.tf.tmpl b/autogen/main/cluster.tf.tmpl index b78bd4e247..b9ac123849 100644 --- a/autogen/main/cluster.tf.tmpl +++ b/autogen/main/cluster.tf.tmpl @@ -698,11 +698,9 @@ resource "google_container_cluster" "primary" { } {% endif %} {% if autopilot_cluster != true %} - {% if beta_cluster %} gcfs_config { enabled = var.enable_gcfs } - {% endif %} insecure_kubelet_readonly_port_enabled = var.insecure_kubelet_readonly_port_enabled != null ? upper(tostring(var.insecure_kubelet_readonly_port_enabled)) : null {% endif %} } diff --git a/autogen/main/variables.tf.tmpl b/autogen/main/variables.tf.tmpl index b387fc8ccd..1cc0fff491 100644 --- a/autogen/main/variables.tf.tmpl +++ b/autogen/main/variables.tf.tmpl @@ -614,6 +614,17 @@ variable "enable_confidential_nodes" { default = false } +variable "enable_gcfs" { + type = bool + description = "Enable image streaming on cluster level." + {% if autopilot_cluster != true %} + default = false + {% endif %} + {% if autopilot_cluster %} + default = true + {% endif %} +} + variable "enable_secret_manager_addon" { description = "Enable the Secret Manager add-on for this cluster" type = bool @@ -987,17 +998,6 @@ variable "sandbox_enabled" { default = false } {% endif %} - -variable "enable_gcfs" { - type = bool - description = "(Beta) Enable image streaming on cluster level." - {% if autopilot_cluster != true %} - default = false - {% endif %} - {% if autopilot_cluster %} - default = true - {% endif %} -} {% endif %} {% if autopilot_cluster != true %} diff --git a/cluster.tf b/cluster.tf index 274c422c19..d23489b24c 100644 --- a/cluster.tf +++ b/cluster.tf @@ -528,6 +528,9 @@ resource "google_container_cluster" "primary" { node_pool_defaults { node_config_defaults { + gcfs_config { + enabled = var.enable_gcfs + } insecure_kubelet_readonly_port_enabled = var.insecure_kubelet_readonly_port_enabled != null ? upper(tostring(var.insecure_kubelet_readonly_port_enabled)) : null } } diff --git a/modules/beta-autopilot-private-cluster/README.md b/modules/beta-autopilot-private-cluster/README.md index ebe6ad6382..dcbe2b64ec 100644 --- a/modules/beta-autopilot-private-cluster/README.md +++ b/modules/beta-autopilot-private-cluster/README.md @@ -93,7 +93,7 @@ Then perform the following commands on the root folder: | enable\_confidential\_nodes | An optional flag to enable confidential node config. | `bool` | `false` | no | | enable\_cost\_allocation | Enables Cost Allocation Feature and the cluster name and namespace of your GKE workloads appear in the labels field of the billing export to BigQuery | `bool` | `false` | no | | enable\_fqdn\_network\_policy | Enable FQDN Network Policies on the cluster | `bool` | `null` | no | -| enable\_gcfs | (Beta) Enable image streaming on cluster level. | `bool` | `true` | no | +| enable\_gcfs | Enable image streaming on cluster level. | `bool` | `true` | no | | enable\_l4\_ilb\_subsetting | Enable L4 ILB Subsetting on the cluster | `bool` | `false` | no | | enable\_network\_egress\_export | Whether to enable network egress metering for this cluster. If enabled, a daemonset will be created in the cluster to meter network egress traffic. | `bool` | `false` | no | | enable\_private\_endpoint | Whether the master's internal IP address is used as the cluster endpoint | `bool` | `false` | no | diff --git a/modules/beta-autopilot-private-cluster/variables.tf b/modules/beta-autopilot-private-cluster/variables.tf index 8133c5e89c..ea5d63dd05 100644 --- a/modules/beta-autopilot-private-cluster/variables.tf +++ b/modules/beta-autopilot-private-cluster/variables.tf @@ -382,6 +382,12 @@ variable "enable_confidential_nodes" { default = false } +variable "enable_gcfs" { + type = bool + description = "Enable image streaming on cluster level." + default = true +} + variable "enable_secret_manager_addon" { description = "Enable the Secret Manager add-on for this cluster" type = bool @@ -572,12 +578,6 @@ variable "enable_l4_ilb_subsetting" { default = false } -variable "enable_gcfs" { - type = bool - description = "(Beta) Enable image streaming on cluster level." - default = true -} - variable "allow_net_admin" { description = "(Optional) Enable NET_ADMIN for the cluster." type = bool diff --git a/modules/beta-autopilot-public-cluster/README.md b/modules/beta-autopilot-public-cluster/README.md index 3a81f58166..e3a5b16b20 100644 --- a/modules/beta-autopilot-public-cluster/README.md +++ b/modules/beta-autopilot-public-cluster/README.md @@ -86,7 +86,7 @@ Then perform the following commands on the root folder: | enable\_confidential\_nodes | An optional flag to enable confidential node config. | `bool` | `false` | no | | enable\_cost\_allocation | Enables Cost Allocation Feature and the cluster name and namespace of your GKE workloads appear in the labels field of the billing export to BigQuery | `bool` | `false` | no | | enable\_fqdn\_network\_policy | Enable FQDN Network Policies on the cluster | `bool` | `null` | no | -| enable\_gcfs | (Beta) Enable image streaming on cluster level. | `bool` | `true` | no | +| enable\_gcfs | Enable image streaming on cluster level. | `bool` | `true` | no | | enable\_l4\_ilb\_subsetting | Enable L4 ILB Subsetting on the cluster | `bool` | `false` | no | | enable\_network\_egress\_export | Whether to enable network egress metering for this cluster. If enabled, a daemonset will be created in the cluster to meter network egress traffic. | `bool` | `false` | no | | enable\_resource\_consumption\_export | Whether to enable resource consumption metering on this cluster. When enabled, a table will be created in the resource export BigQuery dataset to store resource consumption data. The resulting table can be joined with the resource usage table or with BigQuery billing export. | `bool` | `true` | no | diff --git a/modules/beta-autopilot-public-cluster/variables.tf b/modules/beta-autopilot-public-cluster/variables.tf index 3d74358981..b52e47d3c4 100644 --- a/modules/beta-autopilot-public-cluster/variables.tf +++ b/modules/beta-autopilot-public-cluster/variables.tf @@ -346,6 +346,12 @@ variable "enable_confidential_nodes" { default = false } +variable "enable_gcfs" { + type = bool + description = "Enable image streaming on cluster level." + default = true +} + variable "enable_secret_manager_addon" { description = "Enable the Secret Manager add-on for this cluster" type = bool @@ -536,12 +542,6 @@ variable "enable_l4_ilb_subsetting" { default = false } -variable "enable_gcfs" { - type = bool - description = "(Beta) Enable image streaming on cluster level." - default = true -} - variable "allow_net_admin" { description = "(Optional) Enable NET_ADMIN for the cluster." type = bool diff --git a/modules/beta-private-cluster-update-variant/README.md b/modules/beta-private-cluster-update-variant/README.md index a52833f102..2212904155 100644 --- a/modules/beta-private-cluster-update-variant/README.md +++ b/modules/beta-private-cluster-update-variant/README.md @@ -203,7 +203,7 @@ Then perform the following commands on the root folder: | enable\_cost\_allocation | Enables Cost Allocation Feature and the cluster name and namespace of your GKE workloads appear in the labels field of the billing export to BigQuery | `bool` | `false` | no | | enable\_default\_node\_pools\_metadata | Whether to enable the default node pools metadata key-value pairs such as `cluster_name` and `node_pool` | `bool` | `true` | no | | enable\_fqdn\_network\_policy | Enable FQDN Network Policies on the cluster | `bool` | `null` | no | -| enable\_gcfs | (Beta) Enable image streaming on cluster level. | `bool` | `false` | no | +| enable\_gcfs | Enable image streaming on cluster level. | `bool` | `false` | no | | enable\_identity\_service | (Optional) Enable the Identity Service component, which allows customers to use external identity providers with the K8S API. | `bool` | `false` | no | | enable\_intranode\_visibility | Whether Intra-node visibility is enabled for this cluster. This makes same node pod to pod traffic visible for VPC network | `bool` | `false` | no | | enable\_kubernetes\_alpha | Whether to enable Kubernetes Alpha features for this cluster. Note that when this option is enabled, the cluster cannot be upgraded and will be automatically deleted after 30 days. | `bool` | `false` | no | diff --git a/modules/beta-private-cluster-update-variant/variables.tf b/modules/beta-private-cluster-update-variant/variables.tf index a911ba584b..812d4c6f60 100644 --- a/modules/beta-private-cluster-update-variant/variables.tf +++ b/modules/beta-private-cluster-update-variant/variables.tf @@ -588,6 +588,12 @@ variable "enable_confidential_nodes" { default = false } +variable "enable_gcfs" { + type = bool + description = "Enable image streaming on cluster level." + default = false +} + variable "enable_secret_manager_addon" { description = "Enable the Secret Manager add-on for this cluster" type = bool @@ -943,12 +949,6 @@ variable "sandbox_enabled" { default = false } -variable "enable_gcfs" { - type = bool - description = "(Beta) Enable image streaming on cluster level." - default = false -} - variable "enable_identity_service" { type = bool description = "(Optional) Enable the Identity Service component, which allows customers to use external identity providers with the K8S API." diff --git a/modules/beta-private-cluster/README.md b/modules/beta-private-cluster/README.md index 5e1f34cb2d..103bcd6a3d 100644 --- a/modules/beta-private-cluster/README.md +++ b/modules/beta-private-cluster/README.md @@ -181,7 +181,7 @@ Then perform the following commands on the root folder: | enable\_cost\_allocation | Enables Cost Allocation Feature and the cluster name and namespace of your GKE workloads appear in the labels field of the billing export to BigQuery | `bool` | `false` | no | | enable\_default\_node\_pools\_metadata | Whether to enable the default node pools metadata key-value pairs such as `cluster_name` and `node_pool` | `bool` | `true` | no | | enable\_fqdn\_network\_policy | Enable FQDN Network Policies on the cluster | `bool` | `null` | no | -| enable\_gcfs | (Beta) Enable image streaming on cluster level. | `bool` | `false` | no | +| enable\_gcfs | Enable image streaming on cluster level. | `bool` | `false` | no | | enable\_identity\_service | (Optional) Enable the Identity Service component, which allows customers to use external identity providers with the K8S API. | `bool` | `false` | no | | enable\_intranode\_visibility | Whether Intra-node visibility is enabled for this cluster. This makes same node pod to pod traffic visible for VPC network | `bool` | `false` | no | | enable\_kubernetes\_alpha | Whether to enable Kubernetes Alpha features for this cluster. Note that when this option is enabled, the cluster cannot be upgraded and will be automatically deleted after 30 days. | `bool` | `false` | no | diff --git a/modules/beta-private-cluster/variables.tf b/modules/beta-private-cluster/variables.tf index a911ba584b..812d4c6f60 100644 --- a/modules/beta-private-cluster/variables.tf +++ b/modules/beta-private-cluster/variables.tf @@ -588,6 +588,12 @@ variable "enable_confidential_nodes" { default = false } +variable "enable_gcfs" { + type = bool + description = "Enable image streaming on cluster level." + default = false +} + variable "enable_secret_manager_addon" { description = "Enable the Secret Manager add-on for this cluster" type = bool @@ -943,12 +949,6 @@ variable "sandbox_enabled" { default = false } -variable "enable_gcfs" { - type = bool - description = "(Beta) Enable image streaming on cluster level." - default = false -} - variable "enable_identity_service" { type = bool description = "(Optional) Enable the Identity Service component, which allows customers to use external identity providers with the K8S API." diff --git a/modules/beta-public-cluster-update-variant/README.md b/modules/beta-public-cluster-update-variant/README.md index 773109db54..96be1cef85 100644 --- a/modules/beta-public-cluster-update-variant/README.md +++ b/modules/beta-public-cluster-update-variant/README.md @@ -196,7 +196,7 @@ Then perform the following commands on the root folder: | enable\_cost\_allocation | Enables Cost Allocation Feature and the cluster name and namespace of your GKE workloads appear in the labels field of the billing export to BigQuery | `bool` | `false` | no | | enable\_default\_node\_pools\_metadata | Whether to enable the default node pools metadata key-value pairs such as `cluster_name` and `node_pool` | `bool` | `true` | no | | enable\_fqdn\_network\_policy | Enable FQDN Network Policies on the cluster | `bool` | `null` | no | -| enable\_gcfs | (Beta) Enable image streaming on cluster level. | `bool` | `false` | no | +| enable\_gcfs | Enable image streaming on cluster level. | `bool` | `false` | no | | enable\_identity\_service | (Optional) Enable the Identity Service component, which allows customers to use external identity providers with the K8S API. | `bool` | `false` | no | | enable\_intranode\_visibility | Whether Intra-node visibility is enabled for this cluster. This makes same node pod to pod traffic visible for VPC network | `bool` | `false` | no | | enable\_kubernetes\_alpha | Whether to enable Kubernetes Alpha features for this cluster. Note that when this option is enabled, the cluster cannot be upgraded and will be automatically deleted after 30 days. | `bool` | `false` | no | diff --git a/modules/beta-public-cluster-update-variant/variables.tf b/modules/beta-public-cluster-update-variant/variables.tf index f523ff1f83..041910f047 100644 --- a/modules/beta-public-cluster-update-variant/variables.tf +++ b/modules/beta-public-cluster-update-variant/variables.tf @@ -552,6 +552,12 @@ variable "enable_confidential_nodes" { default = false } +variable "enable_gcfs" { + type = bool + description = "Enable image streaming on cluster level." + default = false +} + variable "enable_secret_manager_addon" { description = "Enable the Secret Manager add-on for this cluster" type = bool @@ -907,12 +913,6 @@ variable "sandbox_enabled" { default = false } -variable "enable_gcfs" { - type = bool - description = "(Beta) Enable image streaming on cluster level." - default = false -} - variable "enable_identity_service" { type = bool description = "(Optional) Enable the Identity Service component, which allows customers to use external identity providers with the K8S API." diff --git a/modules/beta-public-cluster/README.md b/modules/beta-public-cluster/README.md index 3e1372ccc2..b38627a23b 100644 --- a/modules/beta-public-cluster/README.md +++ b/modules/beta-public-cluster/README.md @@ -174,7 +174,7 @@ Then perform the following commands on the root folder: | enable\_cost\_allocation | Enables Cost Allocation Feature and the cluster name and namespace of your GKE workloads appear in the labels field of the billing export to BigQuery | `bool` | `false` | no | | enable\_default\_node\_pools\_metadata | Whether to enable the default node pools metadata key-value pairs such as `cluster_name` and `node_pool` | `bool` | `true` | no | | enable\_fqdn\_network\_policy | Enable FQDN Network Policies on the cluster | `bool` | `null` | no | -| enable\_gcfs | (Beta) Enable image streaming on cluster level. | `bool` | `false` | no | +| enable\_gcfs | Enable image streaming on cluster level. | `bool` | `false` | no | | enable\_identity\_service | (Optional) Enable the Identity Service component, which allows customers to use external identity providers with the K8S API. | `bool` | `false` | no | | enable\_intranode\_visibility | Whether Intra-node visibility is enabled for this cluster. This makes same node pod to pod traffic visible for VPC network | `bool` | `false` | no | | enable\_kubernetes\_alpha | Whether to enable Kubernetes Alpha features for this cluster. Note that when this option is enabled, the cluster cannot be upgraded and will be automatically deleted after 30 days. | `bool` | `false` | no | diff --git a/modules/beta-public-cluster/variables.tf b/modules/beta-public-cluster/variables.tf index f523ff1f83..041910f047 100644 --- a/modules/beta-public-cluster/variables.tf +++ b/modules/beta-public-cluster/variables.tf @@ -552,6 +552,12 @@ variable "enable_confidential_nodes" { default = false } +variable "enable_gcfs" { + type = bool + description = "Enable image streaming on cluster level." + default = false +} + variable "enable_secret_manager_addon" { description = "Enable the Secret Manager add-on for this cluster" type = bool @@ -907,12 +913,6 @@ variable "sandbox_enabled" { default = false } -variable "enable_gcfs" { - type = bool - description = "(Beta) Enable image streaming on cluster level." - default = false -} - variable "enable_identity_service" { type = bool description = "(Optional) Enable the Identity Service component, which allows customers to use external identity providers with the K8S API." diff --git a/modules/private-cluster-update-variant/README.md b/modules/private-cluster-update-variant/README.md index b36fa64982..94ea65a81d 100644 --- a/modules/private-cluster-update-variant/README.md +++ b/modules/private-cluster-update-variant/README.md @@ -195,6 +195,7 @@ Then perform the following commands on the root folder: | enable\_confidential\_nodes | An optional flag to enable confidential node config. | `bool` | `false` | no | | enable\_cost\_allocation | Enables Cost Allocation Feature and the cluster name and namespace of your GKE workloads appear in the labels field of the billing export to BigQuery | `bool` | `false` | no | | enable\_default\_node\_pools\_metadata | Whether to enable the default node pools metadata key-value pairs such as `cluster_name` and `node_pool` | `bool` | `true` | no | +| enable\_gcfs | Enable image streaming on cluster level. | `bool` | `false` | no | | enable\_identity\_service | (Optional) Enable the Identity Service component, which allows customers to use external identity providers with the K8S API. | `bool` | `false` | no | | enable\_intranode\_visibility | Whether Intra-node visibility is enabled for this cluster. This makes same node pod to pod traffic visible for VPC network | `bool` | `false` | no | | enable\_kubernetes\_alpha | Whether to enable Kubernetes Alpha features for this cluster. Note that when this option is enabled, the cluster cannot be upgraded and will be automatically deleted after 30 days. | `bool` | `false` | no | diff --git a/modules/private-cluster-update-variant/cluster.tf b/modules/private-cluster-update-variant/cluster.tf index a21ca0945b..52d7070b7d 100644 --- a/modules/private-cluster-update-variant/cluster.tf +++ b/modules/private-cluster-update-variant/cluster.tf @@ -549,6 +549,9 @@ resource "google_container_cluster" "primary" { node_pool_defaults { node_config_defaults { + gcfs_config { + enabled = var.enable_gcfs + } insecure_kubelet_readonly_port_enabled = var.insecure_kubelet_readonly_port_enabled != null ? upper(tostring(var.insecure_kubelet_readonly_port_enabled)) : null } } diff --git a/modules/private-cluster-update-variant/variables.tf b/modules/private-cluster-update-variant/variables.tf index 60e24762df..4f9fd582ee 100644 --- a/modules/private-cluster-update-variant/variables.tf +++ b/modules/private-cluster-update-variant/variables.tf @@ -582,6 +582,12 @@ variable "enable_confidential_nodes" { default = false } +variable "enable_gcfs" { + type = bool + description = "Enable image streaming on cluster level." + default = false +} + variable "enable_secret_manager_addon" { description = "Enable the Secret Manager add-on for this cluster" type = bool diff --git a/modules/private-cluster/README.md b/modules/private-cluster/README.md index c36a626648..67d51ef6d3 100644 --- a/modules/private-cluster/README.md +++ b/modules/private-cluster/README.md @@ -173,6 +173,7 @@ Then perform the following commands on the root folder: | enable\_confidential\_nodes | An optional flag to enable confidential node config. | `bool` | `false` | no | | enable\_cost\_allocation | Enables Cost Allocation Feature and the cluster name and namespace of your GKE workloads appear in the labels field of the billing export to BigQuery | `bool` | `false` | no | | enable\_default\_node\_pools\_metadata | Whether to enable the default node pools metadata key-value pairs such as `cluster_name` and `node_pool` | `bool` | `true` | no | +| enable\_gcfs | Enable image streaming on cluster level. | `bool` | `false` | no | | enable\_identity\_service | (Optional) Enable the Identity Service component, which allows customers to use external identity providers with the K8S API. | `bool` | `false` | no | | enable\_intranode\_visibility | Whether Intra-node visibility is enabled for this cluster. This makes same node pod to pod traffic visible for VPC network | `bool` | `false` | no | | enable\_kubernetes\_alpha | Whether to enable Kubernetes Alpha features for this cluster. Note that when this option is enabled, the cluster cannot be upgraded and will be automatically deleted after 30 days. | `bool` | `false` | no | diff --git a/modules/private-cluster/cluster.tf b/modules/private-cluster/cluster.tf index 928026d5e8..a361cb9dc6 100644 --- a/modules/private-cluster/cluster.tf +++ b/modules/private-cluster/cluster.tf @@ -549,6 +549,9 @@ resource "google_container_cluster" "primary" { node_pool_defaults { node_config_defaults { + gcfs_config { + enabled = var.enable_gcfs + } insecure_kubelet_readonly_port_enabled = var.insecure_kubelet_readonly_port_enabled != null ? upper(tostring(var.insecure_kubelet_readonly_port_enabled)) : null } } diff --git a/modules/private-cluster/variables.tf b/modules/private-cluster/variables.tf index 60e24762df..4f9fd582ee 100644 --- a/modules/private-cluster/variables.tf +++ b/modules/private-cluster/variables.tf @@ -582,6 +582,12 @@ variable "enable_confidential_nodes" { default = false } +variable "enable_gcfs" { + type = bool + description = "Enable image streaming on cluster level." + default = false +} + variable "enable_secret_manager_addon" { description = "Enable the Secret Manager add-on for this cluster" type = bool diff --git a/variables.tf b/variables.tf index 18806cf005..f4c7477c0d 100644 --- a/variables.tf +++ b/variables.tf @@ -546,6 +546,12 @@ variable "enable_confidential_nodes" { default = false } +variable "enable_gcfs" { + type = bool + description = "Enable image streaming on cluster level." + default = false +} + variable "enable_secret_manager_addon" { description = "Enable the Secret Manager add-on for this cluster" type = bool