Skip to content

Conversation

@chris3ware
Copy link
Contributor

@chris3ware chris3ware commented Aug 12, 2025

Description

The security group tags merge function precedence has been changed in the vpc-endpoints module.

Motivation and Context

This ensures that a Name tag passed to the security_group_tags variable is preferred over var.tags, var.security_group_name or var.security_group_name_prefix

Currently, if var.security_group_name_prefix is used the Name tag has a trailing hyphen. e.g. ex-app-vpce-sg-euw1-

The hyphen can be dropped, but then the actual name does not have a hyphen between the prefix and the random suffix.

Breaking Changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs
Copy link
Member

it is correct as its currently written

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants