Fix Invalid value 'true' for enable-dns64. Cannot set enable-dns64 to… #1194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… true unless the subnet has an IPv6 CIDR block associated with it
|
This PR has been automatically marked as stale because it has been open 30 days |
|
This PR was automatically closed because of stale in 10 days |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… true unless the subnet has an IPv6 CIDR block associated with it
Description
enable_ipv6 is a global var, when it is set to true the second check on enable_resource_name_dns_aaaa_record_on_launch (default true) is performed. However it does not take into account that prefixes must be set and so it fails in the scenario where let's say public subnets have ipv6 and prefixes but private subnets don't
Motivation and Context
If fixes the error above
Breaking Changes
It is not breaking
How Has This Been Tested?
I ran it in our private environment, so cannot really provide a sample