feat: Update main.tf to avoid recreating the existing S3 bucket when enabling object_lock #345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the `object_lock_enabled` attribute from the `aws_s3_bucket` resource, as it will force the creation of a new bucket and cannot be applied to an existing bucket. To enable object lock, using the `aws_s3_bucket_object_lock_configuration` resource alone is sufficient.
bds-congnguyen
changed the title
bds-congnguyen
changed the title
bds-congnguyen
changed the title
bds-congnguyen
changed the title
Author
|
@bryantbiggs can you help me take a look on this PR? |
Member
|
I don't understand the PR - we'll need a reproduction also, if this were an issue I would expect to see more users reporting it as such |
|
Please see related upstream issue / discussion |
Member
|
thank you @baolsen - closing since this appears to be a provider issue |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the
object_lock_enabledattribute from theaws_s3_bucketresource, as it will force the creation of a new bucket and cannot be applied to an existing bucket. To enable object lock, using theaws_s3_bucket_object_lock_configurationresource alone is sufficient.There is no change in other configuration, no change should be made in example/* folder
Motivation and Context
Breaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request