Skip to content

Addition of aws_prometheus_workspace_configuration & aws_prometheus_resource_policy support #23

@Sudokamikaze

Description

@Sudokamikaze

Is your request related to a new offering from AWS?

Is this functionality available in the 5.100.0 & 6.16

Is your request related to a problem? Please describe.

I'd like to include support of aws_prometheus_workspace_configuration and aws_prometheus_resource_policy for example usecases:

aws_prometheus_workspace_configuration:

  • Gives an ability to set metrics retention on workspace
  • Limits per labels set

aws_prometheus_resource_policy:

  • Adds ability to attach policy for cross-account access

Describe the solution you'd like.

  • Adds variable to set retention as retention_period_in_days, not required, no default value (to inherit AWS default, share your opinion)
  • Adds variable to allow user to pass limits_per_label_set in a map, then creates multiple blocks by for_each + dynamic
  • Allows to attach a policy with a switch attach_policy bool, and a variable policy to attach custom user defined policy

Describe alternatives you've considered.

Not applicable

Additional context

I'm willing to open a PR for these changes, their size isn't big and not problematic to implement, I'm opening this FR first to hear maintainers opinion about these features

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions