Add SearchAttributes.Copy exception to workflowcheck (#1958)

* SearchAttributes.Copy exception

* Add test, mark Copy with workflowcheck:ignore directly

Author: yuandrew

contrib/tools/workflowcheck/workflow/testdata/src/a/workflow.go

@@ -5,6 +5,7 @@ import (
 	"text/template"
 	"time"
 
+	"go.temporal.io/sdk/temporal"
 	"go.temporal.io/sdk/workflow"
 )
 
@@ -66,3 +67,8 @@ func WorkflowWithUnnamedArgument(workflow.Context) error { // want "a.WorkflowWi
 func NotWorkflow(ctx context.Context) {
 	time.Now()
 }
+
+func WorkflowWithSearchAttributes(workflow.Context) {
+	sa := temporal.SearchAttributes{}
+	_ = sa.Copy()
+}

contrib/tools/workflowcheck/workflow/testdata/src/go.temporal.io/sdk/temporal/search_attributes.go

@@ -0,0 +1,48 @@
+package temporal
+
+// This file somewhat mirrors the internal SearchAttributes implementation. The purpose of this is to
+// test SearchAttributes.Copy()'s map iteration being ignored with `//workflowcheck:ignore`
+
+type (
+	SearchAttributeKey interface{}
+
+	// SearchAttributes represents a collection of typed search attributes
+	SearchAttributes struct {
+		untypedValue map[SearchAttributeKey]interface{}
+	}
+
+	// SearchAttributeUpdate represents a change to SearchAttributes
+	SearchAttributeUpdate func(*SearchAttributes)
+)
+
+// GetUntypedValues gets a copy of the collection with raw types.
+func (sa SearchAttributes) GetUntypedValues() map[SearchAttributeKey]interface{} {
+	untypedValueCopy := make(map[SearchAttributeKey]interface{}, len(sa.untypedValue))
+	for key, value := range sa.untypedValue {
+		// Filter out nil values
+		if value == nil {
+			continue
+		}
+		switch v := value.(type) {
+		case []string:
+			untypedValueCopy[key] = append([]string(nil), v...)
+		default:
+			untypedValueCopy[key] = v
+		}
+	}
+	return untypedValueCopy
+}
+
+// Copy creates an update that copies existing values.
+//
+//workflowcheck:ignore
+func (sa SearchAttributes) Copy() SearchAttributeUpdate {
+	return func(s *SearchAttributes) {
+		// GetUntypedValues returns a copy of the map without nil values
+		// so the copy won't delete any existing values
+		untypedValues := sa.GetUntypedValues()
+		for key, value := range untypedValues {
+			s.untypedValue[key] = value
+		}
+	}
+}

internal/internal_search_attributes.go

@@ -361,6 +361,8 @@ func (sa SearchAttributes) GetUntypedValues() map[SearchAttributeKey]interface{}
 }
 
 // Copy creates an update that copies existing values.
+//
+//workflowcheck:ignore
 func (sa SearchAttributes) Copy() SearchAttributeUpdate {
 	return func(s *SearchAttributes) {
 		// GetUntypedValues returns a copy of the map without nil values