Enable SDKFlagBlockedSelectorSignalReceive by default (#1762)

* enable flag by default

* Fix tests

* Fix integration test I missed

* Add comment to unblockSelectorSignal

Author: yuandrew

internal/internal_coroutines_test.go

@@ -541,6 +541,9 @@ func TestSelectBlockingDefault(t *testing.T) {
 	}
 	// Verify that the flag is not set
 	require.False(t, env.GetFlag(SDKFlagBlockedSelectorSignalReceive))
+	unblockSelectorSignal = false
+	defer func() { unblockSelectorSignal = true }()
+
 	interceptor, ctx, err := newWorkflowContext(env, nil)
 	require.NoError(t, err, "newWorkflowContext failed")
 	d, _ := newDispatcher(ctx, interceptor, func(ctx Context) {
@@ -608,7 +611,9 @@ func TestSelectBlockingDefaultWithFlag(t *testing.T) {
 			TaskQueueName: "taskqueue:" + t.Name(),
 		},
 	}
+	require.True(t, unblockSelectorSignal)
 	require.True(t, env.TryUse(SDKFlagBlockedSelectorSignalReceive))
+
 	interceptor, ctx, err := newWorkflowContext(env, nil)
 	require.NoError(t, err, "newWorkflowContext failed")
 	d, _ := newDispatcher(ctx, interceptor, func(ctx Context) {

internal/internal_flags.go

@@ -31,7 +31,9 @@ const (
 	SDKFlagUnknown                      = math.MaxUint32
 )
 
-var unblockSelectorSignal bool
+// unblockSelectorSignal exists to allow us to configure the default behavior of
+// SDKFlagBlockedSelectorSignalReceive. This is primarily useful with tests.
+var unblockSelectorSignal = true
 
 func sdkFlagFromUint(value uint32) sdkFlag {
 	switch value {

internal/internal_workflow_testsuite_test.go

@@ -4217,7 +4217,7 @@ func (s *WorkflowTestSuiteUnitTest) Test_SameWorkflowAndActivityNames() {
 	s.Require().NoError(env.GetWorkflowError())
 }
 
-func (s *WorkflowTestSuiteUnitTest) Test_SignalLoss() {
+func (s *WorkflowTestSuiteUnitTest) Test_SignalNotLost() {
 	workflowFn := func(ctx Context) error {
 		ch1 := GetSignalChannel(ctx, "test-signal")
 		ch2 := GetSignalChannel(ctx, "test-signal-2")
@@ -4230,8 +4230,11 @@ func (s *WorkflowTestSuiteUnitTest) Test_SignalLoss() {
 			ch2.Receive(ctx, &v)
 		})
 		selector.Select(ctx)
-		s.Require().True(ch1.Len() == 0 && v == "s2")
+		s.Require().Equal(ch1.Len(), 1)
+		s.Require().Equal(v, "s2")
 		selector.Select(ctx)
+		s.Require().Equal(ch1.Len(), 0)
+		s.Require().Equal(v, "s1")
 
 		return nil
 	}
@@ -4245,8 +4248,5 @@ func (s *WorkflowTestSuiteUnitTest) Test_SignalLoss() {
 	env.ExecuteWorkflow(workflowFn)
 	s.True(env.IsWorkflowCompleted())
 	err := env.GetWorkflowError()
-	s.Error(err)
-	var workflowErr *WorkflowExecutionError
-	s.True(errors.As(err, &workflowErr))
-	s.Equal("deadline exceeded (type: ScheduleToClose)", workflowErr.cause.Error())
+	s.NoError(err)
 }

test/integration_test.go

@@ -7336,6 +7336,10 @@ func (ts *IntegrationTestSuite) TestSelectorBlock() {
 	ctx, cancel := context.WithTimeout(context.Background(), 30*time.Second)
 	defer cancel()
 	options := ts.startWorkflowOptions("test-selector-block")
+
+	internal.SetUnblockSelectorSignal(false)
+	defer internal.SetUnblockSelectorSignal(true)
+
 	run, err := ts.client.ExecuteWorkflow(ctx, options, ts.workflows.SelectorBlockSignal)
 	ts.NoError(err)
 	var result string
@@ -7348,9 +7352,6 @@ func (ts *IntegrationTestSuite) TestSelectorNoBlock() {
 	defer cancel()
 	options := ts.startWorkflowOptions("test-selector-block")
 
-	internal.SetUnblockSelectorSignal(true)
-	defer internal.SetUnblockSelectorSignal(false)
-
 	run, err := ts.client.ExecuteWorkflow(ctx, options, ts.workflows.SelectorBlockSignal)
 	ts.NoError(err)
 	var result string