Skip to content

Commit 46596d6

Browse files
author
Hannah Dunsmore
committed
fixed Enum naming
1 parent 5c49abd commit 46596d6

File tree

5 files changed

+22
-22
lines changed

5 files changed

+22
-22
lines changed

src/Components/MissionManifest/MissionManifest.spec.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import React from "react";
22
import { render, screen } from "@testing-library/react";
3-
import MissionManifest, { rovers } from "./MissionManifest";
3+
import MissionManifest, { Rovers } from "./MissionManifest";
44

55
const mockManifestResponse = {
66
photo_manifest: {
@@ -21,12 +21,12 @@ beforeEach(() => {
2121
});
2222

2323
test("renders loading message on initial render", () => {
24-
render(<MissionManifest roverType={rovers.SPIRIT} />);
24+
render(<MissionManifest roverType={Rovers.SPIRIT} />);
2525
expect(screen.getByText("Loading...")).toBeInTheDocument();
2626
});
2727

2828
test("opportunity rover renders correct p elements", async () => {
29-
render(<MissionManifest roverType={rovers.OPPORTUNIY} />);
29+
render(<MissionManifest roverType={Rovers.OPPORTUNIY} />);
3030
const expectedTexts = [
3131
"Rover Name: ",
3232
mockManifestResponse.photo_manifest.name,
@@ -57,7 +57,7 @@ test("opportunity rover renders correct p elements", async () => {
5757
});
5858

5959
test("opportunity rover renders correct Heading", async () => {
60-
render(<MissionManifest roverType={rovers.OPPORTUNIY} />);
60+
render(<MissionManifest roverType={Rovers.OPPORTUNIY} />);
6161

6262
const heading = await screen.findByText("MISSION MANIFEST");
6363

@@ -80,7 +80,7 @@ test("invalid rover renders correct p elements", async () => {
8080
json: jest.fn().mockResolvedValue(mockInvalidFetchResponse),
8181
});
8282

83-
render(<MissionManifest roverType={rovers.OPPORTUNIY} />);
83+
render(<MissionManifest roverType={Rovers.OPPORTUNIY} />);
8484

8585
const missionManifestContainer = await screen.findByTestId(
8686
"mission-manifest-container",

src/Components/MissionManifest/MissionManifest.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,14 @@ import { useState } from "react";
33
import { useEffect } from "react";
44
import "./MissionManifest.scss";
55

6-
export enum rovers {
6+
export enum Rovers {
77
CURIOSITY = "curiosity",
88
OPPORTUNIY = "opportunity",
99
SPIRIT = "spirit",
1010
}
1111

1212
export interface MissionManifestProps {
13-
roverType: rovers;
13+
roverType: Rovers;
1414
}
1515

1616
type manifestData = {

src/Components/RoverDetails/RoverDetails.tsx

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,30 +7,30 @@ import opportunityButton from "../../Assets/Images/Opportunity_button.png";
77
import "./RoverDetails.scss";
88
import RoverImages from "../RoverImages/RoverImages";
99

10-
export enum rovers {
10+
export enum Rovers {
1111
CURIOSITY = "curiosity",
1212
OPPORTUNIY = "opportunity",
1313
SPIRIT = "spirit",
1414
}
1515

1616
export interface MissionManifestProps {
17-
roverType: rovers;
17+
roverType: Rovers;
1818
}
1919

2020
function RoverDetails() {
21-
const [rover, setRover] = useState<rovers>(rovers.SPIRIT);
22-
const [selectedRover, setSelectedRover] = useState<rovers>(rovers.SPIRIT);
21+
const [rover, setRover] = useState<Rovers>(Rovers.SPIRIT);
22+
const [selectedRover, setSelectedRover] = useState<Rovers>(Rovers.SPIRIT);
2323

2424
const handleClick = (id: string) => {
2525
if (id === "spirit-button") {
26-
setRover(rovers.SPIRIT);
27-
setSelectedRover(rovers.SPIRIT);
26+
setRover(Rovers.SPIRIT);
27+
setSelectedRover(Rovers.SPIRIT);
2828
} else if (id === "curiosity-button") {
29-
setRover(rovers.CURIOSITY);
30-
setSelectedRover(rovers.CURIOSITY);
29+
setRover(Rovers.CURIOSITY);
30+
setSelectedRover(Rovers.CURIOSITY);
3131
} else if (id === "opportunity-button") {
32-
setRover(rovers.OPPORTUNIY);
33-
setSelectedRover(rovers.OPPORTUNIY);
32+
setRover(Rovers.OPPORTUNIY);
33+
setSelectedRover(Rovers.OPPORTUNIY);
3434
}
3535
};
3636

src/Components/RoverImages/RoverImage.spec.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import React from "react";
22
import { fireEvent, render, waitFor } from "@testing-library/react";
33
import RoverImages from "./RoverImages";
4-
import { rovers } from "../RoverDetails/RoverDetails";
4+
import { Rovers } from "../RoverDetails/RoverDetails";
55

66
const photo_mock_data = {
77
photos: [
@@ -38,7 +38,7 @@ describe("Testing the rover image displayed on page load", () => {
3838
});
3939
});
4040
test("Testing the rover image displayed on page load", async () => {
41-
render(<RoverImages roverType={rovers.CURIOSITY} />);
41+
render(<RoverImages roverType={Rovers.CURIOSITY} />);
4242

4343
await waitFor(() => {
4444
const testImage = document.querySelector("img") as HTMLImageElement;
@@ -50,7 +50,7 @@ describe("Testing the rover image displayed on page load", () => {
5050
});
5151

5252
test("Testing the rover image is displayed when next is clicked", async () => {
53-
render(<RoverImages roverType={rovers.CURIOSITY} />);
53+
render(<RoverImages roverType={Rovers.CURIOSITY} />);
5454
await waitFor(() => {
5555
const firstTestImage = document.querySelector("img") as HTMLImageElement;
5656
const firstTestImageDiv = firstTestImage.parentElement?.parentElement;

src/Components/RoverImages/RoverImages.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import "slick-carousel/slick/slick.css";
44
import "slick-carousel/slick/slick-theme.css";
55
import "./RoverImages.scss";
66
import { ClipLoader } from "react-spinners";
7-
import { MissionManifestProps, rovers } from "../RoverDetails/RoverDetails";
7+
import { MissionManifestProps, Rovers } from "../RoverDetails/RoverDetails";
88

99
type RoverResponse = {
1010
id: number;
@@ -86,7 +86,7 @@ function RoverImages(props: MissionManifestProps) {
8686
/>
8787
</div>
8888
);
89-
} else if (props.roverType === rovers.CURIOSITY) {
89+
} else if (props.roverType === Rovers.CURIOSITY) {
9090
return (
9191
<div className="sliderContainer">
9292
<Slider {...sliderSettings}>

0 commit comments

Comments
 (0)