Backport go-gitea#13349

zeripath · zeripath · commit caa53b25278c · 2020-10-29T09:06:59.000Z
Unfortunately my final push to go-gitea#13344 didn't register - or I failed to push it properly. GetIssueCommentReactions in routers/api/v1/repo/issue_reaction.go also makes the same mistake.
diff --git a/routers/api/v1/repo/issue_reaction.go b/routers/api/v1/repo/issue_reaction.go
@@ -56,7 +56,11 @@ func GetIssueCommentReactions(ctx *context.APIContext) {
 		return
 	}
 
-	if !ctx.Repo.CanRead(models.UnitTypeIssues) {
+	if err := comment.LoadIssue(); err != nil {
+		ctx.Error(http.StatusInternalServerError, "comment.LoadIssue", err)
+	}
+
+	if !ctx.Repo.CanReadIssuesOrPulls(comment.Issue.IsPull) {
 		ctx.Error(http.StatusForbidden, "GetIssueCommentReactions", errors.New("no permission to get reactions"))
 		return
 	}

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,11 @@ func GetIssueCommentReactions(ctx *context.APIContext) {`
`56`	`56`	`return`
`57`	`57`	`}`
`58`	`58`
`59`		`- if !ctx.Repo.CanRead(models.UnitTypeIssues) {`
	`59`	`+ if err := comment.LoadIssue(); err != nil {`
	`60`	`+ ctx.Error(http.StatusInternalServerError, "comment.LoadIssue", err)`
	`61`	`+ }`
	`62`	`+`
	`63`	`+ if !ctx.Repo.CanReadIssuesOrPulls(comment.Issue.IsPull) {`
`60`	`64`	`ctx.Error(http.StatusForbidden, "GetIssueCommentReactions", errors.New("no permission to get reactions"))`
`61`	`65`	`return`
`62`	`66`	`}`