Skip to content

Commit 6edce29

Browse files
committed
CI: Make Sphinx test matrix slot more solid
By installing the designated Sphinx version _after_ the package, we are absolute sure the right version will be tested.
1 parent 299074f commit 6edce29

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

.github/workflows/main.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ jobs:
3030

3131
env:
3232
PYTHON: ${{ matrix.python-version }}
33+
SPHINX: ${{ matrix.sphinx-version }}
3334

3435
name: >
3536
Sphinx ${{ matrix.sphinx-version }}
@@ -54,12 +55,12 @@ jobs:
5455
# https://github.com/pypa/setuptools/blob/main/CHANGES.rst#v6400
5556
pip install "setuptools>=64" --upgrade
5657
57-
# Install Sphinx beforehand, to implement test matrix.
58-
pip install sphinx==${{ matrix.sphinx-version }}
59-
6058
# Install package in editable mode.
6159
pip install --use-pep517 --prefer-binary --editable=.[develop,docs,test]
6260
61+
# Install specific Sphinx version, according to test matrix slot.
62+
pip install sphinx==${{ matrix.sphinx-version }}
63+
6364
- name: Run linter and software tests
6465
run: |
6566
poe check
@@ -71,6 +72,6 @@ jobs:
7172
with:
7273
files: ./coverage.xml
7374
flags: unittests
74-
env_vars: OS,PYTHON
75+
env_vars: PYTHON,SPHINX
7576
name: codecov-umbrella
7677
fail_ci_if_error: true

0 commit comments

Comments
 (0)