Skip to content

Commit 56d844d

Browse files
committed
Merge rust-bitcoin#5126: Update mutant exclude for lifetime syntax change
80f95b2 Update mutant exclude for lifetime syntax change (Jamil Lambert, PhD) 6133e10 Reword mutant exclude comment (Jamil Lambert, PhD) Pull request description: Two mutant excludes stopped working and caused a timeout in the weekly mutation testing. The lifetimes are now elided to fix a clippy error. And an existing comment needs to be updated in response to a review comment on previous PR. - Fix the comment for a mutant exclude as a follow up to rust-bitcoin#5094. - Change the excludes to match the new syntax and kill the mutants. Together with rust-bitcoin#5119 Closes rust-bitcoin#5121 ACKs for top commit: tcharding: ACK 80f95b2 apoelstra: ACK 80f95b2; successfully ran local tests Tree-SHA512: 547f17a9ab1244467458ce57e2914bd74520401d18c5697812c22921bb078af225e9eaf74f1d3c21efeecfba314d4b9d99fb09994bc573abc8fc36094606144d
2 parents 99544ff + 80f95b2 commit 56d844d

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

.cargo/mutants.toml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ exclude_re = [
1212
"serde_details::<impl de::Visitor<'_>", # Skip serde mutation tests
1313
"Iterator", # Mutating operations in an iterator can result in an infinite loop
1414
"<impl encoding::Decodable for .*>::decoder", # Mutant replacing Default::default() is equivalent to returning new()
15-
"<impl encoding::Decoder for .*>::read_limit", # Function is just a cast for optimization.
15+
"<impl encoding::Decoder for .*>::read_limit", # Function is for optimization and does not need to be tested.
1616

1717

1818
# ----------------------------------Crate-specific exclusions----------------------------------
@@ -46,6 +46,6 @@ exclude_re = [
4646
"Script<T>::to_hex", # Deprecated
4747
"ScriptBuf::to_hex", # Deprecated
4848
"ScriptBuf<T>::to_hex", # Deprecated
49-
"<impl Encoder for WitnessEncoder<'a>>::current_chunk", # Replacing the return with Some(vec![]) causes an infinite loop.
50-
"<impl Encoder for WitnessEncoder<'a>>::advance", # Replacing the return with true causes an infinite loop.
49+
"<impl Encoder for WitnessEncoder<'_>>::current_chunk", # Replacing the return with Some(vec![]) causes an infinite loop.
50+
"<impl Encoder for WitnessEncoder<'_>>::advance", # Replacing the return with true causes an infinite loop.
5151
]

0 commit comments

Comments
 (0)