Disable false positives in linting

Author: tcalmant

jsonrpclib/SimpleJSONRPCServer.py

@@ -45,32 +45,32 @@
     SimpleXMLRPCDispatcher = xmlrpcserver.SimpleXMLRPCDispatcher
     SimpleXMLRPCRequestHandler = xmlrpcserver.SimpleXMLRPCRequestHandler
     CGIXMLRPCRequestHandler = xmlrpcserver.CGIXMLRPCRequestHandler
-    resolve_dotted_attribute = xmlrpcserver.resolve_dotted_attribute
+    resolve_dotted_attribute = xmlrpcserver.resolve_dotted_attribute  # type: ignore  # noqa: E501  # pylint: disable=invalid-name,line-too-long
     import socketserver
 except (ImportError, AttributeError):
     # Python 2 or IronPython
     # pylint: disable=F0401,E0611
-    import SimpleXMLRPCServer as xmlrpcserver
-    SimpleXMLRPCDispatcher = xmlrpcserver.SimpleXMLRPCDispatcher
-    SimpleXMLRPCRequestHandler = xmlrpcserver.SimpleXMLRPCRequestHandler
-    CGIXMLRPCRequestHandler = xmlrpcserver.CGIXMLRPCRequestHandler
-    resolve_dotted_attribute = xmlrpcserver.resolve_dotted_attribute
-    import SocketServer as socketserver
+    import SimpleXMLRPCServer as xmlrpcserver  # type: ignore
+    SimpleXMLRPCDispatcher = xmlrpcserver.SimpleXMLRPCDispatcher  # type: ignore  # noqa: E501  # pylint: disable=invalid-name,line-too-long
+    SimpleXMLRPCRequestHandler = xmlrpcserver.SimpleXMLRPCRequestHandler  # type: ignore  # noqa: E501  # pylint: disable=invalid-name,line-too-long
+    CGIXMLRPCRequestHandler = xmlrpcserver.CGIXMLRPCRequestHandler  # type: ignore  # noqa: E501  # pylint: disable=invalid-name,line-too-long
+    resolve_dotted_attribute = xmlrpcserver.resolve_dotted_attribute  # type: ignore  # noqa: E501  # pylint: disable=invalid-name,line-too-long
+    import SocketServer as socketserver  # type: ignore
 
 try:
     # Windows
     import fcntl
 except ImportError:
     # Other systems
     # pylint: disable=C0103
-    fcntl = None
+    fcntl = None  # type: ignore
 
 try:
     # Python with support for Unix socket
     _AF_UNIX = socket.AF_UNIX
 except AttributeError:
     # Unix sockets are not supported, use a dummy value
-    _AF_UNIX = -1
+    _AF_UNIX = -1  # type: ignore
 
 # Local modules
 from jsonrpclib import Fault

jsonrpclib/jsonrpc.py

@@ -77,20 +77,20 @@
 except ImportError:
     # Python 2
     # pylint: disable=F0401,E0611
-    from httplib import HTTPConnection
-    from urlparse import urlparse
-    from xmlrpclib import Transport as XMLTransport
-    from xmlrpclib import SafeTransport as XMLSafeTransport
-    from xmlrpclib import ServerProxy as XMLServerProxy
-    from xmlrpclib import _Method as XML_Method
+    from httplib import HTTPConnection  # type: ignore
+    from urlparse import urlparse  # type: ignore
+    from xmlrpclib import Transport as XMLTransport  # type: ignore
+    from xmlrpclib import SafeTransport as XMLSafeTransport  # type: ignore
+    from xmlrpclib import ServerProxy as XMLServerProxy  # type: ignore
+    from xmlrpclib import _Method as XML_Method  # type: ignore
 
 try:
     # Check GZip support
     import gzip
 except ImportError:
     # Python can be built without zlib/gzip support
     # pylint: disable=C0103
-    gzip = None
+    gzip = None  # type: ignore
 
 # Library includes
 import jsonrpclib.config
@@ -115,11 +115,11 @@
 try:
     # pylint: disable=F0401,E0611
     # Using cjson
-    import cjson
+    import cjson  # type: ignore
     _logger.debug("Using cjson as JSON library")
 
     # Declare cjson methods
-    def jdumps(obj, encoding='utf-8'):
+    def jdumps(obj, encoding='utf-8'):  # pylint: disable=unused-argument
         """
         Serializes ``obj`` to a JSON formatted string, using cjson.
         """
@@ -139,7 +139,7 @@ def jloads(json_string):
         _logger.debug("Using json as JSON library")
     except ImportError:
         try:
-            import simplejson as json
+            import simplejson as json  # type: ignore
             _logger.debug("Using simplejson as JSON library")
         except ImportError:
             _logger.error("No supported JSON library found")
@@ -156,7 +156,7 @@ def jdumps(obj, encoding='utf-8'):
             return json.dumps(obj, encoding=encoding)
     else:
         # Python 3
-        def jdumps(obj, encoding='utf-8'):
+        def jdumps(obj, encoding='utf-8'):  # pylint: disable=unused-argument
             """
             Serializes ``obj`` to a JSON formatted string.
             """
@@ -182,7 +182,6 @@ class ProtocolError(Exception):
     * an error message (string)
     * a (code, message) tuple
     """
-    pass
 
 
 class AppError(ProtocolError):
@@ -199,11 +198,21 @@ def data(self):
 
         :return: The data associated to the error, or None
         """
-        return self.args[0][2]
+        # Don't know why the pylint error shows up
+        return self.args[0][2]  # pylint: disable=unsubscriptable-object
 
 
-class TransportError( ProtocolError ):
+class TransportError(ProtocolError):
+    """
+    Transport error: a specialized protocol error
+    """
     def __init__(self, url, errcode, errmsg, msg):
+        """
+        :param url: Target URL
+        :param errcode: HTTP error code
+        :param errmsg: HTTP error code description
+        :param msg: Exception message
+        """
         ProtocolError.__init__(self, url, errcode, errmsg, msg)
 
         self.url = url
@@ -212,9 +221,8 @@ def __init__(self, url, errcode, errmsg, msg):
         self.msg = msg
 
     def __repr__(self):
-        return (
-             "<%s for %s: %s %s>" %
-            (self.__class__.__name__, self.url, self.errcode, self.errmsg)
+        return "<{} for {}: {} {}>".format(
+            type(self).__name__, self.url, self.errcode, self.errmsg
         )
 
 
@@ -273,7 +281,7 @@ def close(self):
             try:
                 # Convert the whole final string
                 data = utils.from_bytes(data)
-            except:
+            except (TypeError, ValueError):
                 # Try a pass-through
                 pass
 

jsonrpclib/threadpool.py

@@ -31,12 +31,10 @@
 
 try:
     # Python 3
-    # pylint: disable=F0401
-    import queue
+    import queue  # pylint: disable=F0401
 except ImportError:
     # Python 2
-    # pylint: disable=F0401
-    import Queue as queue
+    import Queue as queue  # type: ignore # pylint: disable=F0401
 
 # ------------------------------------------------------------------------------
 

jsonrpclib/utils.py

@@ -62,7 +62,7 @@ def to_bytes(string):
         Converts the given string into bytes
         """
         # pylint: disable=E0602
-        if type(string) is unicode:
+        if type(string) is unicode:  # noqa: F821
             return str(string)
         return string
 
@@ -118,11 +118,11 @@ def is_enum(obj):
         return isinstance(obj, enum.Enum)
 except ImportError:
     # Pre-Python 3.4
-    def is_enum(_):
+    def is_enum(obj):  # pylint: disable=unused-argument
         """
         Before Python 3.4, enumerations didn't exist.
 
-        :param _: Object to test
+        :param obj: Object to test
         :return: Always False
         """
         return False

setup.cfg

@@ -1,2 +1,5 @@
 [bdist_wheel]
 universal = 1
+
+[flake8]
+max-line-length = 80