Add safety note to library/std/src/sys/unix/fd.rs

notriddle · elichai · notriddle · commit 28ec5d28d9dd · 2020-12-10T13:31:52.000-07:00
Co-authored-by: Elichai Turkel &lt;elichai.turkel@gmail.com&gt;
diff --git a/std/src/sys/unix/fd.rs b/std/src/sys/unix/fd.rs
@@ -69,6 +69,7 @@ const fn max_iov() -> usize {
 impl FileDesc {
     pub fn new(fd: c_int) -> FileDesc {
         assert_ne!(fd, -1);
+        // SAFETY: we just asserted that the value is in the valid range and isn't `-1` (the only value bigger than `0xFF_FF_FF_FE` unsigned)
         unsafe { FileDesc { fd } }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -69,6 +69,7 @@ const fn max_iov() -> usize {`
`69`	`69`	`impl FileDesc {`
`70`	`70`	`pub fn new(fd: c_int) -> FileDesc {`
`71`	`71`	`assert_ne!(fd, -1);`
	`72`	+ // SAFETY: we just asserted that the value is in the valid range and isn't `-1` (the only value bigger than `0xFF_FF_FF_FE` unsigned)
`72`	`73`	`unsafe { FileDesc { fd } }`
`73`	`74`	`}`
`74`	`75`