Skip to content

Commit 90a12a6

Browse files
authored
Restore list_artifacts to its correct behavior (#811)
This fixes a regression from 384afee where `list_artifacts` went from listing the latest artifacts from a task to getting the task definition and returning a non existent field from it, leading to: ``` File "/builds/worker/checkouts/src/taskcluster/src/target_tasks.py", line 27, in _filter_for_pr for artifact in list_artifacts(diff_task): ^^^^^^^^^^^^^^^^^^^^^^^^^ File "/src/taskcluster-taskgraph/src/taskgraph/util/taskcluster.py", line 166, in list_artifacts return task["artifacts"] ~~~~^^^^^^^^^^^^^ KeyError: 'artifacts' ```
1 parent 0fcf369 commit 90a12a6

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

src/taskgraph/util/taskcluster.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -175,9 +175,8 @@ def get_artifact(task_id, path):
175175

176176
def list_artifacts(task_id):
177177
queue = get_taskcluster_client("queue")
178-
task = queue.task(task_id)
179-
if task:
180-
return task["artifacts"]
178+
response = queue.listLatestArtifacts(task_id)
179+
return response["artifacts"]
181180

182181

183182
def get_artifact_prefix(task):

test/test_util_taskcluster.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ def test_list_artifact(responses, root_url):
139139
tc.get_taskcluster_client.cache_clear()
140140

141141
responses.get(
142-
f"{root_url}/api/queue/v1/task/{tid}",
142+
f"{root_url}/api/queue/v1/task/{tid}/artifacts",
143143
json={"artifacts": ["file1.txt", "file2.json"]},
144144
)
145145

0 commit comments

Comments
 (0)