Add lint step

Author: tarunbatra

.github/workflows/main.yml

@@ -39,6 +39,9 @@ jobs:
       - name: Install password_validator
         run: pip install .
 
+      - name: Run lint
+        run: pylint src
+
       - name: Run tests
         run: coverage run -m unittest discover -s tests -v
 

.pylintrc

@@ -13,7 +13,7 @@ ignore=third_party
 
 # Add files or directories matching the regex patterns to the blacklist. The
 # regex matches against base names, not paths.
-ignore-patterns=object_detection_grpc_client.py,prediction_pb2.py,prediction_pb2_grpc.py
+ignore-patterns=object_detection_grpc_client.py,prediction_pb2.py,prediction_pb2_grpc.py,test.*.py
 
 # Pickle collected data for later comparisons.
 persistent=no

requirements-dev.txt

@@ -1 +1,10 @@
+astroid==2.4.1
 coverage==5.1
+isort==4.3.21
+lazy-object-proxy==1.4.3
+mccabe==0.6.1
+pylint==2.5.2
+six==1.14.0
+toml==0.10.1
+typed-ast==1.4.1
+wrapt==1.12.1

src/password_validator/password_validator.py

@@ -15,7 +15,7 @@ def validate(self, pwd):
         password = str(pwd)
         return all(self.__isPasswordValidFor(prop, password) for prop in self.properties)
 
-    def __registerProperty(self, func, args=[]):
+    def __registerProperty(self, func, args=[]): # pylint: disable=dangerous-default-value
         self.properties.append({
             'method': func,
             'positive': self.positive,
@@ -26,7 +26,7 @@ def __isPasswordValidFor(self, prop, password):
         return prop['method'](password, prop['positive'], *prop['arguments'])
 
     def __validateNum(self, num):
-        assert (type(num) == 'int' or num > 0), error['length']
+        assert (type(num) == 'int' or num > 0), error['length'] # pylint: disable=unidiomatic-typecheck
 
     def has(self, regexp=None):
         self.positive = True