From 8e7faa9efba8e644b30492f2b86b8e3b223f9bf1 Mon Sep 17 00:00:00 2001 From: Rafe Uddaraj Date: Sun, 12 Nov 2023 01:19:35 +0600 Subject: [PATCH 1/4] Do not allow empty wish --- src/AddToBucket.jsx | 57 ++++++++++++++++++++++++--------------------- 1 file changed, 31 insertions(+), 26 deletions(-) diff --git a/src/AddToBucket.jsx b/src/AddToBucket.jsx index d2d1e3e..88d0802 100644 --- a/src/AddToBucket.jsx +++ b/src/AddToBucket.jsx @@ -1,30 +1,35 @@ import { createSignal } from "solid-js"; export function AddToBucket(props) { - const [newItem, setNewItem] = createSignal(''); + const [newItem, setNewItem] = createSignal(""); - return ( -
- { - setNewItem(e.target.value); - }} - /> - -
- ); -} \ No newline at end of file + return ( +
+ { + setNewItem(e.target.value); + }} + /> + +
+ ); +} From ed5f49bfbb085a607b9861cd798ea7483497aa59 Mon Sep 17 00:00:00 2001 From: Rafe Uddaraj <78890044+rafeuddaraj@users.noreply.github.com> Date: Sun, 12 Nov 2023 01:38:12 +0600 Subject: [PATCH 2/4] Delete src/AddToBucket.jsx --- src/AddToBucket.jsx | 35 ----------------------------------- 1 file changed, 35 deletions(-) delete mode 100644 src/AddToBucket.jsx diff --git a/src/AddToBucket.jsx b/src/AddToBucket.jsx deleted file mode 100644 index 88d0802..0000000 --- a/src/AddToBucket.jsx +++ /dev/null @@ -1,35 +0,0 @@ -import { createSignal } from "solid-js"; - -export function AddToBucket(props) { - const [newItem, setNewItem] = createSignal(""); - - return ( -
- { - setNewItem(e.target.value); - }} - /> - -
- ); -} From ef4fde36a23a7c295e8a5d076827a6abf76bb6e2 Mon Sep 17 00:00:00 2001 From: Rafe Uddaraj Date: Sun, 12 Nov 2023 01:39:27 +0600 Subject: [PATCH 3/4] Do not allow empty wish --- src/AddToBucket.jsx | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/AddToBucket.jsx b/src/AddToBucket.jsx index 88d0802..72dea56 100644 --- a/src/AddToBucket.jsx +++ b/src/AddToBucket.jsx @@ -17,7 +17,7 @@ export function AddToBucket(props) { type="submit" onClick={(e) => { e.preventDefault(); - if (e.target.value) { + if (newItem()!=='') { props.setItems((items) => { return [ ...items, @@ -25,8 +25,9 @@ export function AddToBucket(props) { ].reverse(); }); setNewItem(""); + } else { + alert(`You can't submit empty value`); } - alert(`You can't submit empty value`) }}> Add From fe72c107a210d8928d918220efed945dddf2a6ad Mon Sep 17 00:00:00 2001 From: Rafe Uddaraj Date: Sun, 12 Nov 2023 01:47:39 +0600 Subject: [PATCH 4/4] Add functionality to delete a wish #2 --- src/BucketListItem.jsx | 64 +++++++++++++++++++++++++----------------- 1 file changed, 39 insertions(+), 25 deletions(-) diff --git a/src/BucketListItem.jsx b/src/BucketListItem.jsx index aa76c22..c833438 100644 --- a/src/BucketListItem.jsx +++ b/src/BucketListItem.jsx @@ -1,28 +1,42 @@ export function BucketListItem(props) { - return ( -
  • - -
  • - ); + }); + }; + + return ( +
  • + + +
  • + ); }