♻️ review requested

Author: GautierDele

config/orion.php

@@ -34,20 +34,19 @@
     ],
     'search' => [
         'case_sensitive' => true, // TODO: set to "false" by default in 3.0 release
+            /*
+            |--------------------------------------------------------------------------
+            | Max Nested Depth
+            |--------------------------------------------------------------------------
+            |
+            | This value is the maximum depth of nested filters
+            | you will most likely need this to be maximum at 1 but
+            | you can increase this number if necessary. Please
+            | be aware that the depth generate dynamic rules and can slow
+            | your application if someone sends a request with thousands of nested
+            | filters.
+            |
+            */
+        'max_nested_depth' => 1
     ],
-
-    /*
-    |--------------------------------------------------------------------------
-    | Max Nested Depth
-    |--------------------------------------------------------------------------
-    |
-    | This value is the maximum depth of nested filters
-    | you will most likely need this to be maximum at 1 but
-    | you can increase this number if necessary. Please
-    | be aware that the depth generate dynamic rules and can slow
-    | your application if someone sends a request with thousands of nested
-    | filters.
-    |
-    */
-    'max_nested_depth' => 1
 ];

src/Drivers/Standard/ParamsValidator.php

@@ -49,7 +49,7 @@ public function validateFilters(Request $request): void
     {
         $max_depth = ceil(($this->getArrayDepth($request->all()['filters'])) / 2) - 1;
 
-        abort_if($max_depth > config('orion.max_nested_depth'), 422, __('Max nested depth :depth is exceeded', ['depth' => config('orion.max_nested_depth')]));
+        abort_if($max_depth > config('orion.search.max_nested_depth'), 422, __('Max nested depth :depth is exceeded', ['depth' => config('orion.search.max_nested_depth')]));
 
         Validator::make(
             $request->all(),

tests/Feature/StandardIndexNestedFilteringOperationsTest.php

@@ -111,6 +111,6 @@ public function getting_a_list_of_resources_nested_filtered_by_not_whitelisted_f
         );
 
         $response->assertStatus(422);
-        $response->assertJsonStructure(['message', 'errors' => ['field']]);
+        $response->assertJsonStructure(['message', 'errors' => ['filters.0.nested.0.field']]);
     }
 }

tests/Fixtures/app/Providers/OrionServiceProvider.php

@@ -45,6 +45,8 @@ public function boot()
     {
         app()->make(Kernel::class)->pushMiddleware(EnforceExpectsJson::class);
 
+        $this->mergeConfigFrom(__DIR__ . '/../../../../config/orion.php', 'orion');
+
         $this->loadRoutesFrom(__DIR__.'/../../routes/api.php');
     }
 }