Fix double freed in remove_self_from_waiters()

vicLin8712 · vicLin8712 · commit fc2339cd9265 · 2025-12-01T10:23:26.000+08:00
free() is already invoked in list_remove(). Freeing the same pointer twice can crash the program with an invalid free error or corrupt the heap. Ensure a single memory-release path by removing the outer free() call. close #57
diff --git a/kernel/mutex.c b/kernel/mutex.c
@@ -56,7 +56,6 @@ static bool remove_self_from_waiters(list_t *waiters)
     while (curr && curr != waiters->tail) {
         if (curr->data == self) {
             list_remove(waiters, curr);
-            free(curr);
             return true;
         }
         curr = curr->next;

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,6 @@ static bool remove_self_from_waiters(list_t *waiters)`
`56`	`56`	`while (curr && curr != waiters->tail) {`
`57`	`57`	`if (curr->data == self) {`
`58`	`58`	`list_remove(waiters, curr);`
`59`		`- free(curr);`
`60`	`59`	`return true;`
`61`	`60`	`}`
`62`	`61`	`curr = curr->next;`