[VarExporter] Fix exporting classes with __serialize() but not __unserialize()

Author: fancyweb

Internal/Exporter.php

@@ -73,20 +73,29 @@ public static function prepare($values, $objectsPool, &$refsPool, &$objectsCount
 
             $class = \get_class($value);
             $reflector = Registry::$reflectors[$class] ?? Registry::getClassReflector($class);
+            $properties = [];
 
             if ($reflector->hasMethod('__serialize')) {
                 if (!$reflector->getMethod('__serialize')->isPublic()) {
                     throw new \Error(sprintf('Call to %s method "%s::__serialize()".', $reflector->getMethod('__serialize')->isProtected() ? 'protected' : 'private', $class));
                 }
 
-                if (!\is_array($properties = $value->__serialize())) {
+                if (!\is_array($serializeProperties = $value->__serialize())) {
                     throw new \TypeError($class.'::__serialize() must return an array');
                 }
 
+                if ($reflector->hasMethod('__unserialize')) {
+                    $properties = $serializeProperties;
+                } else {
+                    foreach ($serializeProperties as $n => $v) {
+                        $c = \PHP_VERSION_ID >= 80100 && $reflector->hasProperty($n) && ($p = $reflector->getProperty($n))->isReadOnly() ? $p->class : 'stdClass';
+                        $properties[$c][$n] = $v;
+                    }
+                }
+
                 goto prepare_value;
             }
 
-            $properties = [];
             $sleep = null;
             $proto = Registry::$prototypes[$class];
 

Tests/Fixtures/__serialize-but-no-__unserialize.php

@@ -0,0 +1,17 @@
+<?php
+
+return \Symfony\Component\VarExporter\Internal\Hydrator::hydrate(
+    $o = [
+        clone (\Symfony\Component\VarExporter\Internal\Registry::$prototypes['Symfony\\Component\\VarExporter\\Tests\\__SerializeButNo__Unserialize'] ?? \Symfony\Component\VarExporter\Internal\Registry::p('Symfony\\Component\\VarExporter\\Tests\\__SerializeButNo__Unserialize')),
+    ],
+    null,
+    [
+        'stdClass' => [
+            'foo' => [
+                'ccc',
+            ],
+        ],
+    ],
+    $o[0],
+    []
+);

Tests/VarExporterTest.php

@@ -247,6 +247,8 @@ public static function provideExport()
 
         yield ['__unserialize-but-no-__serialize', new __UnserializeButNo__Serialize()];
 
+        yield ['__serialize-but-no-__unserialize', new __SerializeButNo__Unserialize()];
+
         if (\PHP_VERSION_ID < 80100) {
             return;
         }
@@ -470,3 +472,20 @@ public function __unserialize(array $data): void
         $this->foo = $data['foo'];
     }
 }
+
+class __SerializeButNo__Unserialize
+{
+    public $foo;
+
+    public function __construct()
+    {
+        $this->foo = 'ccc';
+    }
+
+    public function __serialize(): array
+    {
+        return [
+            'foo' => $this->foo,
+        ];
+    }
+}