Remove some implicit bool type juggling

Girgias · nicolas-grekas · commit f7f8c652703e · 2025-08-05T12:19:40.000+02:00
diff --git a/ExecutableFinder.php b/ExecutableFinder.php
@@ -63,13 +63,13 @@ public function find(string $name, ?string $default = null, array $extraDirs = [
         }
 
         $dirs = array_merge(
-            explode(\PATH_SEPARATOR, getenv('PATH') ?: getenv('Path')),
+            explode(\PATH_SEPARATOR, getenv('PATH') ?: getenv('Path') ?: ''),
             $extraDirs
         );
 
         $suffixes = $this->suffixes;
         if ('\\' === \DIRECTORY_SEPARATOR) {
-            $pathExt = getenv('PATHEXT');
+            $pathExt = getenv('PATHEXT') ?: '';
             $suffixes = array_merge($suffixes, $pathExt ? explode(\PATH_SEPARATOR, $pathExt) : ['.exe', '.bat', '.cmd', '.com']);
         }
         $suffixes = '' !== pathinfo($name, \PATHINFO_EXTENSION) ? array_merge([''], $suffixes) : array_merge($suffixes, ['']);

Original file line number	Diff line number	Diff line change
`@@ -63,13 +63,13 @@ public function find(string $name, ?string $default = null, array $extraDirs = [`
`63`	`63`	`}`
`64`	`64`
`65`	`65`	`$dirs = array_merge(`
`66`		`- explode(\PATH_SEPARATOR, getenv('PATH') ?: getenv('Path')),`
	`66`	`+ explode(\PATH_SEPARATOR, getenv('PATH') ?: getenv('Path') ?: ''),`
`67`	`67`	`$extraDirs`
`68`	`68`	`);`
`69`	`69`
`70`	`70`	`$suffixes = $this->suffixes;`
`71`	`71`	`if ('\\' === \DIRECTORY_SEPARATOR) {`
`72`		`- $pathExt = getenv('PATHEXT');`
	`72`	`+ $pathExt = getenv('PATHEXT') ?: '';`
`73`	`73`	`$suffixes = array_merge($suffixes, $pathExt ? explode(\PATH_SEPARATOR, $pathExt) : ['.exe', '.bat', '.cmd', '.com']);`
`74`	`74`	`}`
`75`	`75`	`$suffixes = '' !== pathinfo($name, \PATHINFO_EXTENSION) ? array_merge([''], $suffixes) : array_merge($suffixes, ['']);`