[console] Negatable option are null by default

Author: jderusse

Application.php

@@ -1036,7 +1036,7 @@ protected function getDefaultInputDefinition()
             new InputOption('--quiet', '-q', InputOption::VALUE_NONE, 'Do not output any message'),
             new InputOption('--verbose', '-v|vv|vvv', InputOption::VALUE_NONE, 'Increase the verbosity of messages: 1 for normal output, 2 for more verbose output and 3 for debug'),
             new InputOption('--version', '-V', InputOption::VALUE_NONE, 'Display this application version'),
-            new InputOption('--ansi', '', InputOption::VALUE_NEGATABLE, 'Force (or disable --no-ansi) ANSI output', null),
+            new InputOption('--ansi', '', InputOption::VALUE_NEGATABLE, 'Force (or disable --no-ansi) ANSI output', false),
             new InputOption('--no-interaction', '-n', InputOption::VALUE_NONE, 'Do not ask any interactive question'),
         ]);
     }

Input/InputOption.php

@@ -186,9 +186,6 @@ public function setDefault($default = null)
         if (self::VALUE_NONE === (self::VALUE_NONE & $this->mode) && null !== $default) {
             throw new LogicException('Cannot set a default value when using InputOption::VALUE_NONE mode.');
         }
-        if (self::VALUE_NEGATABLE === (self::VALUE_NEGATABLE & $this->mode) && null !== $default) {
-            throw new LogicException('Cannot set a default value when using InputOption::VALUE_NEGATABLE mode.');
-        }
 
         if ($this->isArray()) {
             if (null === $default) {
@@ -198,7 +195,7 @@ public function setDefault($default = null)
             }
         }
 
-        $this->default = $this->acceptValue() ? $default : false;
+        $this->default = $this->acceptValue() || $this->isNegatable() ? $default : false;
     }
 
     /**

Tests/Input/ArgvInputTest.php

@@ -214,6 +214,24 @@ public function provideNegatableOptions()
                 ['foo' => false],
                 '->parse() parses long options without a value',
             ],
+            [
+                ['cli.php'],
+                [new InputOption('foo', null, InputOption::VALUE_NEGATABLE)],
+                ['foo' => null],
+                '->parse() parses long options without a value',
+            ],
+            [
+                ['cli.php'],
+                [new InputOption('foo', null, InputOption::VALUE_NONE | InputOption::VALUE_NEGATABLE)],
+                ['foo' => null],
+                '->parse() parses long options without a value',
+            ],
+            [
+                ['cli.php'],
+                [new InputOption('foo', null, InputOption::VALUE_NEGATABLE, '', false)],
+                ['foo' => false],
+                '->parse() parses long options without a value',
+            ],
         ];
     }
 

Tests/Input/InputOptionTest.php

@@ -164,14 +164,6 @@ public function testDefaultValueWithValueNoneMode()
         $option->setDefault('default');
     }
 
-    public function testDefaultValueWithValueBooleanMode()
-    {
-        $this->expectException(\LogicException::class);
-        $this->expectExceptionMessage('Cannot set a default value when using InputOption::VALUE_NEGATABLE mode.');
-        $option = new InputOption('foo', 'f', InputOption::VALUE_NEGATABLE);
-        $option->setDefault('default');
-    }
-
     public function testDefaultValueWithIsArrayMode()
     {
         $this->expectException(\LogicException::class);