#14 introduced validation for operationId uniqueness across whole spec file

Author: giuliopulina

src/main/java/com/github/sylvainlaurent/maven/swaggervalidator/semantic/node/ObjectPropertyRequiredStore.java

@@ -8,7 +8,7 @@
 
 public class ObjectPropertyRequiredStore {
 
-    private static final Map<Object, List<String>> requiredObjectPropertiesMap = synchronizedMap(new IdentityHashMap<Object, List<String>>());
+    private static final Map<Object, List<String>> requiredObjectPropertiesMap = synchronizedMap(new IdentityHashMap<>());
 
     public static List<String> get(Object objectProperty) {
         return requiredObjectPropertiesMap.get(objectProperty);

src/main/java/com/github/sylvainlaurent/maven/swaggervalidator/semantic/validator/path/OperationValidator.java

@@ -10,10 +10,11 @@
 import com.github.sylvainlaurent.maven.swaggervalidator.semantic.node.path.PathWrapper;
 import com.github.sylvainlaurent.maven.swaggervalidator.semantic.validator.error.DefinitionSemanticError;
 import com.github.sylvainlaurent.maven.swaggervalidator.semantic.validator.error.SemanticError;
-import com.github.sylvainlaurent.maven.swaggervalidator.util.Util;
 
 import io.swagger.models.parameters.Parameter;
 
+import static com.github.sylvainlaurent.maven.swaggervalidator.util.Util.findDuplicates;
+
 public class OperationValidator extends PathValidatorTemplate {
 
     private List<SemanticError> errors = new ArrayList<>();
@@ -41,15 +42,16 @@ public void validate(OperationWrapper operation) {
     }
 
     @Override
-    public void validate(PathWrapper path) {
+    public void validate(List<PathWrapper> paths) {
         // save duplicates at this point to have pretty error messages added later
-        collectDuplicateOperationIds(path);
+        collectDuplicateOperationIds(paths);
     }
 
-    private void collectDuplicateOperationIds(PathWrapper path) {
-        List<String> operationIds = path.getOperations().values().stream().map(OperationWrapper::getOperationId)
+    private void collectDuplicateOperationIds(List<PathWrapper> paths) {
+        List<String> operationIds = paths.stream().flatMap(path -> path.getOperations().values().stream()
+                .map(OperationWrapper::getOperationId))
                 .collect(Collectors.toList());
-        duplicateOperationIds = Util.findDuplicates(operationIds);
+        duplicateOperationIds = findDuplicates(operationIds);
     }
 
     @Override

src/test/java/com/github/sylvainlaurent/maven/swaggervalidator/semantic/validator/path/OperationValidatorTest.java

@@ -40,6 +40,24 @@ public void semantic_error_when_path_parameter_not_defined_in_parameters_section
         assertEquals("paths./category/{id}/product/{productId}.get", error2.getPath());
     }
 
+    @Test
+    public void semantic_error_when_operation_id_is_duplicated_across_different_paths() {
+        SwaggerDeserializationResult swaggerResult = readDoc(
+                RESOURCE_FOLDER + "duplicate-operation-ids-different-paths.yml");
+        List<SemanticError> errors = new SemanticValidationService(swaggerResult.getSwagger()).validate();
+        logger.info(errors.toString());
+
+        assertFalse(errors.isEmpty());
+        assertEquals(2, errors.size());
+        DefinitionSemanticError error1 = (DefinitionSemanticError) errors.get(0);
+        assertEquals("Operations must have unique operationIds. Duplicate: operation", error1.getMessage());
+        assertEquals("paths./category/{id}/.get", error1.getPath());
+
+        DefinitionSemanticError error2 = (DefinitionSemanticError) errors.get(1);
+        assertEquals("Operations must have unique operationIds. Duplicate: operation", error1.getMessage());
+        assertEquals("paths./category/{id}/product/{productId}.get", error2.getPath());
+    }
+
     @Test
     public void semantic_error_when_more_than_one_body_parameter() {
         SwaggerDeserializationResult swaggerResult = readDoc(

src/test/resources/semantic-validation/duplicate-operation-ids-different-paths.yml

@@ -0,0 +1,44 @@
+swagger: '2.0'
+info:
+  title: Test API
+  description: Test API
+  version: "1.0.0"
+host: none
+schemes:
+  - https
+basePath: /v1
+produces:
+  - application/json
+paths:
+  /category/{id}/product/{productId}:
+    parameters:
+      - name: productId
+        in: path
+        required: true
+        type: string
+      - name: id
+        in: path
+        required: true
+        type: string
+    get:
+      operationId: operation
+      summary: test service
+      responses:
+        200:
+          description: ok
+          schema:
+            type: string
+  /category/{id}/:
+    parameters:
+    - name: id
+      in: path
+      required: true
+      type: string
+    get:
+      operationId: operation
+      summary: test service
+      responses:
+        200:
+          description: ok
+          schema:
+            type: string