From 93a231e38424eb58d76f01e3d4c1c2672418d6e4 Mon Sep 17 00:00:00 2001 From: Alex Hoppen Date: Sun, 30 Nov 2025 09:19:55 +0100 Subject: [PATCH] Pass --explicit-target-dependency-import-check error when building swift-syntax This should catch missing imports such as https://github.com/swiftlang/swift-syntax/pull/3195 --- .github/workflows/pull_request.yml | 2 ++ .../swift-syntax-dev-utils/common/SwiftPMBuilder.swift | 5 ++++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index fa5a292067c..7da1018d949 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -19,6 +19,8 @@ jobs: uses: swiftlang/github-workflows/.github/workflows/swift_package_test.yml@main with: enable_wasm_sdk_build: true + linux_build_command: "swift test --explicit-target-dependency-import-check error" + windows_build_command: "Invoke-Program swift test --explicit-target-dependency-import-check error" soundness: name: Soundness uses: swiftlang/github-workflows/.github/workflows/soundness.yml@main diff --git a/SwiftSyntaxDevUtils/Sources/swift-syntax-dev-utils/common/SwiftPMBuilder.swift b/SwiftSyntaxDevUtils/Sources/swift-syntax-dev-utils/common/SwiftPMBuilder.swift index 8324544a7f5..1fbb066b3ea 100644 --- a/SwiftSyntaxDevUtils/Sources/swift-syntax-dev-utils/common/SwiftPMBuilder.swift +++ b/SwiftSyntaxDevUtils/Sources/swift-syntax-dev-utils/common/SwiftPMBuilder.swift @@ -83,7 +83,10 @@ struct SwiftPMBuilder { if action == "test" { args += ["--disable-testable-imports"] } - args += ["--package-path", packageDir.path] + args += [ + "--package-path", packageDir.path, + "--explicit-target-dependency-import-check", "error", + ] if let buildDir = buildDir?.path { args += ["--scratch-path", buildDir]