Fix BufferReader.lineNumber to correctly count newlines #1628
+105
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `BufferReader.lineNumber` property had a bug where it used `fullBuffer[offset: 1]` to check for newline characters. Since `offset:` is relative to the start of the buffer, this always checked the same byte (the second byte) regardless of the current cursor position `p`. This caused incorrect line counting: - If the second byte happened to be `\n`, it would increment the count on every iteration, overcounting lines - If the second byte was not `\n`, standalone newlines (without preceding `\r`) would never be counted, undercounting lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
BufferReader.lineNumberproperty had a bug where it usedfullBuffer[offset: 1]to check for newline characters. Sinceoffset:is relative to the start of the buffer, this always checked the same byte (the second byte) regardless of the current cursor positionp.This caused incorrect line counting:
\n, it would increment the count on every iteration, overcounting lines\n, standalone newlines (without preceding\r) would never be counted, undercounting lines.