CFKnownLocations // Refactor Win32 part aligning to dotNET 10 behavior.

Author: ShikiSuen

Sources/CoreFoundation/CFKnownLocations.c

@@ -82,38 +82,68 @@ CFURLRef _Nullable _CFKnownLocationCreatePreferencesURLForUser(CFKnownLocationUs
 
     switch (user) {
         case _kCFKnownLocationUserAny: {
-            DWORD size = 0;
-            GetAllUsersProfileDirectoryW(NULL, &size);
-
-            wchar_t* path = (wchar_t*)malloc(size * sizeof(wchar_t));
-            GetAllUsersProfileDirectoryW(path, &size);
-
-            CFStringRef allUsersPath = CFStringCreateWithCharacters(kCFAllocatorSystemDefault, path, size - 1);
-            free(path);
-
-            location = CFURLCreateWithFileSystemPath(kCFAllocatorSystemDefault, allUsersPath, kCFURLWindowsPathStyle, true);
-            CFRelease(allUsersPath);
+            // Try SHGetKnownFolderPath first (preferred method)
+            wchar_t* path = NULL;
+            HRESULT hr = SHGetKnownFolderPath(&FOLDERID_ProgramData, 0, NULL, &path);
+            
+            if (SUCCEEDED(hr) && path != NULL) {
+                CFStringRef allUsersPath = CFStringCreateWithCharacters(kCFAllocatorSystemDefault, path, wcslen(path));
+                CoTaskMemFree(path);
+                
+                location = CFURLCreateWithFileSystemPath(kCFAllocatorSystemDefault, allUsersPath, kCFURLWindowsPathStyle, true);
+                CFRelease(allUsersPath);
+            } else {
+                // Fallback to environment variable
+                if (path != NULL) {
+                    CoTaskMemFree(path);
+                }
+                
+                const char* programData = __CFgetenv("ProgramData");
+                if (programData == NULL) {
+                    programData = __CFgetenv("ALLUSERSPROFILE");
+                }
+                
+                if (programData != NULL) {
+                    CFStringRef envPath = CFStringCreateWithCString(kCFAllocatorSystemDefault, programData, kCFStringEncodingUTF8);
+                    if (envPath != NULL) {
+                        location = CFURLCreateWithFileSystemPath(kCFAllocatorSystemDefault, envPath, kCFURLWindowsPathStyle, true);
+                        CFRelease(envPath);
+                    }
+                }
+            }
             break;
         }
         case _kCFKnownLocationUserCurrent:
-            username = CFGetUserName();
-            // The above API returns a non-NULL CFStringRef. The failed result is an empty string.
-            // We need to check for that case and fall through to the next case.
-            Boolean isEmpty = CFEqual(username, CFSTR(""));
-            CFRelease(username);
-            if (!isEmpty) {
-                break;
-            }
-            // fallthrough.
+            // Leaving this case unhandled (fallthrough) on WinNT.
+            // Reason (according to `./include/CFKnownLocations.h`):
+            // The username parameter is ignored for any user constant other than …ByName.
+            // …ByName with a NULL username is the same as …Current.
         case _kCFKnownLocationUserByName: {
+            // Try SHGetKnownFolderPath first (preferred method)
             wchar_t* path = NULL;
-            SHGetKnownFolderPath(&FOLDERID_LocalAppData, 0, NULL, &path);
+            HRESULT hr = SHGetKnownFolderPath(&FOLDERID_LocalAppData, 0, NULL, &path);
 
-            CFStringRef userPath = CFStringCreateWithCharacters(kCFAllocatorSystemDefault, path, wcslen(path));
-            CoTaskMemFree(path);
-
-            location = CFURLCreateWithFileSystemPath(kCFAllocatorSystemDefault, userPath, kCFURLWindowsPathStyle, true);
-            CFRelease(userPath);
+            if (SUCCEEDED(hr) && path != NULL) {
+                CFStringRef userPath = CFStringCreateWithCharacters(kCFAllocatorSystemDefault, path, wcslen(path));
+                CoTaskMemFree(path);
+                
+                location = CFURLCreateWithFileSystemPath(kCFAllocatorSystemDefault, userPath, kCFURLWindowsPathStyle, true);
+                CFRelease(userPath);
+            } else {
+                // Fallback to environment variable
+                if (path != NULL) {
+                    CoTaskMemFree(path);
+                }
+                
+                const char* localAppData = __CFgetenv("LOCALAPPDATA");
+                if (localAppData != NULL) {
+                    CFStringRef envPath = CFStringCreateWithCString(kCFAllocatorSystemDefault, localAppData, kCFStringEncodingUTF8);
+                    if (envPath != NULL) {
+                        location = CFURLCreateWithFileSystemPath(kCFAllocatorSystemDefault, envPath, kCFURLWindowsPathStyle, true);
+                        CFRelease(envPath);
+                    }
+                }
+            }
             break;
         }
     }