Implement retry mechanisms for network download functionality #199
+422
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justice-adams-apple
force-pushed
the
jadams/retry-curl
branch
from
f3f787b to
cd39271
Compare
justice-adams-apple
force-pushed
the
jadams/retry-curl
branch
from
cd39271 to
a27b4ea
Compare
justice-adams-apple
force-pushed
the
jadams/retry-curl
branch
from
c39ad06 to
72a2ab2
Compare
justice-adams-apple
changed the title
plemarquand
reviewed
Dec 4, 2025
| Write-Host "Downloading $Url ... " | ||
|
|
||
| try { | ||
| Invoke-WebRequestWithRetry -Uri $Url -OutFile installer.exe |
Contributor
There was a problem hiding this comment.
Could you also use this in .github/workflows/scripts/windows/install-vsb.ps1 to download the visual studio build tools
justice-adams-apple
changed the title
shahmishal
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target the most frequently failing network facing functions in our CI and implement retry mechanisms to prevent spurious failing GH actions across the swiftlang PR's
Before VS download fixes Show to work with 5 consistent PR passes, each with a retry being successfully executed which can be seen below:
Then ran 8 times in a row with latest commit, all passed. This should be ready to land