Skip to content

Commit 0db6cf0

Browse files
mologiesams96
authored andcommitted
Make tests parallel
Shaves 6 seconds of the test time on my box, and enables detection of a thread safety issue via "go test -race", to be fixed next.
1 parent 8633621 commit 0db6cf0

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

rgeo_test.go

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -263,6 +263,7 @@ func TestReverseGeocode_Countries(t *testing.T) {
263263
if testing.Short() {
264264
t.Skip("Skipping integration test (countries) for short mode")
265265
}
266+
t.Parallel()
266267

267268
for _, dataset := range []func() []byte{Countries110, Countries10} {
268269
r, err := New(dataset)
@@ -278,6 +279,8 @@ func TestReverseGeocode_Countries(t *testing.T) {
278279
test.expected.City = ""
279280

280281
t.Run(test.name, func(t *testing.T) {
282+
t.Parallel()
283+
281284
result, err := r.ReverseGeocode(test.in)
282285
if err != test.err {
283286
t.Errorf("expected error: %s\n got: %s\n", test.err, err)
@@ -294,6 +297,7 @@ func TestReverseGeocode_Provinces(t *testing.T) {
294297
if testing.Short() {
295298
t.Skip("Skipping integraion test (provinces) in short mode")
296299
}
300+
t.Parallel()
297301

298302
r, err := New(Provinces10)
299303
if err != nil {
@@ -306,6 +310,8 @@ func TestReverseGeocode_Provinces(t *testing.T) {
306310
test.expected.City = ""
307311

308312
t.Run(test.name, func(t *testing.T) {
313+
t.Parallel()
314+
309315
result, err := r.ReverseGeocode(test.in)
310316
if err != test.err {
311317
t.Errorf("expected error: %s\n got: %s\n", test.err, err)
@@ -321,6 +327,7 @@ func TestReverseGeocode_Cities(t *testing.T) {
321327
if testing.Short() {
322328
t.Skip("Skipping integration test (cities) in short mode.")
323329
}
330+
t.Parallel()
324331

325332
r, err := New(Provinces10, Cities10)
326333
if err != nil {
@@ -330,6 +337,8 @@ func TestReverseGeocode_Cities(t *testing.T) {
330337
for _, test := range testdata {
331338
test := test
332339
t.Run(test.name, func(t *testing.T) {
340+
t.Parallel()
341+
333342
result, err := r.ReverseGeocode(test.in)
334343
if err != test.err {
335344
t.Errorf("expected error: %s\n got: %s\n", test.err, err)

0 commit comments

Comments
 (0)