fix: update svelte-eslint-parser to 0.22 (#306)

* fix: update svelte-eslint-parser to 0.22

* Create rotten-moons-shop.md

Author: ota-meshi

.changeset/rotten-moons-shop.md

@@ -0,0 +1,5 @@
+---
+"eslint-plugin-svelte": patch
+---
+
+fix: update svelte-eslint-parser to 0.22

docs-svelte-kit/src/routes/+layout.js

@@ -2,6 +2,7 @@ import { markdownPath } from "$lib/utils.js"
 const docs = import.meta.glob("../../../docs/**/*.md")
 
 export const prerender = true
+export const trailingSlash = "always"
 
 /** @type {import('@sveltejs/kit').Load} */
 export async function load({ url }) {

package.json

@@ -73,7 +73,7 @@
     "postcss-load-config": "^3.1.4",
     "postcss-safe-parser": "^6.0.0",
     "sourcemap-codec": "^1.4.8",
-    "svelte-eslint-parser": "^0.21.0"
+    "svelte-eslint-parser": "^0.22.0"
   },
   "devDependencies": {
     "@1stg/browserslist-config": "^1.2.3",
@@ -174,7 +174,7 @@
     "access": "public"
   },
   "typeCoverage": {
-    "atLeast": 98.72,
+    "atLeast": 99.04,
     "cache": true,
     "detail": true,
     "ignoreAsAssertion": true,

src/rules/shorthand-directive.ts

@@ -32,7 +32,10 @@ export default createRule("shorthand-directive", {
 
     /** Report for always */
     function reportForAlways(
-      node: AST.SvelteDirective | AST.SvelteStyleDirective,
+      node:
+        | AST.SvelteBindingDirective
+        | AST.SvelteClassDirective
+        | AST.SvelteStyleDirective,
     ) {
       context.report({
         node,
@@ -51,7 +54,10 @@ export default createRule("shorthand-directive", {
 
     /** Report for never */
     function reportForNever(
-      node: AST.SvelteDirective | AST.SvelteStyleDirective,
+      node:
+        | AST.SvelteBindingDirective
+        | AST.SvelteClassDirective
+        | AST.SvelteStyleDirective,
     ) {
       context.report({
         node,

src/rules/sort-attributes.ts

@@ -229,7 +229,7 @@ export default createRule("sort-attributes", {
       const k = cacheKeyText.get(node)
       if (k != null) return k
 
-      const result = getAttributeKeyText(node)
+      const result = getAttributeKeyText(node, context)
       cacheKeyText.set(node, result)
       return result
     }

src/utils/ast-utils.ts

@@ -435,6 +435,7 @@ export function getAttributeKeyText(
     | SvAST.SvelteStyleDirective
     | SvAST.SvelteDirective
     | SvAST.SvelteSpecialDirective,
+  context: RuleContext,
 ): string {
   switch (node.type) {
     case "SvelteAttribute":
@@ -446,7 +447,7 @@ export function getAttributeKeyText(
       return node.kind
     case "SvelteDirective": {
       const dir = getDirectiveName(node)
-      return `${dir}:${node.key.name.name}${
+      return `${dir}:${getSimpleNameFromNode(node.key.name, context)}${
         node.key.modifiers.length ? `|${node.key.modifiers.join("|")}` : ""
       }`
     }
@@ -518,17 +519,7 @@ function getAttributeValueRangeTokens(
  * Returns name of SvelteElement
  */
 export function getNodeName(node: SvAST.SvelteElement): string {
-  if (node.name.type === "Identifier" || node.name.type === "SvelteName") {
-    return node.name.name
-  }
-  const memberPath = [node.name.property.name]
-  let currentObject = node.name.object
-  while (currentObject.type === "SvelteMemberExpressionName") {
-    memberPath.unshift(currentObject.property.name)
-    currentObject = currentObject.object
-  }
-  memberPath.unshift(currentObject.name)
-  return memberPath.join(".")
+  return getSimpleNameFromNode(node.name)
 }
 
 /**
@@ -586,3 +577,49 @@ export function isExpressionIdentifier(
 
   return true
 }
+
+function getSimpleNameFromNode(
+  node:
+    | SvAST.SvelteName
+    | SvAST.SvelteMemberExpressionName
+    | TSESTree.Identifier,
+  context?: RuleContext,
+): string
+function getSimpleNameFromNode(
+  node:
+    | SvAST.SvelteName
+    | SvAST.SvelteMemberExpressionName
+    | TSESTree.PrivateIdentifier
+    | TSESTree.Expression,
+  context: RuleContext,
+): string
+/** Get simple name from give node */
+function getSimpleNameFromNode(
+  node:
+    | SvAST.SvelteName
+    | SvAST.SvelteMemberExpressionName
+    | TSESTree.PrivateIdentifier
+    | TSESTree.Expression,
+  context: RuleContext | undefined,
+): string {
+  if (node.type === "Identifier" || node.type === "SvelteName") {
+    return node.name
+  }
+  if (
+    node.type === "SvelteMemberExpressionName" ||
+    (node.type === "MemberExpression" && !node.computed)
+  ) {
+    return `${getSimpleNameFromNode(
+      node.object,
+      context!,
+    )}.${getSimpleNameFromNode(node.property, context!)}`
+  }
+
+  // No nodes other than those listed above are currently expected to be used in names.
+
+  if (!context) {
+    throw new Error("Rule context is required")
+  }
+
+  return context.getSourceCode().getText(node)
+}

svelte.config.mjs

@@ -47,8 +47,6 @@ const config = {
       lib: path.join(dirname, "./docs-svelte-kit/src/lib"),
       assets: path.join(dirname, "./docs-svelte-kit/statics"),
     },
-
-    trailingSlash: "always",
   },
 }
 export default config