Removed the AbstractRequest::METHOD_POST constant for the Symfony HttpFoundation Request::METHOD_POST constant.

Author: kiettran

src/Message/AbstractRequest.php

@@ -5,17 +5,13 @@
 use DateTimeInterface;
 use Omnipay\Common\Message\AbstractRequest as OmnipayAbstractRequest;
 use Psr\Http\Message\ResponseInterface;
+use Symfony\Component\HttpFoundation\Request;
 
 /**
  * Class AbstractRequest.
  */
 abstract class AbstractRequest extends OmnipayAbstractRequest
 {
-    /**
-     * @var string
-     */
-    public const METHOD_POST = 'POST';
-
     /**
      * @var string
      */
@@ -47,7 +43,7 @@ protected function sendRequest(string $method, string $urlPath, array $data): Re
         $headers = $this->getAuthenticationHeaders($securityHash);
         $body = null;
 
-        if ($method === self::METHOD_POST) {
+        if ($method === Request::METHOD_POST) {
             $headers['Content-Type'] = 'application/json';
             $body = json_encode($data);
         }

src/Message/CreateTransactionRequest.php

@@ -3,6 +3,7 @@
 namespace Omnipay\IcepayPayments\Message;
 
 use Omnipay\Common\Message\ResponseInterface;
+use Symfony\Component\HttpFoundation\Request;
 
 /**
  * The request for creating a transaction at Icepay.
@@ -59,7 +60,7 @@ public function getData(): array
     public function sendData($data): ResponseInterface
     {
         $this->sendRequest(
-            self::METHOD_POST,
+            Request::METHOD_POST,
             '/contract/transaction',
             $data
         );

src/Message/RefundRequest.php

@@ -4,6 +4,7 @@
 
 use Omnipay\Common\Exception\InvalidRequestException;
 use Omnipay\Common\Message\ResponseInterface;
+use Symfony\Component\HttpFoundation\Request;
 
 /**
  * The request for refunding at Icepay.
@@ -38,7 +39,7 @@ public function sendData($data): ResponseInterface
         }
 
         $this->sendRequest(
-            self::METHOD_POST,
+            Request::METHOD_POST,
             sprintf(
                 '/transaction/%s/refund',
                 $this->getTransactionReference()

src/Message/TransactionStatusRequest.php

@@ -3,6 +3,7 @@
 namespace Omnipay\IcepayPayments\Message;
 
 use Omnipay\Common\Message\ResponseInterface;
+use Symfony\Component\HttpFoundation\Request;
 
 /**
  * The request for getting the transaction status at Icepay.
@@ -31,7 +32,7 @@ public function getData(): array
     public function sendData($data): ResponseInterface
     {
         $this->sendRequest(
-            self::METHOD_POST,
+            Request::METHOD_POST,
             sprintf(
                 '/transaction/%s',
                 $this->getTransactionReference()

tests/Message/CreateTransactionRequestTest.php

@@ -5,6 +5,7 @@
 use DateTime;
 use GuzzleHttp\Psr7\Request;
 use Omnipay\IcepayPayments\AbstractTestCase;
+use Symfony\Component\HttpFoundation\Request as SymfonyRequest;
 
 /**
  * Class CreateTransactionRequestTest.
@@ -126,7 +127,7 @@ public function testSendData(): void
         $this->assertInstanceOf(CreateTransactionResponse::class, $response);
 
         $expectedRequest = new Request(
-            AbstractRequest::METHOD_POST,
+            SymfonyRequest::METHOD_POST,
             'https://www.superbrave.nl/contract/transaction'
         );
 

tests/Message/RefundRequestTest.php

@@ -4,8 +4,8 @@
 
 use GuzzleHttp\Psr7\Request;
 use Omnipay\Common\Exception\InvalidRequestException;
-use Omnipay\Common\Http\Client;
 use Omnipay\IcepayPayments\AbstractTestCase;
+use Symfony\Component\HttpFoundation\Request as SymfonyRequest;
 
 class RefundRequestTest extends AbstractTestCase
 {
@@ -63,7 +63,7 @@ public function testRefundSendDataWithValidRequest(): void
         $this->assertInstanceOf(RefundResponse::class, $response);
 
         $expectedRequest = new Request(
-            AbstractRequest::METHOD_POST,
+            SymfonyRequest::METHOD_POST,
             'https://www.superbrave.nl/transaction/1M-MR-M33533K5-L00K-47-M3/refund'
         );
 

tests/Message/TransactionStatusRequestTest.php

@@ -5,6 +5,7 @@
 use DateTime;
 use GuzzleHttp\Psr7\Request;
 use Omnipay\IcepayPayments\AbstractTestCase;
+use Symfony\Component\HttpFoundation\Request as SymfonyRequest;
 
 /**
  * Class TransactionStatusRequestTest.
@@ -66,7 +67,7 @@ public function testSendData(): void
         $this->assertInstanceOf(TransactionStatusResponse::class, $response);
 
         $expectedRequest = new Request(
-            AbstractRequest::METHOD_POST,
+            SymfonyRequest::METHOD_POST,
             'https://www.superbrave.nl/transaction/e7ca29c8-f1f4-4a4c-a968-0f9667d0519d'
         );