Skip to content

Commit dd42ca1

Browse files
authored
fix: searchbar broken style (#1972)
<!-- Hello πŸ‘‹ Thank you for submitting a pull request. To help us merge your PR, make sure to follow the instructions below: - Create or update the tests - Create or update the documentation at https://github.com/strapi/documentation - Refer to the issue you are closing in the PR description: Fix #issue - Specify if the PR is ready to be merged or work in progress (by opening a draft PR) Please ensure you read the Contributing Guide: https://github.com/strapi/strapi/blob/master/CONTRIBUTING.md --> ### What does it do? Style of the Searchbar was broken because of the height: 16px that was not taken into account because of the previous line semicolon. Because I've added the missing semicolon, the height: 16px is now used by the css and it is broken. We already have a size='S' in the input, there is no need to override the height. ### Why is it needed? Buggy 2.0 stable ### How to test it? Open the Searchbar input ### Related issue(s)/PR(s) Let us know if this is related to any issue/pull request
2 parents a4f1a8f + 31f3c7e commit dd42ca1

File tree

3 files changed

+5
-7
lines changed

3 files changed

+5
-7
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@strapi/design-system': patch
3+
---
4+
5+
fix: searchbar broken style

β€Ždocs/stories/04-components/Searchbar.mdxβ€Ž

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,12 +36,6 @@ The default SearchBar.
3636

3737
<Canvas of={SearchbarStories.Base} />
3838

39-
### SearchBar size S
40-
41-
The default SearchBar.
42-
43-
<Canvas of={SearchbarStories.SizeS} />
44-
4539
### Disabled SearchBar
4640

4741
Depending on the status of an action or the permissions, a SearchBar can be disabled.

β€Žpackages/design-system/src/components/Searchbar/Searchbar.tsxβ€Ž

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ const SearchbarWrapper = styled.div`
3636

3737
const SearchbarInput = styled(Field.Input)`
3838
border: 1px solid ${({ theme }) => theme.colors.neutral150};
39-
height: 16px;
4039
padding: 0 0 0 8px;
4140
color: ${({ theme }) => theme.colors.neutral800};
4241

0 commit comments

Comments
Β (0)