Exception with UBL and unsupported version and profile

An exception will be thrown when writing to UBL with unsupported version and profile other than XRechnung.
closes #492

Author: stephanstapel

ZUGFeRD.Test/GlobalTests.cs

@@ -21,6 +21,7 @@
 using System;
 using System.Collections.Generic;
 using System.Text;
+using static System.Runtime.InteropServices.JavaScript.JSType;
 
 namespace s2industries.ZUGFeRD.Test
 {
@@ -107,6 +108,31 @@ public void TestGetVersion()
         } // !TestGetVersion()
 
 
+        [TestMethod]
+        [DataRow(ZUGFeRDVersion.Version1, Profile.Extended)]
+        [DataRow(ZUGFeRDVersion.Version1, Profile.XRechnung)]
+        [DataRow(ZUGFeRDVersion.Version20, Profile.Extended)]
+        [DataRow(ZUGFeRDVersion.Version20, Profile.XRechnung)]
+        [DataRow(ZUGFeRDVersion.Version20, Profile.XRechnung1)]
+        [DataRow(ZUGFeRDVersion.Version23, Profile.Extended)]        
+        [DataRow(ZUGFeRDVersion.Version23, Profile.XRechnung1)]        
+        public void UBLNonAvailability(ZUGFeRDVersion version, Profile profile)
+        {
+            InvoiceDescriptor desc = this.InvoiceProvider.CreateInvoice();
+            MemoryStream ms = new MemoryStream();
+            Assert.ThrowsException<UnsupportedException>(() => desc.Save(ms, version, profile, ZUGFeRDFormats.UBL));
+        } // !UBLNonAvailability()
+
+
+        [TestMethod]        
+        public void UBLAvailability()
+        {
+            InvoiceDescriptor desc = this.InvoiceProvider.CreateInvoice();
+            MemoryStream ms = new MemoryStream();
+            desc.Save(ms, ZUGFeRDVersion.Version23, Profile.XRechnung, ZUGFeRDFormats.UBL);
+        } // !UBLAvailability()
+
+
         [TestMethod]
         [DataRow(ZUGFeRDVersion.Version1, Profile.Extended)]
         [DataRow(ZUGFeRDVersion.Version20, Profile.Extended)]

ZUGFeRD/InvoiceDescriptor23Writer.cs

@@ -41,11 +41,20 @@ internal class InvoiceDescriptor23Writer : IInvoiceDescriptorWriter
         /// <param name="format">Format of the target file</param>
         public override void Save(InvoiceDescriptor descriptor, Stream stream, ZUGFeRDFormats format = ZUGFeRDFormats.CII)
         {
-            IInvoiceDescriptorWriter _writer;
-            switch (format)
+            IInvoiceDescriptorWriter _writer = null;
+
+            if (format == ZUGFeRDFormats.CII)
+            {
+                _writer = new InvoiceDescriptor23CIIWriter();
+            }
+            else if ((format == ZUGFeRDFormats.UBL) && (descriptor.Profile == Profile.XRechnung))
+            {
+                _writer = new InvoiceDescriptor22UBLWriter();
+            }
+
+            if (_writer == null)
             {
-                case ZUGFeRDFormats.UBL: _writer = new InvoiceDescriptor22UBLWriter(); break;
-                default: _writer = new InvoiceDescriptor23CIIWriter(); break;
+                throw new UnsupportedException($"Profile {descriptor.Profile.EnumToString()} and format {format.EnumToString()} is not supported.");                
             }
 
             _writer.Save(descriptor, stream, format);