Merge pull request #44 from stefanak-michal/issue/41_php8

update phpunit to connection abstract class. Update Socket to php8.

Author: stefanak-michal

src/connection/Socket.php

@@ -16,9 +16,9 @@ class Socket extends AConnection
 {
 
     /**
-     * @var resource
+     * @var resource|object|bool
      */
-    private $socket;
+    private $socket = false;
 
     /**
      * Create socket connection
@@ -32,7 +32,7 @@ public function connect(): bool
         }
 
         $this->socket = @socket_create(AF_INET, SOCK_STREAM, SOL_TCP);
-        if (!is_resource($this->socket)) {
+        if ($this->socket === false) {
             throw new ConnectException('Cannot create socket');
         }
 
@@ -61,7 +61,7 @@ public function connect(): bool
      */
     public function write(string $buffer)
     {
-        if (!is_resource($this->socket)) {
+        if ($this->socket === false) {
             throw new ConnectException('Not initialized socket');
         }
 
@@ -93,7 +93,7 @@ public function read(int $length = 2048): string
     {
         $output = '';
 
-        if (!is_resource($this->socket)) {
+        if ($this->socket === false) {
             throw new ConnectException('Not initialized socket');
         }
 
@@ -117,7 +117,7 @@ public function read(int $length = 2048): string
      */
     public function disconnect()
     {
-        if (is_resource($this->socket)) {
+        if ($this->socket !== false) {
             @socket_shutdown($this->socket);
             @socket_close($this->socket);
         }

tests/ATest.php

@@ -3,7 +3,7 @@
 namespace Bolt\tests;
 
 use PHPUnit\Framework\TestCase;
-use Bolt\connection\IConnection;
+use Bolt\connection\AConnection;
 
 /**
  * Class ATest
@@ -33,15 +33,15 @@ abstract class ATest extends TestCase
 
     /**
      * Mock Socket class with "write" and "read" methods
-     * @return IConnection
+     * @return AConnection
      */
     protected function mockConnection()
     {
         $mockBuilder = $this
-            ->getMockBuilder(IConnection::class)
+            ->getMockBuilder(AConnection::class)
             ->disableOriginalConstructor();
         call_user_func([$mockBuilder, method_exists($mockBuilder, 'onlyMethods') ? 'onlyMethods' : 'setMethods'], ['__construct', 'write', 'read', 'connect', 'disconnect']);
-        /** @var IConnection $connection */
+        /** @var AConnection $connection */
         $connection = $mockBuilder->getMock();
 
         $connection
@@ -98,9 +98,9 @@ public function readCallback(): string
     }
 
     /**
-     * Reset mockup IConnetion variables
+     * Reset mockup AConnetion variables
      */
-    protected function setUp()
+    protected function setUp(): void
     {
         self::$readIndex = 0;
         self::$readArray = [];