From 2470e8ef329ecc1b385ad0c69de5dc326aa39ef9 Mon Sep 17 00:00:00 2001 From: Pravesh Date: Tue, 8 Apr 2025 12:42:16 -0400 Subject: [PATCH 1/4] fix: change strides parameter to be pointer to const --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../@stdlib/ndarray/base/assert/is-column-major/src/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/ndarray/base/assert/is-column-major/src/main.c b/lib/node_modules/@stdlib/ndarray/base/assert/is-column-major/src/main.c index b0250d008e44..7a78b3ff5143 100644 --- a/lib/node_modules/@stdlib/ndarray/base/assert/is-column-major/src/main.c +++ b/lib/node_modules/@stdlib/ndarray/base/assert/is-column-major/src/main.c @@ -40,7 +40,7 @@ * int8_t b = stdlib_ndarray_is_column_major( ndims, strides ); * // returns 1 */ -int8_t stdlib_ndarray_is_column_major( int64_t ndims, int64_t *strides ) { +int8_t stdlib_ndarray_is_column_major( int64_t ndims, const int64_t *strides ) { int64_t s1; int64_t s2; int64_t i; From e771684cb160d62a0bfeab6d89fc1723328c1998 Mon Sep 17 00:00:00 2001 From: Pravesh Date: Wed, 9 Apr 2025 09:43:20 -0400 Subject: [PATCH 2/4] fix: changed ndims to be const --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../@stdlib/ndarray/base/assert/is-column-major/src/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/ndarray/base/assert/is-column-major/src/main.c b/lib/node_modules/@stdlib/ndarray/base/assert/is-column-major/src/main.c index 7a78b3ff5143..d2f6508b5a5a 100644 --- a/lib/node_modules/@stdlib/ndarray/base/assert/is-column-major/src/main.c +++ b/lib/node_modules/@stdlib/ndarray/base/assert/is-column-major/src/main.c @@ -40,7 +40,7 @@ * int8_t b = stdlib_ndarray_is_column_major( ndims, strides ); * // returns 1 */ -int8_t stdlib_ndarray_is_column_major( int64_t ndims, const int64_t *strides ) { +int8_t stdlib_ndarray_is_column_major(const int64_t ndims, const int64_t *strides ) { int64_t s1; int64_t s2; int64_t i; From 54a3756fa675f5973a9949125d991ec3f4d50e8a Mon Sep 17 00:00:00 2001 From: Athan Date: Wed, 9 Apr 2025 17:35:04 -0700 Subject: [PATCH 3/4] style: add missing space Signed-off-by: Athan --- .../@stdlib/ndarray/base/assert/is-column-major/src/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/ndarray/base/assert/is-column-major/src/main.c b/lib/node_modules/@stdlib/ndarray/base/assert/is-column-major/src/main.c index d2f6508b5a5a..ed63302e5cf2 100644 --- a/lib/node_modules/@stdlib/ndarray/base/assert/is-column-major/src/main.c +++ b/lib/node_modules/@stdlib/ndarray/base/assert/is-column-major/src/main.c @@ -40,7 +40,7 @@ * int8_t b = stdlib_ndarray_is_column_major( ndims, strides ); * // returns 1 */ -int8_t stdlib_ndarray_is_column_major(const int64_t ndims, const int64_t *strides ) { +int8_t stdlib_ndarray_is_column_major( const int64_t ndims, const int64_t *strides ) { int64_t s1; int64_t s2; int64_t i; From 1b6e8699403e497da747d679aa16346ce6b2afbe Mon Sep 17 00:00:00 2001 From: Pravesh Date: Wed, 9 Apr 2025 21:36:20 -0400 Subject: [PATCH 4/4] fix: changed associated header file --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../include/stdlib/ndarray/base/assert/is_column_major.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/ndarray/base/assert/is-column-major/include/stdlib/ndarray/base/assert/is_column_major.h b/lib/node_modules/@stdlib/ndarray/base/assert/is-column-major/include/stdlib/ndarray/base/assert/is_column_major.h index 22003a51ff9f..530f7b053a21 100644 --- a/lib/node_modules/@stdlib/ndarray/base/assert/is-column-major/include/stdlib/ndarray/base/assert/is_column_major.h +++ b/lib/node_modules/@stdlib/ndarray/base/assert/is-column-major/include/stdlib/ndarray/base/assert/is_column_major.h @@ -31,7 +31,7 @@ extern "C" { /** * Determines if an array is column-major based on a provided stride array. */ -int8_t stdlib_ndarray_is_column_major( int64_t ndims, int64_t *strides ); +int8_t stdlib_ndarray_is_column_major( const int64_t ndims, const int64_t *strides ); #ifdef __cplusplus }