From 19f604d2dcbf6546cecd80421b0d5a65726e2529 Mon Sep 17 00:00:00 2001 From: Neerajpathak07 Date: Sat, 22 Mar 2025 22:24:41 +0530 Subject: [PATCH 01/15] feat: adding C implementation --- .../math/base/special/minmax/README.md | 100 +++++++++++ .../special/minmax/benchmark/benchmark.js | 22 ++- .../minmax/benchmark/benchmark.native.js | 116 ++++++++++++ .../minmax/benchmark/c/native/Makefile | 127 +++++++++++++ .../minmax/benchmark/c/native/benchmark.c | 140 +++++++++++++++ .../math/base/special/minmax/binding.gyp | 170 ++++++++++++++++++ .../base/special/minmax/examples/c/Makefile | 146 +++++++++++++++ .../base/special/minmax/examples/c/example.c | 39 ++++ .../math/base/special/minmax/include.gypi | 53 ++++++ .../include/stdlib/math/base/special/minmax.h | 38 ++++ .../math/base/special/minmax/manifest.json | 74 ++++++++ .../math/base/special/minmax/src/Makefile | 70 ++++++++ .../math/base/special/minmax/src/addon.c | 43 +++++ .../math/base/special/minmax/src/main.c | 64 +++++++ .../base/special/minmax/test/test.native.js | 129 +++++++++++++ 15 files changed, 1322 insertions(+), 9 deletions(-) create mode 100644 lib/node_modules/@stdlib/math/base/special/minmax/benchmark/benchmark.native.js create mode 100644 lib/node_modules/@stdlib/math/base/special/minmax/benchmark/c/native/Makefile create mode 100644 lib/node_modules/@stdlib/math/base/special/minmax/benchmark/c/native/benchmark.c create mode 100644 lib/node_modules/@stdlib/math/base/special/minmax/binding.gyp create mode 100644 lib/node_modules/@stdlib/math/base/special/minmax/examples/c/Makefile create mode 100644 lib/node_modules/@stdlib/math/base/special/minmax/examples/c/example.c create mode 100644 lib/node_modules/@stdlib/math/base/special/minmax/include.gypi create mode 100644 lib/node_modules/@stdlib/math/base/special/minmax/include/stdlib/math/base/special/minmax.h create mode 100644 lib/node_modules/@stdlib/math/base/special/minmax/manifest.json create mode 100644 lib/node_modules/@stdlib/math/base/special/minmax/src/Makefile create mode 100644 lib/node_modules/@stdlib/math/base/special/minmax/src/addon.c create mode 100644 lib/node_modules/@stdlib/math/base/special/minmax/src/main.c create mode 100644 lib/node_modules/@stdlib/math/base/special/minmax/test/test.native.js diff --git a/lib/node_modules/@stdlib/math/base/special/minmax/README.md b/lib/node_modules/@stdlib/math/base/special/minmax/README.md index 9f4b1b904a3f..e7100ec8b9b6 100644 --- a/lib/node_modules/@stdlib/math/base/special/minmax/README.md +++ b/lib/node_modules/@stdlib/math/base/special/minmax/README.md @@ -119,6 +119,106 @@ for ( i = 0; i < 100; i++ ) { + + +* * * + +
+ +## C APIs + + + +
+ +
+ + + + + +
+ +### Usage + +```c +#include "stdlib/math/base/special/minmax.h" +``` + +#### stdlib_base_minmax( x, y, &min, &max ) + +Returns the minimum and maximum value. + +```c +#include + +double min; +double max; + +stdlib_base_minmax( 4.0, -5.0, &min, &max ); +``` + +The function accepts the following arguments: + +- **x**: `[in] double` input value. +- **y**: `[in] double` input value. +- **min**: `[out] double` destination for minimum value. +- **max**: `[out] double` destination for maximum value. + +```c +void stdlib_base_minmax( const double x, const double y, double* min, double* max ); +``` + +
+ + + + + +
+ +
+ + + + + +
+ +### Examples + +```c +#include "stdlib/math/base/special/minmax.h" +#include +#include + +int main( void ) { + double min; + double max; + double x; + double y; + int i; + + const double x1[] = { 1.0, 0.45, -0.89, 0.0 / 0.0, -0.78, -0.22, 0.66, 0.11, -0.55, 0.0 }; + const double x2[] = { -0.22, 0.66, 0.0, -0.55, 0.33, 1.0, 0.0 / 0.0, 0.11, 0.45, -0.78 }; + + for ( i = 0; i < 12; i++ ) { + x = ( ( (double)rand() / (double)RAND_MAX ) * 200.0 ) - 100.0; + y = ( ( (double)rand() / (double)RAND_MAX ) * 200.0 ) - 100.0; + stdlib_base_minmax( x[ i ], y[ i ], &min, &max ); + printf( "x: %lf => min: %lf, y: %lf, minmax(x, y): %lf\n", x[ i ], y[ i ]min, max ); + } +} +``` + +
+ + + +
+ + +
diff --git a/lib/node_modules/@stdlib/math/base/special/minmax/benchmark/benchmark.js b/lib/node_modules/@stdlib/math/base/special/minmax/benchmark/benchmark.js index 0ff633a58cfc..d76994e7bf22 100644 --- a/lib/node_modules/@stdlib/math/base/special/minmax/benchmark/benchmark.js +++ b/lib/node_modules/@stdlib/math/base/special/minmax/benchmark/benchmark.js @@ -21,7 +21,7 @@ // MODULES // var bench = require( '@stdlib/bench' ); -var randu = require( '@stdlib/random/base/randu' ); +var discreteUniform = require( '@stdlib/random/array/discrete-uniform' ); var isArray = require( '@stdlib/assert/is-array' ); var min = require( '@stdlib/math/base/special/min' ); var max = require( '@stdlib/math/base/special/max' ); @@ -37,10 +37,11 @@ bench( pkg, function benchmark( b ) { var z; var i; + x = discreteUniform( 100, -500, 500 ); + y = discreteUniform( 100, -500, 500 ); + b.tic(); for ( i = 0; i < b.iterations; i++ ) { - x = ( randu()*1000.0 ) - 500.0; - y = ( randu()*1000.0 ) - 500.0; z = minmax( x, y ); if ( z.length !== 2 ) { b.fail( 'should have expected length' ); @@ -63,10 +64,11 @@ bench( pkg+':assign', function benchmark( b ) { out = [ 0.0, 0.0 ]; + x = discreteUniform( 100, -500, 500 ); + y = discreteUniform( 100, -500, 500 ); + b.tic(); for ( i = 0; i < b.iterations; i++ ) { - x = ( randu()*1000.0 ) - 500.0; - y = ( randu()*1000.0 ) - 500.0; z = minmax.assign( x, y, out, 1, 0 ); if ( z.length !== 2 ) { b.fail( 'should have expected length' ); @@ -86,10 +88,11 @@ bench( pkg+'::min,max', function benchmark( b ) { var z; var i; + x = discreteUniform( 100, -500, 500 ); + y = discreteUniform( 100, -500, 500 ); + b.tic(); for ( i = 0; i < b.iterations; i++ ) { - x = ( randu()*1000.0 ) - 500.0; - y = ( randu()*1000.0 ) - 500.0; z = [ min( x, y ), max( x, y ) ]; if ( z.length !== 2 ) { b.fail( 'should have expected length' ); @@ -111,10 +114,11 @@ bench( pkg+'::min,max,memory_reuse', function benchmark( b ) { z = [ 0.0, 0.0 ]; + x = discreteUniform( 100, -500, 500 ); + y = discreteUniform( 100, -500, 500 ); + b.tic(); for ( i = 0; i < b.iterations; i++ ) { - x = ( randu()*1000.0 ) - 500.0; - y = ( randu()*1000.0 ) - 500.0; z[ 0 ] = min( x, y ); z[ 1 ] = max( x, y ); if ( z.length !== 2 ) { diff --git a/lib/node_modules/@stdlib/math/base/special/minmax/benchmark/benchmark.native.js b/lib/node_modules/@stdlib/math/base/special/minmax/benchmark/benchmark.native.js new file mode 100644 index 000000000000..eee1d73a2a24 --- /dev/null +++ b/lib/node_modules/@stdlib/math/base/special/minmax/benchmark/benchmark.native.js @@ -0,0 +1,116 @@ +/** +* @license Apache-2.0 +* +* Copyright (c) 2025 The Stdlib Authors. +* +* Licensed under the Apache License, Version 2.0 (the "License"); +* you may not use this file except in compliance with the License. +* You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +*/ + +'use strict'; + +// MODULES // + +var resolve = require( 'path' ).resolve; +var bench = require( '@stdlib/bench' ); +var discreteUniform = require( '@stdlib/random/array/discrete-uniform' ); +var isArray = require( '@stdlib/assert/is-array' ); +var min = require( '@stdlib/math/base/special/min' ); +var max = require( '@stdlib/math/base/special/max' ); +var tryRequire = require( '@stdlib/utils/try-require' ); +var pkg = require( './../package.json' ).name; + + +// VARIABLES // + +var minmax = tryRequire( resolve( __dirname, './../lib/native.js' ) ); +var opts = { + 'skip': ( minmax instanceof Error ) +}; + + +// MAIN // + +bench( pkg+'::native', opts, function benchmark( b ) { + var x; + var y; + var z; + var i; + + x = discreteUniform( 100, -500, 500 ); + y = discreteUniform( 100, -500, 500 ); + + b.tic(); + for ( i = 0; i < b.iterations; i++ ) { + z = minmax( x, y ); + if ( z.length !== 2 ) { + b.fail( 'should have expected length' ); + } + } + b.toc(); + if ( !isArray( z ) ) { + b.fail( 'should return an array' ); + } + b.pass( 'benchmark finished' ); + b.end(); +}); + +bench( pkg+'::min,max', opts, function benchmark( b ) { + var x; + var y; + var z; + var i; + + x = discreteUniform( 100, -500, 500 ); + y = discreteUniform( 100, -500, 500 ); + + b.tic(); + for ( i = 0; i < b.iterations; i++ ) { + z = [ min( x, y ), max( x, y ) ]; + if ( z.length !== 2 ) { + b.fail( 'should have expected length' ); + } + } + b.toc(); + if ( !isArray( z ) ) { + b.fail( 'should return an array' ); + } + b.pass( 'benchmark finished' ); + b.end(); +}); + +bench( pkg+'::min,max,memory_reuse', opts, function benchmark( b ) { + var x; + var y; + var z; + var i; + + z = [ 0.0, 0.0 ]; + + x = discreteUniform( 100, -500, 500 ); + y = discreteUniform( 100, -500, 500 ); + + b.tic(); + for ( i = 0; i < b.iterations; i++ ) { + z[ 0 ] = min( x, y ); + z[ 1 ] = max( x, y ); + if ( z.length !== 2 ) { + b.fail( 'should have expected length' ); + } + } + b.toc(); + if ( !isArray( z ) ) { + b.fail( 'should return an array' ); + } + b.pass( 'benchmark finished' ); + b.end(); +}); diff --git a/lib/node_modules/@stdlib/math/base/special/minmax/benchmark/c/native/Makefile b/lib/node_modules/@stdlib/math/base/special/minmax/benchmark/c/native/Makefile new file mode 100644 index 000000000000..d564e8b2d6f9 --- /dev/null +++ b/lib/node_modules/@stdlib/math/base/special/minmax/benchmark/c/native/Makefile @@ -0,0 +1,127 @@ +#/ +# @license Apache-2.0 +# +# Copyright (c) 2025 The Stdlib Authors. +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +#/ + + +# VARIABLES # + +ifndef VERBOSE + QUIET := @ +else + QUIET := +endif + +# Determine the OS ([1][1], [2][2]). +# +# [1]: https://en.wikipedia.org/wiki/Uname#Examples +# [2]: http://stackoverflow.com/a/27776822/2225624 +OS ?= $(shell uname) +ifneq (, $(findstring MINGW,$(OS))) + OS := WINNT +else +ifneq (, $(findstring MSYS,$(OS))) + OS := WINNT +else +ifneq (, $(findstring CYGWIN,$(OS))) + OS := WINNT +else +ifneq (, $(findstring Windows_NT,$(OS))) + OS := WINNT +endif +endif +endif +endif + +# Define the program used for compiling C source files: +ifdef C_COMPILER + CC := $(C_COMPILER) +else + CC := gcc +endif + +# Define the command-line options when compiling C files: +CFLAGS ?= \ + -std=c99 \ + -O3 \ + -Wall \ + -pedantic + +# Determine whether to generate position independent code ([1][1], [2][2]). +# +# [1]: https://gcc.gnu.org/onlinedocs/gcc/Code-Gen-Options.html#Code-Gen-Options +# [2]: http://stackoverflow.com/questions/5311515/gcc-fpic-option +ifeq ($(OS), WINNT) + fPIC ?= +else + fPIC ?= -fPIC +endif + +# List of C targets: +c_targets := benchmark.out + + +# RULES # + +#/ +# Compiles C source files. +# +# @param {string} [C_COMPILER] - C compiler +# @param {string} [CFLAGS] - C compiler flags +# @param {(string|void)} [fPIC] - compiler flag indicating whether to generate position independent code +# +# @example +# make +# +# @example +# make all +#/ +all: $(c_targets) + +.PHONY: all + +#/ +# Compiles C source files. +# +# @private +# @param {string} CC - C compiler +# @param {string} CFLAGS - C compiler flags +# @param {(string|void)} fPIC - compiler flag indicating whether to generate position independent code +#/ +$(c_targets): %.out: %.c + $(QUIET) $(CC) $(CFLAGS) $(fPIC) -o $@ $< -lm + +#/ +# Runs compiled benchmarks. +# +# @example +# make run +#/ +run: $(c_targets) + $(QUIET) ./$< + +.PHONY: run + +#/ +# Removes generated files. +# +# @example +# make clean +#/ +clean: + $(QUIET) -rm -f *.o *.out + +.PHONY: clean diff --git a/lib/node_modules/@stdlib/math/base/special/minmax/benchmark/c/native/benchmark.c b/lib/node_modules/@stdlib/math/base/special/minmax/benchmark/c/native/benchmark.c new file mode 100644 index 000000000000..ba49cff43e39 --- /dev/null +++ b/lib/node_modules/@stdlib/math/base/special/minmax/benchmark/c/native/benchmark.c @@ -0,0 +1,140 @@ +/** +* @license Apache-2.0 +* +* Copyright (c) 2025 The Stdlib Authors. +* +* Licensed under the Apache License, Version 2.0 (the "License"); +* you may not use this file except in compliance with the License. +* You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +*/ + +#include "stdlib/math/base/special/minmax.h" +#include +#include +#include +#include +#include + +#define NAME "minmax" +#define ITERATIONS 1000000 +#define REPEATS 3 + +/** +* Prints the TAP version. +*/ +static void print_version( void ) { + printf( "TAP version 13\n" ); +} + +/** +* Prints the TAP summary. +* +* @param total total number of tests +* @param passing total number of passing tests +*/ +static void print_summary( int total, int passing ) { + printf( "#\n" ); + printf( "1..%d\n", total ); // TAP plan + printf( "# total %d\n", total ); + printf( "# pass %d\n", passing ); + printf( "#\n" ); + printf( "# ok\n" ); +} + +/** +* Prints benchmarks results. +* +* @param elapsed elapsed time in seconds +*/ +static void print_results( double elapsed ) { + double rate = (double)ITERATIONS / elapsed; + printf( " ---\n" ); + printf( " iterations: %d\n", ITERATIONS ); + printf( " elapsed: %0.9f\n", elapsed ); + printf( " rate: %0.9f\n", rate ); + printf( " ...\n" ); +} + +/** +* Returns a clock time. +* +* @return clock time +*/ +static double tic( void ) { + struct timeval now; + gettimeofday( &now, NULL ); + return (double)now.tv_sec + (double)now.tv_usec / 1.0e6; +} + +/** +* Generates a random number on the interval [0,1). +* +* @return random number +*/ +static double rand_double( void ) { + int r = rand(); + return (double)r / ( (double)RAND_MAX + 1.0 ); +} + +/** +* Runs a benchmark. +* +* @return elapsed time in seconds +*/ +static double benchmark( void ) { + double elapsed; + double min; + double max; + double x[ 100 ]; + double y[ 100 ]; + double z; + double t; + int i; + + for( i = 0; i < 100; i++ ) { + x[ i ] = ( 1000.0*rand_double() ) - 500.0; + y[ i ] = ( 1000.0*rand_double() ) - 500.0; + } + + t = tic(); + for ( i = 0; i < ITERATIONS; i++ ) { + z = stdlib_base_minmax( x[ i%100 ], y[ i%100 ], &min, &max ); + if ( max != max || min != min ) { + printf( "should not return NaN\n" ); + break; + } + } + elapsed = tic() - t; + if ( max != max || min != min ) { + printf( "should not return NaN\n" ); + } + return elapsed; +} + +/** +* Main execution sequence. +*/ +int main( void ) { + double elapsed; + int i; + + // Use the current time to seed the random number generator: + srand( time( NULL ) ); + + print_version(); + for ( i = 0; i < REPEATS; i++ ) { + printf( "# c::native::%s\n", NAME ); + elapsed = benchmark(); + print_results( elapsed ); + printf( "ok %d benchmark finished\n", i+1 ); + } + print_summary( REPEATS, REPEATS ); +} diff --git a/lib/node_modules/@stdlib/math/base/special/minmax/binding.gyp b/lib/node_modules/@stdlib/math/base/special/minmax/binding.gyp new file mode 100644 index 000000000000..68a1ca11d160 --- /dev/null +++ b/lib/node_modules/@stdlib/math/base/special/minmax/binding.gyp @@ -0,0 +1,170 @@ +# @license Apache-2.0 +# +# Copyright (c) 2025 The Stdlib Authors. +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# A `.gyp` file for building a Node.js native add-on. +# +# [1]: https://gyp.gsrc.io/docs/InputFormatReference.md +# [2]: https://gyp.gsrc.io/docs/UserDocumentation.md +{ + # List of files to include in this file: + 'includes': [ + './include.gypi', + ], + + # Define variables to be used throughout the configuration for all targets: + 'variables': { + # Target name should match the add-on export name: + 'addon_target_name%': 'addon', + + # Set variables based on the host OS: + 'conditions': [ + [ + 'OS=="win"', + { + # Define the object file suffix: + 'obj': 'obj', + }, + { + # Define the object file suffix: + 'obj': 'o', + } + ], # end condition (OS=="win") + ], # end conditions + }, # end variables + + # Define compile targets: + 'targets': [ + + # Target to generate an add-on: + { + # The target name should match the add-on export name: + 'target_name': '<(addon_target_name)', + + # Define dependencies: + 'dependencies': [], + + # Define directories which contain relevant include headers: + 'include_dirs': [ + # Local include directory: + '<@(include_dirs)', + ], + + # List of source files: + 'sources': [ + '<@(src_files)', + ], + + # Settings which should be applied when a target's object files are used as linker input: + 'link_settings': { + # Define libraries: + 'libraries': [ + '<@(libraries)', + ], + + # Define library directories: + 'library_dirs': [ + '<@(library_dirs)', + ], + }, + + # C/C++ compiler flags: + 'cflags': [ + # Enable commonly used warning options: + '-Wall', + + # Aggressive optimization: + '-O3', + ], + + # C specific compiler flags: + 'cflags_c': [ + # Specify the C standard to which a program is expected to conform: + '-std=c99', + ], + + # C++ specific compiler flags: + 'cflags_cpp': [ + # Specify the C++ standard to which a program is expected to conform: + '-std=c++11', + ], + + # Linker flags: + 'ldflags': [], + + # Apply conditions based on the host OS: + 'conditions': [ + [ + 'OS=="mac"', + { + # Linker flags: + 'ldflags': [ + '-undefined dynamic_lookup', + '-Wl,-no-pie', + '-Wl,-search_paths_first', + ], + }, + ], # end condition (OS=="mac") + [ + 'OS!="win"', + { + # C/C++ flags: + 'cflags': [ + # Generate platform-independent code: + '-fPIC', + ], + }, + ], # end condition (OS!="win") + ], # end conditions + }, # end target <(addon_target_name) + + # Target to copy a generated add-on to a standard location: + { + 'target_name': 'copy_addon', + + # Declare that the output of this target is not linked: + 'type': 'none', + + # Define dependencies: + 'dependencies': [ + # Require that the add-on be generated before building this target: + '<(addon_target_name)', + ], + + # Define a list of actions: + 'actions': [ + { + 'action_name': 'copy_addon', + 'message': 'Copying addon...', + + # Explicitly list the inputs in the command-line invocation below: + 'inputs': [], + + # Declare the expected outputs: + 'outputs': [ + '<(addon_output_dir)/<(addon_target_name).node', + ], + + # Define the command-line invocation: + 'action': [ + 'cp', + '<(PRODUCT_DIR)/<(addon_target_name).node', + '<(addon_output_dir)/<(addon_target_name).node', + ], + }, + ], # end actions + }, # end target copy_addon + ], # end targets +} diff --git a/lib/node_modules/@stdlib/math/base/special/minmax/examples/c/Makefile b/lib/node_modules/@stdlib/math/base/special/minmax/examples/c/Makefile new file mode 100644 index 000000000000..25ced822f96a --- /dev/null +++ b/lib/node_modules/@stdlib/math/base/special/minmax/examples/c/Makefile @@ -0,0 +1,146 @@ +#/ +# @license Apache-2.0 +# +# Copyright (c) 2025 The Stdlib Authors. +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +#/ + +# VARIABLES # + +ifndef VERBOSE + QUIET := @ +else + QUIET := +endif + +# Determine the OS ([1][1], [2][2]). +# +# [1]: https://en.wikipedia.org/wiki/Uname#Examples +# [2]: http://stackoverflow.com/a/27776822/2225624 +OS ?= $(shell uname) +ifneq (, $(findstring MINGW,$(OS))) + OS := WINNT +else +ifneq (, $(findstring MSYS,$(OS))) + OS := WINNT +else +ifneq (, $(findstring CYGWIN,$(OS))) + OS := WINNT +else +ifneq (, $(findstring Windows_NT,$(OS))) + OS := WINNT +endif +endif +endif +endif + +# Define the program used for compiling C source files: +ifdef C_COMPILER + CC := $(C_COMPILER) +else + CC := gcc +endif + +# Define the command-line options when compiling C files: +CFLAGS ?= \ + -std=c99 \ + -O3 \ + -Wall \ + -pedantic + +# Determine whether to generate position independent code ([1][1], [2][2]). +# +# [1]: https://gcc.gnu.org/onlinedocs/gcc/Code-Gen-Options.html#Code-Gen-Options +# [2]: http://stackoverflow.com/questions/5311515/gcc-fpic-option +ifeq ($(OS), WINNT) + fPIC ?= +else + fPIC ?= -fPIC +endif + +# List of includes (e.g., `-I /foo/bar -I /beep/boop/include`): +INCLUDE ?= + +# List of source files: +SOURCE_FILES ?= + +# List of libraries (e.g., `-lopenblas -lpthread`): +LIBRARIES ?= + +# List of library paths (e.g., `-L /foo/bar -L /beep/boop`): +LIBPATH ?= + +# List of C targets: +c_targets := example.out + + +# RULES # + +#/ +# Compiles source files. +# +# @param {string} [C_COMPILER] - C compiler (e.g., `gcc`) +# @param {string} [CFLAGS] - C compiler options +# @param {(string|void)} [fPIC] - compiler flag determining whether to generate position independent code (e.g., `-fPIC`) +# @param {string} [INCLUDE] - list of includes (e.g., `-I /foo/bar -I /beep/boop/include`) +# @param {string} [SOURCE_FILES] - list of source files +# @param {string} [LIBPATH] - list of library paths (e.g., `-L /foo/bar -L /beep/boop`) +# @param {string} [LIBRARIES] - list of libraries (e.g., `-lopenblas -lpthread`) +# +# @example +# make +# +# @example +# make all +#/ +all: $(c_targets) + +.PHONY: all + +#/ +# Compiles C source files. +# +# @private +# @param {string} CC - C compiler (e.g., `gcc`) +# @param {string} CFLAGS - C compiler options +# @param {(string|void)} fPIC - compiler flag determining whether to generate position independent code (e.g., `-fPIC`) +# @param {string} INCLUDE - list of includes (e.g., `-I /foo/bar`) +# @param {string} SOURCE_FILES - list of source files +# @param {string} LIBPATH - list of library paths (e.g., `-L /foo/bar`) +# @param {string} LIBRARIES - list of libraries (e.g., `-lopenblas`) +#/ +$(c_targets): %.out: %.c + $(QUIET) $(CC) $(CFLAGS) $(fPIC) $(INCLUDE) -o $@ $(SOURCE_FILES) $< $(LIBPATH) -lm $(LIBRARIES) + +#/ +# Runs compiled examples. +# +# @example +# make run +#/ +run: $(c_targets) + $(QUIET) ./$< + +.PHONY: run + +#/ +# Removes generated files. +# +# @example +# make clean +#/ +clean: + $(QUIET) -rm -f *.o *.out + +.PHONY: clean diff --git a/lib/node_modules/@stdlib/math/base/special/minmax/examples/c/example.c b/lib/node_modules/@stdlib/math/base/special/minmax/examples/c/example.c new file mode 100644 index 000000000000..b1b0a5597f2d --- /dev/null +++ b/lib/node_modules/@stdlib/math/base/special/minmax/examples/c/example.c @@ -0,0 +1,39 @@ +/** +* @license Apache-2.0 +* +* Copyright (c) 2025 The Stdlib Authors. +* +* Licensed under the Apache License, Version 2.0 (the "License"); +* you may not use this file except in compliance with the License. +* You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +*/ + +#include "stdlib/math/base/special/minmax.h" +#include +#include + +int main( void ) { + double min; + double max; + double x; + double y; + int i; + + const double x1[] = { 1.0, 0.45, -0.89, 0.0 / 0.0, -0.78, -0.22, 0.66, 0.11, -0.55, 0.0 }; + const double x2[] = { -0.22, 0.66, 0.0, -0.55, 0.33, 1.0, 0.0 / 0.0, 0.11, 0.45, -0.78 }; + + for ( i = 0; i < 12; i++ ) { + x = ( ( (double)rand() / (double)RAND_MAX ) * 200.0 ) - 100.0; + y = ( ( (double)rand() / (double)RAND_MAX ) * 200.0 ) - 100.0; + stdlib_base_minmax( x[ i ], y[ i ], &min, &max ); + printf( "x: %lf => min: %lf, y: %lf, minmax(x, y): %lf\n", x[ i ], y[ i ], min, max ); + } +} diff --git a/lib/node_modules/@stdlib/math/base/special/minmax/include.gypi b/lib/node_modules/@stdlib/math/base/special/minmax/include.gypi new file mode 100644 index 000000000000..ecfaf82a3279 --- /dev/null +++ b/lib/node_modules/@stdlib/math/base/special/minmax/include.gypi @@ -0,0 +1,53 @@ +# @license Apache-2.0 +# +# Copyright (c) 2025 The Stdlib Authors. +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# A GYP include file for building a Node.js native add-on. +# +# Main documentation: +# +# [1]: https://gyp.gsrc.io/docs/InputFormatReference.md +# [2]: https://gyp.gsrc.io/docs/UserDocumentation.md +{ + # Define variables to be used throughout the configuration for all targets: + 'variables': { + # Source directory: + 'src_dir': './src', + + # Include directories: + 'include_dirs': [ + ' + +/** +* Receives JavaScript callback invocation data. +* +* @param env environment under which the function is invoked +* @param info callback data +* @return Node-API value +*/ +static napi_value addon( napi_env env, napi_callback_info info ) { + STDLIB_NAPI_ARGV( env, info, argv, argc, 3 ); + STDLIB_NAPI_ARGV_DOUBLE( env, x, argv, 0 ); + STDLIB_NAPI_ARGV_DOUBLE( env, y, argv, 1 ); + STDLIB_NAPI_ARGV_FLOAT64ARRAY( env, z, zlen, argv, 2 ); + STDLIB_NAPI_CREATE_DOUBLE( env, stdlib_base_minmax( x, y, &z[0], &z[1] ), n ); + return n; +} + +STDLIB_NAPI_MODULE_EXPORT_FCN( addon ) diff --git a/lib/node_modules/@stdlib/math/base/special/minmax/src/main.c b/lib/node_modules/@stdlib/math/base/special/minmax/src/main.c new file mode 100644 index 000000000000..39bf591867a0 --- /dev/null +++ b/lib/node_modules/@stdlib/math/base/special/minmax/src/main.c @@ -0,0 +1,64 @@ +/** +* @license Apache-2.0 +* +* Copyright (c) 2025 The Stdlib Authors. +* +* Licensed under the Apache License, Version 2.0 (the "License"); +* you may not use this file except in compliance with the License. +* You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +*/ + +#include "stdlib/math/base/special/minmax.h" +#include "stdlib/math/base/assert/is_nan.h" +#include "stdlib/math/base/assert/is_negative_zero.h" +#include + +/** +* Evaluates the min and max of two values. +* +* @param x First value +* @param y Second value +* @param min destination to store minimum value +* @param max destination to store maximum value +* +* @example +* #include +* +* double min; +* double max; +* stdlib_base_minmax( 4.0, -5.0, &min, &max ); +*/ + +void stdlib_base_minmax( const double x, const double y, double* min, double* max ) { + if ( stdlib_base_is_nan( x ) || stdlib_base_is_nan( y ) ) { + *min = 0.0 / 0.0; // NaN + *max = 0.0 / 0.0; // NaN + return; + } + if ( x == y && x == 0 ) { + if ( stdlib_base_is_negative_zero( x ) ) { + *min = x; + *max = y; + return; + } + *min = y; + *max = x; + return; + } + if ( x < y ) { + *min = x; + *max = y; + return; + } + *min = y; + *max = x; + return; +} diff --git a/lib/node_modules/@stdlib/math/base/special/minmax/test/test.native.js b/lib/node_modules/@stdlib/math/base/special/minmax/test/test.native.js new file mode 100644 index 000000000000..6f5f4a2e3617 --- /dev/null +++ b/lib/node_modules/@stdlib/math/base/special/minmax/test/test.native.js @@ -0,0 +1,129 @@ +/** +* @license Apache-2.0 +* +* Copyright (c) 2025 The Stdlib Authors. +* +* Licensed under the Apache License, Version 2.0 (the "License"); +* you may not use this file except in compliance with the License. +* You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +*/ + +'use strict'; + +// MODULES // + +var resolve = require( 'path' ).resolve; +var tape = require( 'tape' ); +var isnan = require( '@stdlib/math/base/assert/is-nan' ); +var isNegativeZero = require( '@stdlib/math/base/assert/is-negative-zero' ); +var isPositiveZero = require( '@stdlib/math/base/assert/is-positive-zero' ); +var PINF = require( '@stdlib/constants/float64/pinf' ); +var NINF = require( '@stdlib/constants/float64/ninf' ); +var tryRequire = require( '@stdlib/utils/try-require' ); + + +// VARIABLES // + +var minmax = tryRequire( resolve( __dirname, './../lib/native.js' ) ); +var opts = { + 'skip': ( minmax instanceof Error ) +}; + + +// TESTS // + +tape( 'main export is a function', opts, function test( t ) { + t.ok( true, __filename ); + t.strictEqual( typeof minmax, 'function', 'main export is a function' ); + t.end(); +}); + +tape( 'the function returns `NaN` for both the minimum and maximum value if provided a `NaN`', opts, function test( t ) { + var v; + + v = minmax( NaN, 3.14 ); + t.strictEqual( isnan( v[ 0 ] ), true, 'returns NaN' ); + t.strictEqual( isnan( v[ 1 ] ), true, 'returns NaN' ); + + v = minmax( 3.14, NaN ); + t.strictEqual( isnan( v[ 0 ] ), true, 'returns NaN' ); + t.strictEqual( isnan( v[ 1 ] ), true, 'returns NaN' ); + + v = minmax( NaN, NaN ); + t.strictEqual( isnan( v[ 0 ] ), true, 'returns NaN' ); + t.strictEqual( isnan( v[ 1 ] ), true, 'returns NaN' ); + + t.end(); +}); + +tape( 'the function returns `-Infinity` as the minimum value if provided `-Infinity`', opts, function test( t ) { + var v; + + v = minmax( NINF, 3.14 ); + t.strictEqual( v[ 0 ], NINF, 'returns -infinity' ); + t.strictEqual( v[ 1 ], 3.14, 'returns expected value' ); + + v = minmax( 3.14, NINF ); + t.strictEqual( v[ 0 ], NINF, 'returns -infinity' ); + t.strictEqual( v[ 1 ], 3.14, 'returns expected value' ); + + t.end(); +}); + +tape( 'the function returns `+Infinity` as the maximum value if provided `+Infinity`', opts, function test( t ) { + var v; + + v = minmax( PINF, 3.14 ); + t.strictEqual( v[ 0 ], 3.14, 'returns expected value' ); + t.strictEqual( v[ 1 ], PINF, 'returns +infinity' ); + + v = minmax( 3.14, PINF ); + t.strictEqual( v[ 0 ], 3.14, 'returns expected value' ); + t.strictEqual( v[ 1 ], PINF, 'returns +infinity' ); + + t.end(); +}); + +tape( 'the function returns correctly signed zeros', opts, function test( t ) { + var v; + + v = minmax( +0.0, -0.0 ); + t.strictEqual( isNegativeZero( v[ 0 ] ), true, 'returns -0' ); + t.strictEqual( isPositiveZero( v[ 1 ] ), true, 'returns +0' ); + + v = minmax( -0.0, +0.0 ); + t.strictEqual( isNegativeZero( v[ 0 ] ), true, 'returns -0' ); + t.strictEqual( isPositiveZero( v[ 1 ] ), true, 'returns +0' ); + + v = minmax( -0.0, -0.0 ); + t.strictEqual( isNegativeZero( v[ 0 ] ), true, 'returns -0' ); + t.strictEqual( isNegativeZero( v[ 1 ] ), true, 'returns -0' ); + + v = minmax( +0.0, +0.0 ); + t.strictEqual( isPositiveZero( v[ 0 ] ), true, 'returns +0' ); + t.strictEqual( isPositiveZero( v[ 1 ] ), true, 'returns +0' ); + + t.end(); +}); + +tape( 'the function returns the minimum and maximum values', opts, function test( t ) { + var v; + + v = minmax( 4.2, 3.14 ); + t.strictEqual( v[ 0 ], 3.14, 'returns min value' ); + t.strictEqual( v[ 1 ], 4.2, 'returns max value' ); + + v = minmax( -4.2, 3.14 ); + t.strictEqual( v[ 0 ], -4.2, 'returns min value' ); + t.strictEqual( v[ 1 ], 3.14, 'returns max value' ); + + t.end(); +}); From bdac22d243ec4597a5f8dd40db2ac39e7b7f3003 Mon Sep 17 00:00:00 2001 From: Neerajpathak07 Date: Sat, 22 Mar 2025 22:30:02 +0530 Subject: [PATCH 02/15] chore: updating manifest --- .../math/base/special/minmax/manifest.json | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/lib/node_modules/@stdlib/math/base/special/minmax/manifest.json b/lib/node_modules/@stdlib/math/base/special/minmax/manifest.json index 93e7ee16b78e..6c2e3ebd59d3 100644 --- a/lib/node_modules/@stdlib/math/base/special/minmax/manifest.json +++ b/lib/node_modules/@stdlib/math/base/special/minmax/manifest.json @@ -36,6 +36,11 @@ "libraries": [], "libpath": [], "dependencies": [ + "@stdlib/napi/argv", + "@stdlib/napi/argv-double", + "@stdlib/napi/argv-float64array", + "@stdlib/napi/create-double", + "@stdlib/napi/export", "@stdlib/math/base/assert/is-nan", "@stdlib/math/base/assert/is-negative-zero" ] @@ -51,6 +56,11 @@ "libraries": [], "libpath": [], "dependencies": [ + "@stdlib/napi/argv", + "@stdlib/napi/argv-double", + "@stdlib/napi/argv-float64array", + "@stdlib/napi/create-double", + "@stdlib/napi/export", "@stdlib/math/base/assert/is-nan", "@stdlib/math/base/assert/is-negative-zero" ] @@ -66,6 +76,11 @@ "libraries": [], "libpath": [], "dependencies": [ + "@stdlib/napi/argv", + "@stdlib/napi/argv-double", + "@stdlib/napi/argv-float64array", + "@stdlib/napi/create-double", + "@stdlib/napi/export", "@stdlib/math/base/assert/is-nan", "@stdlib/math/base/assert/is-negative-zero" ] From bdc46091becf295f7c68614633083e034277080e Mon Sep 17 00:00:00 2001 From: Neerajpathak07 Date: Sat, 22 Mar 2025 22:40:14 +0530 Subject: [PATCH 03/15] chore: updating examples --- .../@stdlib/math/base/special/minmax/examples/c/example.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/special/minmax/examples/c/example.c b/lib/node_modules/@stdlib/math/base/special/minmax/examples/c/example.c index b1b0a5597f2d..dda92dc95edd 100644 --- a/lib/node_modules/@stdlib/math/base/special/minmax/examples/c/example.c +++ b/lib/node_modules/@stdlib/math/base/special/minmax/examples/c/example.c @@ -27,8 +27,8 @@ int main( void ) { double y; int i; - const double x1[] = { 1.0, 0.45, -0.89, 0.0 / 0.0, -0.78, -0.22, 0.66, 0.11, -0.55, 0.0 }; - const double x2[] = { -0.22, 0.66, 0.0, -0.55, 0.33, 1.0, 0.0 / 0.0, 0.11, 0.45, -0.78 }; + const double x[] = { 1.0, 0.45, -0.89, 0.0 / 0.0, -0.78, -0.22, 0.66, 0.11, -0.55, 0.0 }; + const double y[] = { -0.22, 0.66, 0.0, -0.55, 0.33, 1.0, 0.0 / 0.0, 0.11, 0.45, -0.78 }; for ( i = 0; i < 12; i++ ) { x = ( ( (double)rand() / (double)RAND_MAX ) * 200.0 ) - 100.0; From c74f80cd6b9aca406bcfbf4559fafea6cf99c360 Mon Sep 17 00:00:00 2001 From: Neerajpathak07 Date: Sat, 22 Mar 2025 22:42:21 +0530 Subject: [PATCH 04/15] chore: updating addon.c --- .../@stdlib/math/base/special/minmax/src/addon.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/special/minmax/src/addon.c b/lib/node_modules/@stdlib/math/base/special/minmax/src/addon.c index 61142a86b86b..fdcac307bd78 100644 --- a/lib/node_modules/@stdlib/math/base/special/minmax/src/addon.c +++ b/lib/node_modules/@stdlib/math/base/special/minmax/src/addon.c @@ -36,8 +36,16 @@ static napi_value addon( napi_env env, napi_callback_info info ) { STDLIB_NAPI_ARGV_DOUBLE( env, x, argv, 0 ); STDLIB_NAPI_ARGV_DOUBLE( env, y, argv, 1 ); STDLIB_NAPI_ARGV_FLOAT64ARRAY( env, z, zlen, argv, 2 ); - STDLIB_NAPI_CREATE_DOUBLE( env, stdlib_base_minmax( x, y, &z[0], &z[1] ), n ); - return n; + + double min; + double max; + stdlib_base_minmax( ( x, y ), &min, &max ); + + double *op = (double *)z; + op[ 0 ] = min; + op[ 1 ] = max; + + return NULL; } STDLIB_NAPI_MODULE_EXPORT_FCN( addon ) From c97d8f99d0456f19e3e08f09b6cb6789dc868a74 Mon Sep 17 00:00:00 2001 From: Neerajpathak07 Date: Sat, 22 Mar 2025 23:09:10 +0530 Subject: [PATCH 05/15] chore: updating addon logic --- lib/node_modules/@stdlib/math/base/special/minmax/src/addon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/math/base/special/minmax/src/addon.c b/lib/node_modules/@stdlib/math/base/special/minmax/src/addon.c index fdcac307bd78..bc05c0a425dc 100644 --- a/lib/node_modules/@stdlib/math/base/special/minmax/src/addon.c +++ b/lib/node_modules/@stdlib/math/base/special/minmax/src/addon.c @@ -39,7 +39,7 @@ static napi_value addon( napi_env env, napi_callback_info info ) { double min; double max; - stdlib_base_minmax( ( x, y ), &min, &max ); + stdlib_base_minmax( x, y, &min, &max ); double *op = (double *)z; op[ 0 ] = min; From 55a3989e71026b19f19fb219349aebe28d4772a8 Mon Sep 17 00:00:00 2001 From: Neerajpathak07 Date: Sat, 22 Mar 2025 23:28:00 +0530 Subject: [PATCH 06/15] chore: updating examples --- .../math/base/special/minmax/examples/c/example.c | 13 ++++--------- .../@stdlib/math/base/special/minmax/package.json | 3 +++ 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/special/minmax/examples/c/example.c b/lib/node_modules/@stdlib/math/base/special/minmax/examples/c/example.c index dda92dc95edd..2a6ca8bf8fd7 100644 --- a/lib/node_modules/@stdlib/math/base/special/minmax/examples/c/example.c +++ b/lib/node_modules/@stdlib/math/base/special/minmax/examples/c/example.c @@ -17,22 +17,17 @@ */ #include "stdlib/math/base/special/minmax.h" -#include #include int main( void ) { + const double x[] = { 1.0, 0.45, -0.89, 0.0 / 0.0, -0.78, -0.22, 0.66, 0.11, -0.55, 0.0 }; + const double y[] = { -0.22, 0.66, 0.0, -0.55, 0.33, 1.0, 0.0 / 0.0, 0.11, 0.45, -0.78 }; + double min; double max; - double x; - double y; int i; - const double x[] = { 1.0, 0.45, -0.89, 0.0 / 0.0, -0.78, -0.22, 0.66, 0.11, -0.55, 0.0 }; - const double y[] = { -0.22, 0.66, 0.0, -0.55, 0.33, 1.0, 0.0 / 0.0, 0.11, 0.45, -0.78 }; - - for ( i = 0; i < 12; i++ ) { - x = ( ( (double)rand() / (double)RAND_MAX ) * 200.0 ) - 100.0; - y = ( ( (double)rand() / (double)RAND_MAX ) * 200.0 ) - 100.0; + for ( i = 0; i < 10; i++ ) { stdlib_base_minmax( x[ i ], y[ i ], &min, &max ); printf( "x: %lf => min: %lf, y: %lf, minmax(x, y): %lf\n", x[ i ], y[ i ], min, max ); } diff --git a/lib/node_modules/@stdlib/math/base/special/minmax/package.json b/lib/node_modules/@stdlib/math/base/special/minmax/package.json index 54aa4e4b91f6..1bdca45ea44a 100644 --- a/lib/node_modules/@stdlib/math/base/special/minmax/package.json +++ b/lib/node_modules/@stdlib/math/base/special/minmax/package.json @@ -14,11 +14,14 @@ } ], "main": "./lib", + "gypfile": true, "directories": { "benchmark": "./benchmark", "doc": "./docs", "example": "./examples", + "include": "./include", "lib": "./lib", + "src": "./src", "test": "./test" }, "types": "./docs/types", From cca14c34e1b79bfd22d6d8afd9bc064a043b84c3 Mon Sep 17 00:00:00 2001 From: Neerajpathak07 Date: Sat, 22 Mar 2025 23:50:38 +0530 Subject: [PATCH 07/15] chore: updating addon --- .../minmax/benchmark/c/native/benchmark.c | 3 +- .../math/base/special/minmax/manifest.json | 15 --- .../math/base/special/minmax/src/addon.c | 102 +++++++++++++++--- 3 files changed, 91 insertions(+), 29 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/special/minmax/benchmark/c/native/benchmark.c b/lib/node_modules/@stdlib/math/base/special/minmax/benchmark/c/native/benchmark.c index ba49cff43e39..500c8512a97a 100644 --- a/lib/node_modules/@stdlib/math/base/special/minmax/benchmark/c/native/benchmark.c +++ b/lib/node_modules/@stdlib/math/base/special/minmax/benchmark/c/native/benchmark.c @@ -95,7 +95,6 @@ static double benchmark( void ) { double max; double x[ 100 ]; double y[ 100 ]; - double z; double t; int i; @@ -106,7 +105,7 @@ static double benchmark( void ) { t = tic(); for ( i = 0; i < ITERATIONS; i++ ) { - z = stdlib_base_minmax( x[ i%100 ], y[ i%100 ], &min, &max ); + stdlib_base_minmax( x[ i%100 ], y[ i%100 ], &min, &max ); if ( max != max || min != min ) { printf( "should not return NaN\n" ); break; diff --git a/lib/node_modules/@stdlib/math/base/special/minmax/manifest.json b/lib/node_modules/@stdlib/math/base/special/minmax/manifest.json index 6c2e3ebd59d3..93e7ee16b78e 100644 --- a/lib/node_modules/@stdlib/math/base/special/minmax/manifest.json +++ b/lib/node_modules/@stdlib/math/base/special/minmax/manifest.json @@ -36,11 +36,6 @@ "libraries": [], "libpath": [], "dependencies": [ - "@stdlib/napi/argv", - "@stdlib/napi/argv-double", - "@stdlib/napi/argv-float64array", - "@stdlib/napi/create-double", - "@stdlib/napi/export", "@stdlib/math/base/assert/is-nan", "@stdlib/math/base/assert/is-negative-zero" ] @@ -56,11 +51,6 @@ "libraries": [], "libpath": [], "dependencies": [ - "@stdlib/napi/argv", - "@stdlib/napi/argv-double", - "@stdlib/napi/argv-float64array", - "@stdlib/napi/create-double", - "@stdlib/napi/export", "@stdlib/math/base/assert/is-nan", "@stdlib/math/base/assert/is-negative-zero" ] @@ -76,11 +66,6 @@ "libraries": [], "libpath": [], "dependencies": [ - "@stdlib/napi/argv", - "@stdlib/napi/argv-double", - "@stdlib/napi/argv-float64array", - "@stdlib/napi/create-double", - "@stdlib/napi/export", "@stdlib/math/base/assert/is-nan", "@stdlib/math/base/assert/is-negative-zero" ] diff --git a/lib/node_modules/@stdlib/math/base/special/minmax/src/addon.c b/lib/node_modules/@stdlib/math/base/special/minmax/src/addon.c index bc05c0a425dc..c5ec84d5872b 100644 --- a/lib/node_modules/@stdlib/math/base/special/minmax/src/addon.c +++ b/lib/node_modules/@stdlib/math/base/special/minmax/src/addon.c @@ -17,11 +17,8 @@ */ #include "stdlib/math/base/special/minmax.h" -#include "stdlib/napi/argv.h" -#include "stdlib/napi/argv_double.h" -#include "stdlib/napi/argv_float64array.h" -#include "stdlib/napi/create_double.h" -#include "stdlib/napi/export.h" +#include +#include #include /** @@ -32,20 +29,101 @@ * @return Node-API value */ static napi_value addon( napi_env env, napi_callback_info info ) { - STDLIB_NAPI_ARGV( env, info, argv, argc, 3 ); - STDLIB_NAPI_ARGV_DOUBLE( env, x, argv, 0 ); - STDLIB_NAPI_ARGV_DOUBLE( env, y, argv, 1 ); - STDLIB_NAPI_ARGV_FLOAT64ARRAY( env, z, zlen, argv, 2 ); + napi_status status; + + // Get callback arguments: + size_t argc = 3; + napi_value argv[ 3 ]; + status = napi_get_cb_info( env, info, &argc, argv, NULL, NULL ); + assert( status == napi_ok ); + + // Check whether we were provided the correct number of arguments: + if ( argc < 3 ) { + status = napi_throw_error( env, NULL, "invalid invocation. Insufficient arguments." ); + assert( status == napi_ok ); + return NULL; + } + if ( argc > 3 ) { + status = napi_throw_error( env, NULL, "invalid invocation. Too many arguments." ); + assert( status == napi_ok ); + return NULL; + } + + bool res; + status = napi_is_typedarray( env, argv[ 0 ], &res ); + assert( status == napi_ok ); + if ( res == false ) { + status = napi_throw_type_error( env, NULL, "invalid argument. First argument must be a Float64Array." ); + assert( status == napi_ok ); + return NULL; + } + + napi_valuetype vtype1; + status = napi_typeof( env, argv[ 1 ], &vtype1 ); + assert( status == napi_ok ); + if ( vtype1 != napi_number ) { + status = napi_throw_type_error( env, NULL, "invalid argument. Second argument must be a number." ); + assert( status == napi_ok ); + return NULL; + } + + napi_valuetype vtype2; + status = napi_typeof( env, argv[ 2 ], &vtype2 ); + assert( status == napi_ok ); + if ( vtype2 != napi_number ) { + status = napi_throw_type_error( env, NULL, "invalid argument. Third argument must be a number." ); + assert( status == napi_ok ); + return NULL; + } + + napi_typedarray_type vtype0; + size_t len; + void *Out; + status = napi_get_typedarray_info( env, argv[ 0 ], &vtype0, &len, &Out, NULL, NULL ); + assert( status == napi_ok ); + if ( vtype0 != napi_float64_array ) { + status = napi_throw_type_error( env, NULL, "invalid argument. First argument must be a Float64Array." ); + assert( status == napi_ok ); + return NULL; + } + if ( len != 2 ) { + status = napi_throw_range_error( env, NULL, "invalid argument. First argument must have 2 elements." ); + assert( status == napi_ok ); + return NULL; + } + + double value1; + status = napi_get_value_double( env, argv[ 1 ], &value1 ); + assert( status == napi_ok ); + + double value2; + status = napi_get_value_double( env, argv[ 2 ], &value2 ); + assert( status == napi_ok ); double min; double max; - stdlib_base_minmax( x, y, &min, &max ); + stdlib_base_minmax( value1, value2, &min, &max ); - double *op = (double *)z; + double *op = (double *)Out; op[ 0 ] = min; op[ 1 ] = max; return NULL; } -STDLIB_NAPI_MODULE_EXPORT_FCN( addon ) +/** +* Initializes a Node-API module. +* +* @private +* @param env environment under which the function is invoked +* @param exports exports object +* @return main export +*/ +static napi_value init( napi_env env, napi_value exports ) { + napi_value fcn; + napi_status status = napi_create_function( env, "exports", NAPI_AUTO_LENGTH, addon, NULL, &fcn ); + assert( status == napi_ok ); + return fcn; +} + +NAPI_MODULE( NODE_GYP_MODULE_NAME, init ) From f93e655ff320a87438455c038bbc097bee035be8 Mon Sep 17 00:00:00 2001 From: Neerajpathak07 Date: Sun, 23 Mar 2025 18:35:26 +0530 Subject: [PATCH 08/15] chore: refactoring addon --- .../math/base/special/minmax/README.md | 3 +- .../math/base/special/minmax/lib/native.js | 58 ++++++++++ .../math/base/special/minmax/manifest.json | 15 +++ .../math/base/special/minmax/src/addon.c | 109 ++---------------- .../math/base/special/minmax/src/main.c | 3 +- 5 files changed, 88 insertions(+), 100 deletions(-) create mode 100644 lib/node_modules/@stdlib/math/base/special/minmax/lib/native.js diff --git a/lib/node_modules/@stdlib/math/base/special/minmax/README.md b/lib/node_modules/@stdlib/math/base/special/minmax/README.md index e7100ec8b9b6..7645c662cf60 100644 --- a/lib/node_modules/@stdlib/math/base/special/minmax/README.md +++ b/lib/node_modules/@stdlib/math/base/special/minmax/README.md @@ -155,7 +155,8 @@ Returns the minimum and maximum value. double min; double max; -stdlib_base_minmax( 4.0, -5.0, &min, &max ); +stdlib_base_minmax( 3.14, NaN ); +// returns [ NaN, NaN ] ``` The function accepts the following arguments: diff --git a/lib/node_modules/@stdlib/math/base/special/minmax/lib/native.js b/lib/node_modules/@stdlib/math/base/special/minmax/lib/native.js new file mode 100644 index 000000000000..91c2f254ae42 --- /dev/null +++ b/lib/node_modules/@stdlib/math/base/special/minmax/lib/native.js @@ -0,0 +1,58 @@ +/** +* @license Apache-2.0 +* +* Copyright (c) 2025 The Stdlib Authors. +* +* Licensed under the Apache License, Version 2.0 (the "License"); +* you may not use this file except in compliance with the License. +* You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +*/ + +'use strict'; + +// MODULES // + +var Float64Array = require( '@stdlib/array/float64' ); +var addon = require( './../src/addon.node' ); + + +// MAIN // + +/** +* Returns the minimum and maximum values. +* +* @private +* @param {number} x - first number +* @param {number} y - second number +* @returns {Array} minimum and maximum values +* +* @example +* var v = minmax( 3.14, 4.2 ); +* // returns [ 3.14, 4.2 ] +* +* @example +* var v = minmax( 3.14, NaN ); +* // returns [ NaN, NaN ] +* +* @example +* var v = minmax( +0.0, -0.0 ); +* // returns [ -0.0, 0.0 ] +*/ +function minmax( x, y ) { + var out = new Float64Array( 2 ); + addon( x, y, out ); + return [ out[ 0 ], out[ 1 ] ]; +} + + +// EXPORTS // + +module.exports = minmax; diff --git a/lib/node_modules/@stdlib/math/base/special/minmax/manifest.json b/lib/node_modules/@stdlib/math/base/special/minmax/manifest.json index 93e7ee16b78e..6c2e3ebd59d3 100644 --- a/lib/node_modules/@stdlib/math/base/special/minmax/manifest.json +++ b/lib/node_modules/@stdlib/math/base/special/minmax/manifest.json @@ -36,6 +36,11 @@ "libraries": [], "libpath": [], "dependencies": [ + "@stdlib/napi/argv", + "@stdlib/napi/argv-double", + "@stdlib/napi/argv-float64array", + "@stdlib/napi/create-double", + "@stdlib/napi/export", "@stdlib/math/base/assert/is-nan", "@stdlib/math/base/assert/is-negative-zero" ] @@ -51,6 +56,11 @@ "libraries": [], "libpath": [], "dependencies": [ + "@stdlib/napi/argv", + "@stdlib/napi/argv-double", + "@stdlib/napi/argv-float64array", + "@stdlib/napi/create-double", + "@stdlib/napi/export", "@stdlib/math/base/assert/is-nan", "@stdlib/math/base/assert/is-negative-zero" ] @@ -66,6 +76,11 @@ "libraries": [], "libpath": [], "dependencies": [ + "@stdlib/napi/argv", + "@stdlib/napi/argv-double", + "@stdlib/napi/argv-float64array", + "@stdlib/napi/create-double", + "@stdlib/napi/export", "@stdlib/math/base/assert/is-nan", "@stdlib/math/base/assert/is-negative-zero" ] diff --git a/lib/node_modules/@stdlib/math/base/special/minmax/src/addon.c b/lib/node_modules/@stdlib/math/base/special/minmax/src/addon.c index c5ec84d5872b..463f4a17f947 100644 --- a/lib/node_modules/@stdlib/math/base/special/minmax/src/addon.c +++ b/lib/node_modules/@stdlib/math/base/special/minmax/src/addon.c @@ -17,8 +17,10 @@ */ #include "stdlib/math/base/special/minmax.h" -#include -#include +#include "stdlib/napi/export.h" +#include "stdlib/napi/argv.h" +#include "stdlib/napi/argv_double.h" +#include "stdlib/napi/argv_float64array.h" #include /** @@ -29,101 +31,12 @@ * @return Node-API value */ static napi_value addon( napi_env env, napi_callback_info info ) { - napi_status status; - - // Get callback arguments: - size_t argc = 3; - napi_value argv[ 3 ]; - status = napi_get_cb_info( env, info, &argc, argv, NULL, NULL ); - assert( status == napi_ok ); - - // Check whether we were provided the correct number of arguments: - if ( argc < 3 ) { - status = napi_throw_error( env, NULL, "invalid invocation. Insufficient arguments." ); - assert( status == napi_ok ); - return NULL; - } - if ( argc > 3 ) { - status = napi_throw_error( env, NULL, "invalid invocation. Too many arguments." ); - assert( status == napi_ok ); - return NULL; - } - - bool res; - status = napi_is_typedarray( env, argv[ 0 ], &res ); - assert( status == napi_ok ); - if ( res == false ) { - status = napi_throw_type_error( env, NULL, "invalid argument. First argument must be a Float64Array." ); - assert( status == napi_ok ); - return NULL; - } - - napi_valuetype vtype1; - status = napi_typeof( env, argv[ 1 ], &vtype1 ); - assert( status == napi_ok ); - if ( vtype1 != napi_number ) { - status = napi_throw_type_error( env, NULL, "invalid argument. Second argument must be a number." ); - assert( status == napi_ok ); - return NULL; - } - - napi_valuetype vtype2; - status = napi_typeof( env, argv[ 2 ], &vtype2 ); - assert( status == napi_ok ); - if ( vtype2 != napi_number ) { - status = napi_throw_type_error( env, NULL, "invalid argument. Third argument must be a number." ); - assert( status == napi_ok ); - return NULL; - } - - napi_typedarray_type vtype0; - size_t len; - void *Out; - status = napi_get_typedarray_info( env, argv[ 0 ], &vtype0, &len, &Out, NULL, NULL ); - assert( status == napi_ok ); - if ( vtype0 != napi_float64_array ) { - status = napi_throw_type_error( env, NULL, "invalid argument. First argument must be a Float64Array." ); - assert( status == napi_ok ); - return NULL; - } - if ( len != 2 ) { - status = napi_throw_range_error( env, NULL, "invalid argument. First argument must have 2 elements." ); - assert( status == napi_ok ); - return NULL; - } - - double value1; - status = napi_get_value_double( env, argv[ 1 ], &value1 ); - assert( status == napi_ok ); - - double value2; - status = napi_get_value_double( env, argv[ 2 ], &value2 ); - assert( status == napi_ok ); - - double min; - double max; - stdlib_base_minmax( value1, value2, &min, &max ); - - double *op = (double *)Out; - op[ 0 ] = min; - op[ 1 ] = max; - - return NULL; -} - -/** -* Initializes a Node-API module. -* -* @private -* @param env environment under which the function is invoked -* @param exports exports object -* @return main export -*/ -static napi_value init( napi_env env, napi_value exports ) { - napi_value fcn; - napi_status status = napi_create_function( env, "exports", NAPI_AUTO_LENGTH, addon, NULL, &fcn ); - assert( status == napi_ok ); - return fcn; + STDLIB_NAPI_ARGV( env, info, argv, argc, 3 ); + STDLIB_NAPI_ARGV_DOUBLE( env, x, argv, 0 ); + STDLIB_NAPI_ARGV_DOUBLE( env, y, argv, 1 ); + STDLIB_NAPI_ARGV_FLOAT64ARRAY( env, out, outlen, argv, 2 ); + stdlib_base_minmax( x, y, &out[ 0 ], &out[ 1 ] ); + return NULL; } -NAPI_MODULE( NODE_GYP_MODULE_NAME, init ) +STDLIB_NAPI_MODULE_EXPORT_FCN( addon ) diff --git a/lib/node_modules/@stdlib/math/base/special/minmax/src/main.c b/lib/node_modules/@stdlib/math/base/special/minmax/src/main.c index 39bf591867a0..76b13f02029b 100644 --- a/lib/node_modules/@stdlib/math/base/special/minmax/src/main.c +++ b/lib/node_modules/@stdlib/math/base/special/minmax/src/main.c @@ -34,7 +34,8 @@ * * double min; * double max; -* stdlib_base_minmax( 4.0, -5.0, &min, &max ); +* stdlib_base_minmax( 3.14, NaN ); +* // returns [ NaN, NaN ] */ void stdlib_base_minmax( const double x, const double y, double* min, double* max ) { From 0e0ec54c2dfd4aa69d17cdf49887e7e3b87ce1e0 Mon Sep 17 00:00:00 2001 From: Neerajpathak07 Date: Sun, 23 Mar 2025 21:45:57 +0530 Subject: [PATCH 09/15] chore: CI errors --- .../@stdlib/math/base/special/minmax/manifest.json | 3 --- .../@stdlib/math/base/special/minmax/src/addon.c | 12 ++++++------ 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/special/minmax/manifest.json b/lib/node_modules/@stdlib/math/base/special/minmax/manifest.json index 6c2e3ebd59d3..739a71e92052 100644 --- a/lib/node_modules/@stdlib/math/base/special/minmax/manifest.json +++ b/lib/node_modules/@stdlib/math/base/special/minmax/manifest.json @@ -39,7 +39,6 @@ "@stdlib/napi/argv", "@stdlib/napi/argv-double", "@stdlib/napi/argv-float64array", - "@stdlib/napi/create-double", "@stdlib/napi/export", "@stdlib/math/base/assert/is-nan", "@stdlib/math/base/assert/is-negative-zero" @@ -59,7 +58,6 @@ "@stdlib/napi/argv", "@stdlib/napi/argv-double", "@stdlib/napi/argv-float64array", - "@stdlib/napi/create-double", "@stdlib/napi/export", "@stdlib/math/base/assert/is-nan", "@stdlib/math/base/assert/is-negative-zero" @@ -79,7 +77,6 @@ "@stdlib/napi/argv", "@stdlib/napi/argv-double", "@stdlib/napi/argv-float64array", - "@stdlib/napi/create-double", "@stdlib/napi/export", "@stdlib/math/base/assert/is-nan", "@stdlib/math/base/assert/is-negative-zero" diff --git a/lib/node_modules/@stdlib/math/base/special/minmax/src/addon.c b/lib/node_modules/@stdlib/math/base/special/minmax/src/addon.c index 463f4a17f947..c03f948f9e2c 100644 --- a/lib/node_modules/@stdlib/math/base/special/minmax/src/addon.c +++ b/lib/node_modules/@stdlib/math/base/special/minmax/src/addon.c @@ -31,12 +31,12 @@ * @return Node-API value */ static napi_value addon( napi_env env, napi_callback_info info ) { - STDLIB_NAPI_ARGV( env, info, argv, argc, 3 ); - STDLIB_NAPI_ARGV_DOUBLE( env, x, argv, 0 ); - STDLIB_NAPI_ARGV_DOUBLE( env, y, argv, 1 ); - STDLIB_NAPI_ARGV_FLOAT64ARRAY( env, out, outlen, argv, 2 ); - stdlib_base_minmax( x, y, &out[ 0 ], &out[ 1 ] ); - return NULL; + STDLIB_NAPI_ARGV( env, info, argv, argc, 3 ); + STDLIB_NAPI_ARGV_DOUBLE( env, x, argv, 0 ); + STDLIB_NAPI_ARGV_DOUBLE( env, y, argv, 1 ); + STDLIB_NAPI_ARGV_FLOAT64ARRAY( env, out, outlen, argv, 2 ); + stdlib_base_minmax( x, y, &out[ 0 ], &out[ 1 ] ); + return NULL; } STDLIB_NAPI_MODULE_EXPORT_FCN( addon ) From 47731bbf8faec20850412c0da7e51c1a5c2a6143 Mon Sep 17 00:00:00 2001 From: Karan Anand Date: Sat, 10 May 2025 18:05:47 -0700 Subject: [PATCH 10/15] chore: apply suggestions from review --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../include/stdlib/math/base/special/minmax.h | 2 +- .../math/base/special/minmax/lib/native.js | 8 ++-- .../math/base/special/minmax/manifest.json | 8 ---- .../math/base/special/minmax/src/main.c | 18 ++++---- .../base/special/minmax/test/test.assign.js | 24 +++++----- .../base/special/minmax/test/test.main.js | 8 ++-- .../base/special/minmax/test/test.native.js | 46 ++++++++++--------- 7 files changed, 53 insertions(+), 61 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/special/minmax/include/stdlib/math/base/special/minmax.h b/lib/node_modules/@stdlib/math/base/special/minmax/include/stdlib/math/base/special/minmax.h index 5890f87b004d..3c0b959a8a71 100644 --- a/lib/node_modules/@stdlib/math/base/special/minmax/include/stdlib/math/base/special/minmax.h +++ b/lib/node_modules/@stdlib/math/base/special/minmax/include/stdlib/math/base/special/minmax.h @@ -27,7 +27,7 @@ extern "C" { #endif /** -* Returns the minimum and maximum values. +* Evaluates the minimum and maximum values. */ void stdlib_base_minmax( const double x, const double y, double *min, double *max ); diff --git a/lib/node_modules/@stdlib/math/base/special/minmax/lib/native.js b/lib/node_modules/@stdlib/math/base/special/minmax/lib/native.js index 91c2f254ae42..abd31dd48c2f 100644 --- a/lib/node_modules/@stdlib/math/base/special/minmax/lib/native.js +++ b/lib/node_modules/@stdlib/math/base/special/minmax/lib/native.js @@ -36,20 +36,20 @@ var addon = require( './../src/addon.node' ); * * @example * var v = minmax( 3.14, 4.2 ); -* // returns [ 3.14, 4.2 ] +* // returns [ 3.14, 4.2 ] * * @example * var v = minmax( 3.14, NaN ); -* // returns [ NaN, NaN ] +* // returns [ NaN, NaN ] * * @example * var v = minmax( +0.0, -0.0 ); -* // returns [ -0.0, 0.0 ] +* // returns [ -0.0, 0.0 ] */ function minmax( x, y ) { var out = new Float64Array( 2 ); addon( x, y, out ); - return [ out[ 0 ], out[ 1 ] ]; + return out; } diff --git a/lib/node_modules/@stdlib/math/base/special/minmax/manifest.json b/lib/node_modules/@stdlib/math/base/special/minmax/manifest.json index 739a71e92052..502beab58f74 100644 --- a/lib/node_modules/@stdlib/math/base/special/minmax/manifest.json +++ b/lib/node_modules/@stdlib/math/base/special/minmax/manifest.json @@ -55,10 +55,6 @@ "libraries": [], "libpath": [], "dependencies": [ - "@stdlib/napi/argv", - "@stdlib/napi/argv-double", - "@stdlib/napi/argv-float64array", - "@stdlib/napi/export", "@stdlib/math/base/assert/is-nan", "@stdlib/math/base/assert/is-negative-zero" ] @@ -74,10 +70,6 @@ "libraries": [], "libpath": [], "dependencies": [ - "@stdlib/napi/argv", - "@stdlib/napi/argv-double", - "@stdlib/napi/argv-float64array", - "@stdlib/napi/export", "@stdlib/math/base/assert/is-nan", "@stdlib/math/base/assert/is-negative-zero" ] diff --git a/lib/node_modules/@stdlib/math/base/special/minmax/src/main.c b/lib/node_modules/@stdlib/math/base/special/minmax/src/main.c index 76b13f02029b..2d5a90e71cb6 100644 --- a/lib/node_modules/@stdlib/math/base/special/minmax/src/main.c +++ b/lib/node_modules/@stdlib/math/base/special/minmax/src/main.c @@ -19,25 +19,23 @@ #include "stdlib/math/base/special/minmax.h" #include "stdlib/math/base/assert/is_nan.h" #include "stdlib/math/base/assert/is_negative_zero.h" -#include /** -* Evaluates the min and max of two values. +* Evaluates the minimum and maximum values. * -* @param x First value -* @param y Second value -* @param min destination to store minimum value -* @param max destination to store maximum value +* @param x first number +* @param y second number +* @param min destination to store the minimum value +* @param max destination to store the maximum value * * @example -* #include +* double x = 3.14; +* double y = 2.71; * * double min; * double max; -* stdlib_base_minmax( 3.14, NaN ); -* // returns [ NaN, NaN ] +* stdlib_base_minmax( x, y, &min, &max ); */ - void stdlib_base_minmax( const double x, const double y, double* min, double* max ) { if ( stdlib_base_is_nan( x ) || stdlib_base_is_nan( y ) ) { *min = 0.0 / 0.0; // NaN diff --git a/lib/node_modules/@stdlib/math/base/special/minmax/test/test.assign.js b/lib/node_modules/@stdlib/math/base/special/minmax/test/test.assign.js index 72f82b2d7bb9..dce0ee0fac4d 100644 --- a/lib/node_modules/@stdlib/math/base/special/minmax/test/test.assign.js +++ b/lib/node_modules/@stdlib/math/base/special/minmax/test/test.assign.js @@ -139,14 +139,14 @@ tape( 'the function returns the minimum and maximum values', function test( t ) out = new Float64Array( 2 ); v = minmax( 4.2, 3.14, out, 1, 0 ); t.strictEqual( v, out, 'returns output array' ); - t.strictEqual( v[ 0 ], 3.14, 'returns min value' ); - t.strictEqual( v[ 1 ], 4.2, 'returns max value' ); + t.strictEqual( v[ 0 ], 3.14, 'returns expected value' ); + t.strictEqual( v[ 1 ], 4.2, 'returns expected value' ); out = new Float64Array( 2 ); v = minmax( -4.2, 3.14, out, 1, 0 ); t.strictEqual( v, out, 'returns output array' ); - t.strictEqual( v[ 0 ], -4.2, 'returns min value' ); - t.strictEqual( v[ 1 ], 3.14, 'returns max value' ); + t.strictEqual( v[ 0 ], -4.2, 'returns expected value' ); + t.strictEqual( v[ 1 ], 3.14, 'returns expected value' ); t.end(); }); @@ -158,14 +158,14 @@ tape( 'the function supports providing an output object (array)', function test( out = [ 0.0, 0.0 ]; v = minmax( 4.2, 3.14, out, 1, 0 ); t.strictEqual( v, out, 'returns output array' ); - t.strictEqual( v[ 0 ], 3.14, 'returns min value' ); - t.strictEqual( v[ 1 ], 4.2, 'returns max value' ); + t.strictEqual( v[ 0 ], 3.14, 'returns expected value' ); + t.strictEqual( v[ 1 ], 4.2, 'returns expected value' ); out = [ 0.0, 0.0 ]; v = minmax( -4.2, 3.14, out, 1, 0 ); t.strictEqual( v, out, 'returns output array' ); - t.strictEqual( v[ 0 ], -4.2, 'returns min value' ); - t.strictEqual( v[ 1 ], 3.14, 'returns max value' ); + t.strictEqual( v[ 0 ], -4.2, 'returns expected value' ); + t.strictEqual( v[ 1 ], 3.14, 'returns expected value' ); t.end(); }); @@ -177,14 +177,14 @@ tape( 'the function supports providing an output object (typed array)', function out = new Float64Array( 2 ); v = minmax( 4.2, 3.14, out, 1, 0 ); t.strictEqual( v, out, 'returns output array' ); - t.strictEqual( v[ 0 ], 3.14, 'returns min value' ); - t.strictEqual( v[ 1 ], 4.2, 'returns max value' ); + t.strictEqual( v[ 0 ], 3.14, 'returns expected value' ); + t.strictEqual( v[ 1 ], 4.2, 'returns expected value' ); out = new Float64Array( 2 ); v = minmax( -4.2, 3.14, out, 1, 0 ); t.strictEqual( v, out, 'returns output array' ); - t.strictEqual( v[ 0 ], -4.2, 'returns min value' ); - t.strictEqual( v[ 1 ], 3.14, 'returns max value' ); + t.strictEqual( v[ 0 ], -4.2, 'returns expected value' ); + t.strictEqual( v[ 1 ], 3.14, 'returns expected value' ); t.end(); }); diff --git a/lib/node_modules/@stdlib/math/base/special/minmax/test/test.main.js b/lib/node_modules/@stdlib/math/base/special/minmax/test/test.main.js index 23be03222f8e..a802ddea9966 100644 --- a/lib/node_modules/@stdlib/math/base/special/minmax/test/test.main.js +++ b/lib/node_modules/@stdlib/math/base/special/minmax/test/test.main.js @@ -109,12 +109,12 @@ tape( 'the function returns the minimum and maximum values', function test( t ) var v; v = minmax( 4.2, 3.14 ); - t.strictEqual( v[ 0 ], 3.14, 'returns min value' ); - t.strictEqual( v[ 1 ], 4.2, 'returns max value' ); + t.strictEqual( v[ 0 ], 3.14, 'returns expected value' ); + t.strictEqual( v[ 1 ], 4.2, 'returns expected value' ); v = minmax( -4.2, 3.14 ); - t.strictEqual( v[ 0 ], -4.2, 'returns min value' ); - t.strictEqual( v[ 1 ], 3.14, 'returns max value' ); + t.strictEqual( v[ 0 ], -4.2, 'returns expected value' ); + t.strictEqual( v[ 1 ], 3.14, 'returns expected value' ); t.end(); }); diff --git a/lib/node_modules/@stdlib/math/base/special/minmax/test/test.native.js b/lib/node_modules/@stdlib/math/base/special/minmax/test/test.native.js index 6f5f4a2e3617..5413717bc661 100644 --- a/lib/node_modules/@stdlib/math/base/special/minmax/test/test.native.js +++ b/lib/node_modules/@stdlib/math/base/special/minmax/test/test.native.js @@ -38,6 +38,8 @@ var opts = { }; +// TESTS // + // TESTS // tape( 'main export is a function', opts, function test( t ) { @@ -50,16 +52,16 @@ tape( 'the function returns `NaN` for both the minimum and maximum value if prov var v; v = minmax( NaN, 3.14 ); - t.strictEqual( isnan( v[ 0 ] ), true, 'returns NaN' ); - t.strictEqual( isnan( v[ 1 ] ), true, 'returns NaN' ); + t.strictEqual( isnan( v[ 0 ] ), true, 'returns expected value' ); + t.strictEqual( isnan( v[ 1 ] ), true, 'returns expected value' ); v = minmax( 3.14, NaN ); - t.strictEqual( isnan( v[ 0 ] ), true, 'returns NaN' ); - t.strictEqual( isnan( v[ 1 ] ), true, 'returns NaN' ); + t.strictEqual( isnan( v[ 0 ] ), true, 'returns expected value' ); + t.strictEqual( isnan( v[ 1 ] ), true, 'returns expected value' ); v = minmax( NaN, NaN ); - t.strictEqual( isnan( v[ 0 ] ), true, 'returns NaN' ); - t.strictEqual( isnan( v[ 1 ] ), true, 'returns NaN' ); + t.strictEqual( isnan( v[ 0 ] ), true, 'returns expected value' ); + t.strictEqual( isnan( v[ 1 ] ), true, 'returns expected value' ); t.end(); }); @@ -68,11 +70,11 @@ tape( 'the function returns `-Infinity` as the minimum value if provided `-Infin var v; v = minmax( NINF, 3.14 ); - t.strictEqual( v[ 0 ], NINF, 'returns -infinity' ); + t.strictEqual( v[ 0 ], NINF, 'returns expected value' ); t.strictEqual( v[ 1 ], 3.14, 'returns expected value' ); v = minmax( 3.14, NINF ); - t.strictEqual( v[ 0 ], NINF, 'returns -infinity' ); + t.strictEqual( v[ 0 ], NINF, 'returns expected value' ); t.strictEqual( v[ 1 ], 3.14, 'returns expected value' ); t.end(); @@ -83,11 +85,11 @@ tape( 'the function returns `+Infinity` as the maximum value if provided `+Infin v = minmax( PINF, 3.14 ); t.strictEqual( v[ 0 ], 3.14, 'returns expected value' ); - t.strictEqual( v[ 1 ], PINF, 'returns +infinity' ); + t.strictEqual( v[ 1 ], PINF, 'returns expected value' ); v = minmax( 3.14, PINF ); t.strictEqual( v[ 0 ], 3.14, 'returns expected value' ); - t.strictEqual( v[ 1 ], PINF, 'returns +infinity' ); + t.strictEqual( v[ 1 ], PINF, 'returns expected value' ); t.end(); }); @@ -96,20 +98,20 @@ tape( 'the function returns correctly signed zeros', opts, function test( t ) { var v; v = minmax( +0.0, -0.0 ); - t.strictEqual( isNegativeZero( v[ 0 ] ), true, 'returns -0' ); - t.strictEqual( isPositiveZero( v[ 1 ] ), true, 'returns +0' ); + t.strictEqual( isNegativeZero( v[ 0 ] ), true, 'returns expected value' ); + t.strictEqual( isPositiveZero( v[ 1 ] ), true, 'returns expected value' ); v = minmax( -0.0, +0.0 ); - t.strictEqual( isNegativeZero( v[ 0 ] ), true, 'returns -0' ); - t.strictEqual( isPositiveZero( v[ 1 ] ), true, 'returns +0' ); + t.strictEqual( isNegativeZero( v[ 0 ] ), true, 'returns expected value' ); + t.strictEqual( isPositiveZero( v[ 1 ] ), true, 'returns expected value' ); v = minmax( -0.0, -0.0 ); - t.strictEqual( isNegativeZero( v[ 0 ] ), true, 'returns -0' ); - t.strictEqual( isNegativeZero( v[ 1 ] ), true, 'returns -0' ); + t.strictEqual( isNegativeZero( v[ 0 ] ), true, 'returns expected value' ); + t.strictEqual( isNegativeZero( v[ 1 ] ), true, 'returns expected value' ); v = minmax( +0.0, +0.0 ); - t.strictEqual( isPositiveZero( v[ 0 ] ), true, 'returns +0' ); - t.strictEqual( isPositiveZero( v[ 1 ] ), true, 'returns +0' ); + t.strictEqual( isPositiveZero( v[ 0 ] ), true, 'returns expected value' ); + t.strictEqual( isPositiveZero( v[ 1 ] ), true, 'returns expected value' ); t.end(); }); @@ -118,12 +120,12 @@ tape( 'the function returns the minimum and maximum values', opts, function test var v; v = minmax( 4.2, 3.14 ); - t.strictEqual( v[ 0 ], 3.14, 'returns min value' ); - t.strictEqual( v[ 1 ], 4.2, 'returns max value' ); + t.strictEqual( v[ 0 ], 3.14, 'returns expected value' ); + t.strictEqual( v[ 1 ], 4.2, 'returns expected value' ); v = minmax( -4.2, 3.14 ); - t.strictEqual( v[ 0 ], -4.2, 'returns min value' ); - t.strictEqual( v[ 1 ], 3.14, 'returns max value' ); + t.strictEqual( v[ 0 ], -4.2, 'returns expected value' ); + t.strictEqual( v[ 1 ], 3.14, 'returns expected value' ); t.end(); }); From 76a5eb2ea6ced9f2bbb6822df69ffc586ab1e11f Mon Sep 17 00:00:00 2001 From: Karan Anand Date: Sat, 10 May 2025 23:42:26 -0700 Subject: [PATCH 11/15] bench: fix makefile and redorder variables --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../minmax/benchmark/c/native/Makefile | 37 ++++++++++++++----- .../minmax/benchmark/c/native/benchmark.c | 4 +- 2 files changed, 30 insertions(+), 11 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/special/minmax/benchmark/c/native/Makefile b/lib/node_modules/@stdlib/math/base/special/minmax/benchmark/c/native/Makefile index d564e8b2d6f9..a4bd7b38fd74 100644 --- a/lib/node_modules/@stdlib/math/base/special/minmax/benchmark/c/native/Makefile +++ b/lib/node_modules/@stdlib/math/base/special/minmax/benchmark/c/native/Makefile @@ -16,7 +16,6 @@ # limitations under the License. #/ - # VARIABLES # ifndef VERBOSE @@ -70,6 +69,18 @@ else fPIC ?= -fPIC endif +# List of includes (e.g., `-I /foo/bar -I /beep/boop/include`): +INCLUDE ?= + +# List of source files: +SOURCE_FILES ?= + +# List of libraries (e.g., `-lopenblas -lpthread`): +LIBRARIES ?= + +# List of library paths (e.g., `-L /foo/bar -L /beep/boop`): +LIBPATH ?= + # List of C targets: c_targets := benchmark.out @@ -77,11 +88,15 @@ c_targets := benchmark.out # RULES # #/ -# Compiles C source files. +# Compiles source files. # -# @param {string} [C_COMPILER] - C compiler -# @param {string} [CFLAGS] - C compiler flags -# @param {(string|void)} [fPIC] - compiler flag indicating whether to generate position independent code +# @param {string} [C_COMPILER] - C compiler (e.g., `gcc`) +# @param {string} [CFLAGS] - C compiler options +# @param {(string|void)} [fPIC] - compiler flag determining whether to generate position independent code (e.g., `-fPIC`) +# @param {string} [INCLUDE] - list of includes (e.g., `-I /foo/bar -I /beep/boop/include`) +# @param {string} [SOURCE_FILES] - list of source files +# @param {string} [LIBPATH] - list of library paths (e.g., `-L /foo/bar -L /beep/boop`) +# @param {string} [LIBRARIES] - list of libraries (e.g., `-lopenblas -lpthread`) # # @example # make @@ -97,12 +112,16 @@ all: $(c_targets) # Compiles C source files. # # @private -# @param {string} CC - C compiler -# @param {string} CFLAGS - C compiler flags -# @param {(string|void)} fPIC - compiler flag indicating whether to generate position independent code +# @param {string} CC - C compiler (e.g., `gcc`) +# @param {string} CFLAGS - C compiler options +# @param {(string|void)} fPIC - compiler flag determining whether to generate position independent code (e.g., `-fPIC`) +# @param {string} INCLUDE - list of includes (e.g., `-I /foo/bar`) +# @param {string} SOURCE_FILES - list of source files +# @param {string} LIBPATH - list of library paths (e.g., `-L /foo/bar`) +# @param {string} LIBRARIES - list of libraries (e.g., `-lopenblas`) #/ $(c_targets): %.out: %.c - $(QUIET) $(CC) $(CFLAGS) $(fPIC) -o $@ $< -lm + $(QUIET) $(CC) $(CFLAGS) $(fPIC) $(INCLUDE) -o $@ $(SOURCE_FILES) $< $(LIBPATH) -lm $(LIBRARIES) #/ # Runs compiled benchmarks. diff --git a/lib/node_modules/@stdlib/math/base/special/minmax/benchmark/c/native/benchmark.c b/lib/node_modules/@stdlib/math/base/special/minmax/benchmark/c/native/benchmark.c index 500c8512a97a..bea002d07576 100644 --- a/lib/node_modules/@stdlib/math/base/special/minmax/benchmark/c/native/benchmark.c +++ b/lib/node_modules/@stdlib/math/base/special/minmax/benchmark/c/native/benchmark.c @@ -90,11 +90,11 @@ static double rand_double( void ) { * @return elapsed time in seconds */ static double benchmark( void ) { + double x[ 100 ]; + double y[ 100 ]; double elapsed; double min; double max; - double x[ 100 ]; - double y[ 100 ]; double t; int i; From abf72a20e3a082c9e4fa78a289bdd8bf3fb736eb Mon Sep 17 00:00:00 2001 From: Karan Anand Date: Sun, 11 May 2025 00:16:16 -0700 Subject: [PATCH 12/15] chore: apply suggestions from review --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: passed - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../math/base/special/minmax/README.md | 33 ++++----- .../special/minmax/benchmark/benchmark.js | 7 +- .../minmax/benchmark/benchmark.native.js | 67 ++----------------- .../base/special/minmax/examples/c/example.c | 3 +- .../include/stdlib/math/base/special/minmax.h | 2 +- .../math/base/special/minmax/src/main.c | 6 +- 6 files changed, 26 insertions(+), 92 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/special/minmax/README.md b/lib/node_modules/@stdlib/math/base/special/minmax/README.md index 7645c662cf60..aa3f93986f21 100644 --- a/lib/node_modules/@stdlib/math/base/special/minmax/README.md +++ b/lib/node_modules/@stdlib/math/base/special/minmax/README.md @@ -147,24 +147,23 @@ for ( i = 0; i < 100; i++ ) { #### stdlib_base_minmax( x, y, &min, &max ) -Returns the minimum and maximum value. +Evaluates the minimum and maximum values in a single pass. ```c -#include +double x = 3.14; +double y = 2.71; double min; double max; - -stdlib_base_minmax( 3.14, NaN ); -// returns [ NaN, NaN ] +stdlib_base_minmax( x, y, &min, &max ); ``` The function accepts the following arguments: -- **x**: `[in] double` input value. -- **y**: `[in] double` input value. -- **min**: `[out] double` destination for minimum value. -- **max**: `[out] double` destination for maximum value. +- **x**: `[in] double` first number. +- **y**: `[in] double` second number. +- **min**: `[out] double` destination for the minimum value. +- **max**: `[out] double` destination for the maximum value. ```c void stdlib_base_minmax( const double x, const double y, double* min, double* max ); @@ -190,24 +189,18 @@ void stdlib_base_minmax( const double x, const double y, double* min, double* ma ```c #include "stdlib/math/base/special/minmax.h" -#include #include int main( void ) { + const double x[] = { 1.0, 0.45, -0.89, 0.0 / 0.0, -0.78, -0.22, 0.66, 0.11, -0.55, 0.0 }; + const double y[] = { -0.22, 0.66, 0.0, -0.55, 0.33, 1.0, 0.0 / 0.0, 0.11, 0.45, -0.78 }; + double min; double max; - double x; - double y; int i; - - const double x1[] = { 1.0, 0.45, -0.89, 0.0 / 0.0, -0.78, -0.22, 0.66, 0.11, -0.55, 0.0 }; - const double x2[] = { -0.22, 0.66, 0.0, -0.55, 0.33, 1.0, 0.0 / 0.0, 0.11, 0.45, -0.78 }; - - for ( i = 0; i < 12; i++ ) { - x = ( ( (double)rand() / (double)RAND_MAX ) * 200.0 ) - 100.0; - y = ( ( (double)rand() / (double)RAND_MAX ) * 200.0 ) - 100.0; + for ( i = 0; i < 10; i++ ) { stdlib_base_minmax( x[ i ], y[ i ], &min, &max ); - printf( "x: %lf => min: %lf, y: %lf, minmax(x, y): %lf\n", x[ i ], y[ i ]min, max ); + printf( "x: %lf, y: %lf => min: %lf, max: %lf\n", x[ i ], y[ i ], min, max ); } } ``` diff --git a/lib/node_modules/@stdlib/math/base/special/minmax/benchmark/benchmark.js b/lib/node_modules/@stdlib/math/base/special/minmax/benchmark/benchmark.js index a6ea7e6b324a..315b1ccc3ef9 100644 --- a/lib/node_modules/@stdlib/math/base/special/minmax/benchmark/benchmark.js +++ b/lib/node_modules/@stdlib/math/base/special/minmax/benchmark/benchmark.js @@ -66,9 +66,6 @@ bench( pkg+':assign', function benchmark( b ) { y = uniform( 100, -500.0, 500.0 ); out = [ 0.0, 0.0 ]; - x = discreteUniform( 100, -500, 500 ); - y = discreteUniform( 100, -500, 500 ); - b.tic(); for ( i = 0; i < b.iterations; i++ ) { z = minmax.assign( x[ i%x.length ], y[ i%y.length ], out, 1, 0 ); @@ -95,6 +92,7 @@ bench( pkg+'::min,max', function benchmark( b ) { b.tic(); for ( i = 0; i < b.iterations; i++ ) { + // eslint-disable-next-line max-len z = [ min( x[ i%x.length ], y[ i%y.length ] ), max( x[ i%x.length ], y[ i%y.length ] ) ]; if ( z.length !== 2 ) { b.fail( 'should have expected length' ); @@ -118,9 +116,6 @@ bench( pkg+'::min,max,memory_reuse', function benchmark( b ) { y = uniform( 100, -500.0, 500.0 ); z = [ 0.0, 0.0 ]; - x = discreteUniform( 100, -500, 500 ); - y = discreteUniform( 100, -500, 500 ); - b.tic(); for ( i = 0; i < b.iterations; i++ ) { z[ 0 ] = min( x[ i%x.length ], y[ i%y.length ] ); diff --git a/lib/node_modules/@stdlib/math/base/special/minmax/benchmark/benchmark.native.js b/lib/node_modules/@stdlib/math/base/special/minmax/benchmark/benchmark.native.js index eee1d73a2a24..6e6dff037709 100644 --- a/lib/node_modules/@stdlib/math/base/special/minmax/benchmark/benchmark.native.js +++ b/lib/node_modules/@stdlib/math/base/special/minmax/benchmark/benchmark.native.js @@ -22,10 +22,8 @@ var resolve = require( 'path' ).resolve; var bench = require( '@stdlib/bench' ); -var discreteUniform = require( '@stdlib/random/array/discrete-uniform' ); -var isArray = require( '@stdlib/assert/is-array' ); -var min = require( '@stdlib/math/base/special/min' ); -var max = require( '@stdlib/math/base/special/max' ); +var uniform = require( '@stdlib/random/array/uniform' ); +var isFloat64Array = require( '@stdlib/assert/is-float64array' ); var tryRequire = require( '@stdlib/utils/try-require' ); var pkg = require( './../package.json' ).name; @@ -46,70 +44,19 @@ bench( pkg+'::native', opts, function benchmark( b ) { var z; var i; - x = discreteUniform( 100, -500, 500 ); - y = discreteUniform( 100, -500, 500 ); + x = uniform( 100, -500.0, 500.0 ); + y = uniform( 100, -500.0, 500.0 ); b.tic(); for ( i = 0; i < b.iterations; i++ ) { - z = minmax( x, y ); + z = minmax( x[ i%x.length ], y[ i%y.length ] ); if ( z.length !== 2 ) { b.fail( 'should have expected length' ); } } b.toc(); - if ( !isArray( z ) ) { - b.fail( 'should return an array' ); - } - b.pass( 'benchmark finished' ); - b.end(); -}); - -bench( pkg+'::min,max', opts, function benchmark( b ) { - var x; - var y; - var z; - var i; - - x = discreteUniform( 100, -500, 500 ); - y = discreteUniform( 100, -500, 500 ); - - b.tic(); - for ( i = 0; i < b.iterations; i++ ) { - z = [ min( x, y ), max( x, y ) ]; - if ( z.length !== 2 ) { - b.fail( 'should have expected length' ); - } - } - b.toc(); - if ( !isArray( z ) ) { - b.fail( 'should return an array' ); - } - b.pass( 'benchmark finished' ); - b.end(); -}); - -bench( pkg+'::min,max,memory_reuse', opts, function benchmark( b ) { - var x; - var y; - var z; - var i; - - z = [ 0.0, 0.0 ]; - - x = discreteUniform( 100, -500, 500 ); - y = discreteUniform( 100, -500, 500 ); - - b.tic(); - for ( i = 0; i < b.iterations; i++ ) { - z[ 0 ] = min( x, y ); - z[ 1 ] = max( x, y ); - if ( z.length !== 2 ) { - b.fail( 'should have expected length' ); - } - } - b.toc(); - if ( !isArray( z ) ) { - b.fail( 'should return an array' ); + if ( !isFloat64Array( z ) ) { + b.fail( 'should return a Float64Array' ); } b.pass( 'benchmark finished' ); b.end(); diff --git a/lib/node_modules/@stdlib/math/base/special/minmax/examples/c/example.c b/lib/node_modules/@stdlib/math/base/special/minmax/examples/c/example.c index 2a6ca8bf8fd7..b104cbded7e0 100644 --- a/lib/node_modules/@stdlib/math/base/special/minmax/examples/c/example.c +++ b/lib/node_modules/@stdlib/math/base/special/minmax/examples/c/example.c @@ -26,9 +26,8 @@ int main( void ) { double min; double max; int i; - for ( i = 0; i < 10; i++ ) { stdlib_base_minmax( x[ i ], y[ i ], &min, &max ); - printf( "x: %lf => min: %lf, y: %lf, minmax(x, y): %lf\n", x[ i ], y[ i ], min, max ); + printf( "x: %lf, y: %lf => min: %lf, max: %lf\n", x[ i ], y[ i ], min, max ); } } diff --git a/lib/node_modules/@stdlib/math/base/special/minmax/include/stdlib/math/base/special/minmax.h b/lib/node_modules/@stdlib/math/base/special/minmax/include/stdlib/math/base/special/minmax.h index 3c0b959a8a71..f29b5d8e42ea 100644 --- a/lib/node_modules/@stdlib/math/base/special/minmax/include/stdlib/math/base/special/minmax.h +++ b/lib/node_modules/@stdlib/math/base/special/minmax/include/stdlib/math/base/special/minmax.h @@ -27,7 +27,7 @@ extern "C" { #endif /** -* Evaluates the minimum and maximum values. +* Evaluates the minimum and maximum values in a single pass. */ void stdlib_base_minmax( const double x, const double y, double *min, double *max ); diff --git a/lib/node_modules/@stdlib/math/base/special/minmax/src/main.c b/lib/node_modules/@stdlib/math/base/special/minmax/src/main.c index 2d5a90e71cb6..b33609808d80 100644 --- a/lib/node_modules/@stdlib/math/base/special/minmax/src/main.c +++ b/lib/node_modules/@stdlib/math/base/special/minmax/src/main.c @@ -21,12 +21,12 @@ #include "stdlib/math/base/assert/is_negative_zero.h" /** -* Evaluates the minimum and maximum values. +* Evaluates the minimum and maximum values in a single pass. * * @param x first number * @param y second number -* @param min destination to store the minimum value -* @param max destination to store the maximum value +* @param min destination for the minimum value +* @param max destination for the maximum value * * @example * double x = 3.14; From 5adb76ad7ea3278dea423fb1154099a90a21b11a Mon Sep 17 00:00:00 2001 From: Karan Anand <119553199+anandkaranubc@users.noreply.github.com> Date: Sun, 11 May 2025 00:29:27 -0700 Subject: [PATCH 13/15] Update native.js Signed-off-by: Karan Anand <119553199+anandkaranubc@users.noreply.github.com> --- lib/node_modules/@stdlib/math/base/special/minmax/lib/native.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/math/base/special/minmax/lib/native.js b/lib/node_modules/@stdlib/math/base/special/minmax/lib/native.js index abd31dd48c2f..b770ffb4b59b 100644 --- a/lib/node_modules/@stdlib/math/base/special/minmax/lib/native.js +++ b/lib/node_modules/@stdlib/math/base/special/minmax/lib/native.js @@ -32,7 +32,7 @@ var addon = require( './../src/addon.node' ); * @private * @param {number} x - first number * @param {number} y - second number -* @returns {Array} minimum and maximum values +* @returns {Float64Array} minimum and maximum values * * @example * var v = minmax( 3.14, 4.2 ); From f8af36ca58f02a98571307dd23c76507db186956 Mon Sep 17 00:00:00 2001 From: Karan Anand <119553199+anandkaranubc@users.noreply.github.com> Date: Sun, 11 May 2025 00:37:03 -0700 Subject: [PATCH 14/15] Update test.native.js Signed-off-by: Karan Anand <119553199+anandkaranubc@users.noreply.github.com> --- .../@stdlib/math/base/special/minmax/test/test.native.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/special/minmax/test/test.native.js b/lib/node_modules/@stdlib/math/base/special/minmax/test/test.native.js index 5413717bc661..ea77d4eee9c5 100644 --- a/lib/node_modules/@stdlib/math/base/special/minmax/test/test.native.js +++ b/lib/node_modules/@stdlib/math/base/special/minmax/test/test.native.js @@ -38,8 +38,6 @@ var opts = { }; -// TESTS // - // TESTS // tape( 'main export is a function', opts, function test( t ) { From 5551f93a15b318cc3f5b3060c8478729c0d2df14 Mon Sep 17 00:00:00 2001 From: Karan Anand <119553199+anandkaranubc@users.noreply.github.com> Date: Sun, 18 May 2025 19:49:01 -0700 Subject: [PATCH 15/15] Update lib/node_modules/@stdlib/math/base/special/minmax/src/main.c Signed-off-by: Karan Anand <119553199+anandkaranubc@users.noreply.github.com> --- lib/node_modules/@stdlib/math/base/special/minmax/src/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/math/base/special/minmax/src/main.c b/lib/node_modules/@stdlib/math/base/special/minmax/src/main.c index b33609808d80..d710b31d4433 100644 --- a/lib/node_modules/@stdlib/math/base/special/minmax/src/main.c +++ b/lib/node_modules/@stdlib/math/base/special/minmax/src/main.c @@ -42,7 +42,7 @@ void stdlib_base_minmax( const double x, const double y, double* min, double* ma *max = 0.0 / 0.0; // NaN return; } - if ( x == y && x == 0 ) { + if ( x == y && x == 0.0 ) { if ( stdlib_base_is_negative_zero( x ) ) { *min = x; *max = y;