Skip to content

refactor(lint): use array push instead of pre-allocation in closed circles renderer #5796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 11, 2025
Merged

refactor(lint): use array push instead of pre-allocation in closed circles renderer #5796

merged 4 commits into from
Mar 11, 2025

Conversation

@abdelrahman04
Copy link
Contributor

@abdelrahman04 abdelrahman04 commented Mar 5, 2025 •
edited
Loading

Resolves #{{TODO: add issue number}}.

Description

What is the purpose of this pull request?

This pull request:

  • fix linting error by using Array.push() instead of pre-allocation with new Array(length)

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

abdelrahman04 and others added 4 commits March 3, 2025 16:36
@abdelrahman04
fix(buffer): remove unused eslint-disable directives in polyfill.js
8077e33 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@abdelrahman04
Merge branch 'stdlib-js:develop' into develop
7411a18
@abdelrahman04
fix: replace new Array() with Array() constructor
077aab3 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@abdelrahman04
refactor(lint): use array push instead of pre-allocation in closed ci…
064e3b7 
…rcles renderer

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 5, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 5, 2025

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Mar 5, 2025
@abdelrahman04
Copy link
Contributor Author

abdelrahman04 commented Mar 5, 2025

@Planeshifter any idea why the js tests are failing? I don't think this has to do with the pr, but a previous commit

@Planeshifter
Copy link
Member

Planeshifter commented Mar 5, 2025 •
edited
Loading

@abdelrahman04 Not sure, but yeah, must be unrelated.

For this PR to land, please check the acknowledgement box per the instruction left by the @stdlib-bot.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Mar 5, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 5, 2025
@Planeshifter Planeshifter added Needs Review A pull request which needs code review. and removed Ready To Merge A pull request which is ready to be merged. labels Mar 5, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 5, 2025 •
edited by Planeshifter
Loading

PR Commit Message

refactor(lint): use array push instead of pre-allocation in closed circles renderer

PR-URL: https://github.com/stdlib-js/stdlib/pull/5796
Closes: https://github.com/stdlib-js/stdlib/issues/5791

Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter added status: Blocked Issue or pull request which is currently blocked. Ready To Merge A pull request which is ready to be merged. and removed status: Blocked Issue or pull request which is currently blocked. labels Mar 5, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 11, 2025
@Planeshifter Planeshifter merged commit 6b3f9c5 into stdlib-js:develop Mar 11, 2025
115 of 117 checks passed
@Planeshifter
Copy link
Member

Planeshifter commented Mar 11, 2025

Landed! Thanks, @abdelrahman04!

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 11, 2025

PR Commit Message

refactor(lint): use array push instead of pre-allocation in closed circles renderer

PR-URL: https://github.com/stdlib-js/stdlib/pull/5796
Closes: https://github.com/stdlib-js/stdlib/issues/5791

Co-authored-by: Abdelrahman Samir <60700731+abdelrahman04@users.noreply.github.com>
Co-authored-by: Abdelrahman Samir <abdelrahman.tony.5@gmail.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees

No one assigned

Labels

Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

3 participants

@abdelrahman04 @stdlib-bot @Planeshifter