Skip to content

fix: update C implementation for stats/base/dists/kumaraswamy/median #5452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 1, 2025
Merged

fix: update C implementation for stats/base/dists/kumaraswamy/median #5452

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c62f2f7
fix: correct median formula in kumaraswamy distribution
Krishna-Sharma-g Feb 25, 2025
ac0c3bc
Update test.native.js
Krishna-Sharma-g Feb 25, 2025
d3c7315
Update lib/node_modules/@stdlib/stats/base/dists/kumaraswamy/median/s…
Krishna-Sharma-g Feb 26, 2025
afcb598
Merge branch 'stdlib-js:develop' into develop
Krishna-Sharma-g Feb 26, 2025
7fc3a2a
fix: c implementation bug fix
Krishna-Sharma-g Feb 27, 2025
68d8746
Merge remote-tracking branch 'upstream/develop' into develop
stdlib-bot Feb 27, 2025
d479e60
spacing fix
Krishna-Sharma-g Feb 27, 2025
04c1793
Update benchmark.c
Krishna-Sharma-g Feb 27, 2025
2116498
chore: fix indentation
Planeshifter Mar 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/stats/base/dists/kumaraswamy/median/src/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,5 +39,5 @@ double stdlib_base_dists_kumaraswamy_median( const double a, const double b ) {
) {
return 0.0/0.0; // NaN
}
return 1.0 - stdlib_base_pow( 0.5, 1.0 / b );
return stdlib_base_pow( 1.0 - stdlib_base_pow( 2.0, -1.0 / b ), 1.0 / a );
}
47 changes: 40 additions & 7 deletions lib/node_modules/@stdlib/stats/base/dists/kumaraswamy/median/test/test.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,30 +55,63 @@ tape( 'if provided `NaN` for any parameter, the function returns `NaN`', opts, f
var v = median( NaN, 0.5 );
t.equal( isnan( v ), true, 'returns NaN' );

v = median( 10, NaN );
v = median( 10.0, NaN );
t.equal( isnan( v ), true, 'returns NaN' );

v = median( NaN, NaN );
t.equal( isnan( v ), true, 'returns NaN' );
t.end();
});

tape( 'if provided a nonpositive `a`, the function returns `NaN`', opts, function test( t ) {
var y;

y = median( 0.0, 2.0 );
t.equal( isnan( y ), true, 'returns NaN' );

y = median( -1.0, 2.0 );
t.equal( isnan( y ), true, 'returns NaN' );

y = median( -1.0, 2.0 );
t.equal( isnan( y ), true, 'returns NaN' );

y = median( NINF, 1.0 );
t.equal( isnan( y ), true, 'returns NaN' );

y = median( NINF, PINF );
t.equal( isnan( y ), true, 'returns NaN' );

y = median( NINF, NINF );
t.equal( isnan( y ), true, 'returns NaN' );

y = median( NINF, NaN );
t.equal( isnan( y ), true, 'returns NaN' );

t.end();
});

tape( 'if provided a nonpositive `gamma`, the function always returns `NaN`', opts, function test( t ) {
tape( 'if provided a nonpositive `b`, the function returns `NaN`', opts, function test( t ) {
var y;

y = median( 0.0, 0.0 );
y = median( 2.0, 0.0 );
t.equal( isnan( y ), true, 'returns NaN' );

y = median( 0.0, -1.0 );
y = median( 2.0, -1.0 );
t.equal( isnan( y ), true, 'returns NaN' );

y = median( 0.0, NINF );
y = median( 2.0, -1/0 );
t.equal( isnan( y ), true, 'returns NaN' );

y = median( 1.0, NINF );
t.equal( isnan( y ), true, 'returns NaN' );

y = median( PINF, NINF );
t.equal( isnan( y ), true, 'returns NaN' );

y = median( NINF, NINF );
t.equal( isnan( y ), true, 'returns NaN' );

y = median( NaN, NINF );
t.equal( isnan( y ), true, 'returns NaN' );

t.end();
});

Expand Down
Loading