refactor

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
---

Author: jalajk3004

lib/node_modules/@stdlib/stats/base/range/benchmark/benchmark.js

@@ -22,7 +22,7 @@
 
 var bench = require( '@stdlib/bench' );
 var isnan = require( '@stdlib/math/base/assert/is-nan' );
-var linspace = require( '@stdlib/array/linspace/docs/types/index' );
+var linspace = require( '@stdlib/array/base/linspace' );
 var pow = require( '@stdlib/math/base/special/pow' );
 var pkg = require( './../package.json' ).name;
 var range = require( './../lib/range.js' );

lib/node_modules/@stdlib/stats/base/range/benchmark/benchmark.ndarray.js

@@ -22,6 +22,7 @@
 
 var bench = require( '@stdlib/bench' );
 var randu = require( '@stdlib/random/base/randu' );
+var linspace = require( '@stdlib/array/linspace/docs/types/index' );
 var isnan = require( '@stdlib/math/base/assert/is-nan' );
 var pow = require( '@stdlib/math/base/special/pow' );
 var pkg = require( './../package.json' ).name;
@@ -39,12 +40,7 @@ var range = require( './../lib/ndarray.js' );
 */
 function createBenchmark( len ) {
 	var x;
-	var i;
-
-	x = [];
-	for ( i = 0; i < len; i++ ) {
-		x.push( ( randu()*20.0 ) - 10.0 );
-	}
+	var x = linspace( 0.0, len, len );
 	return benchmark;
 
 	function benchmark( b ) {

lib/node_modules/@stdlib/stats/base/range/docs/repl.txt

@@ -1,8 +1,8 @@
 
-{{alias}}( N, x, stride )
+{{alias}}( N, x, strideX )
     Computes the range of a strided array.
 
-    The `N` and `stride` parameters determine which elements in `x` are accessed
+    The `N` and stride parameters determine which elements in the strided array are accessed
     at runtime.
 
     Indexing is relative to the first index. To introduce an offset, use a typed
@@ -18,8 +18,8 @@
     x: Array<number>|TypedArray
         Input array.
 
-    stride: integer
-        Index increment.
+    strideX: integer
+        Stride length.
 
     Returns
     -------
@@ -33,22 +33,20 @@
     > {{alias}}( x.length, x, 1 )
     4.0
 
-    // Using `N` and `stride` parameters:
+    // Using `N` and stride parameters:
     > x = [ -2.0, 1.0, 1.0, -5.0, 2.0, -1.0 ];
-    > var N = {{alias:@stdlib/math/base/special/floor}}( x.length / 2 );
     > var stride = 2;
-    > {{alias}}( N, x, stride )
+    > {{alias}}( 3, x, stride )
     4.0
 
     // Using view offsets:
     > var x0 = new {{alias:@stdlib/array/float64}}( [ 1.0, -2.0, 3.0, 2.0, 5.0, -1.0 ] );
     > var x1 = new {{alias:@stdlib/array/float64}}( x0.buffer, x0.BYTES_PER_ELEMENT*1 );
-    > N = {{alias:@stdlib/math/base/special/floor}}( x0.length / 2 );
     > stride = 2;
-    > {{alias}}( N, x1, stride )
+    > {{alias}}( 3, x1, stride )
     4.0
 
-{{alias}}.ndarray( N, x, stride, offset )
+{{alias}}.ndarray( N, x, strideX, offsetX )
     Computes the range of a strided array using alternative indexing semantics.
 
     While typed array views mandate a view offset based on the underlying
@@ -63,10 +61,10 @@
     x: Array<number>|TypedArray
         Input array.
 
-    stride: integer
-        Index increment.
+    strideX: integer
+        Stride length.
 
-    offset: integer
+    offsetX: integer
         Starting index.
 
     Returns
@@ -83,8 +81,7 @@
 
     // Using offset parameter:
     > var x = [ 1.0, -2.0, 3.0, 2.0, 5.0, -1.0 ];
-    > var N = {{alias:@stdlib/math/base/special/floor}}( x.length / 2 );
-    > {{alias}}.ndarray( N, x, 2, 1 )
+    > {{alias}}.ndarray( 3, x, 2, 1 )
     4.0
 
     See Also

lib/node_modules/@stdlib/stats/base/range/docs/types/index.d.ts

@@ -20,18 +20,20 @@
 
 /// <reference types="@stdlib/types"/>
 
-import { NumericArray } from '@stdlib/types/array';
+import { NumericArray, Collection, AccessorArrayLike } from '@stdlib/types/array';
 
 /**
 * Interface describing `range`.
 */
+type InputArray = NumericArray | Collection<number> | AccessorArrayLike<number>;
+
 interface Routine {
 	/**
 	* Computes the range of a strided array.
 	*
 	* @param N - number of indexed elements
 	* @param x - input array
-	* @param stride - stride length
+	* @param strideX - stride length
 	* @returns range
 	*
 	* @example
@@ -40,15 +42,15 @@ interface Routine {
 	* var v = range( x.length, x, 1 );
 	* // returns 4.0
 	*/
-	( N: number, x: NumericArray, stride: number ): number;
+	( N: number, x: InputArray, strideX: number ): number;
 
 	/**
 	* Computes the range of a strided array using alternative indexing semantics.
 	*
 	* @param N - number of indexed elements
 	* @param x - input array
-	* @param stride - stride length
-	* @param offset - starting index
+	* @param strideX - stride length
+	* @param offsetX - starting index
 	* @returns range
 	*
 	* @example
@@ -57,15 +59,15 @@ interface Routine {
 	* var v = range.ndarray( x.length, x, 1, 0 );
 	* // returns 4.0
 	*/
-	ndarray( N: number, x: NumericArray, stride: number, offset: number ): number;
+	ndarray( N: number, x: InputArray, strideX: number, offsetX: number ): number;
 }
 
 /**
 * Computes the range of a strided array.
 *
 * @param N - number of indexed elements
 * @param x - input array
-* @param stride - stride length
+* @param strideX - stride length
 * @returns range
 *
 * @example

lib/node_modules/@stdlib/stats/base/range/docs/types/test.ts

@@ -16,6 +16,7 @@
 * limitations under the License.
 */
 
+import AccessorArray = require( '@stdlib/array/base/accessor' );
 import range = require( './index' );
 
 
@@ -26,6 +27,7 @@ import range = require( './index' );
 	const x = new Float64Array( 10 );
 
 	range( x.length, x, 1 ); // $ExpectType number
+	range( x.length, new AccessorArray( x ), 1 ); // $ExpectType number
 }
 
 // The compiler throws an error if the function is provided a first argument which is not a number...
@@ -85,6 +87,7 @@ import range = require( './index' );
 	const x = new Float64Array( 10 );
 
 	range.ndarray( x.length, x, 1, 0 ); // $ExpectType number
+	range.ndarray( x.length, new AccessorArray( x ), 1, 0 ); // $ExpectType number
 }
 
 // The compiler throws an error if the `ndarray` method is provided a first argument which is not a number...

lib/node_modules/@stdlib/stats/base/range/examples/index.js

@@ -18,18 +18,10 @@
 
 'use strict';
 
-var randu = require( '@stdlib/random/base/randu' );
-var round = require( '@stdlib/math/base/special/round' );
-var Float64Array = require( '@stdlib/array/float64' );
+var linspace = require( '@stdlib/array/base/linspace' );
 var range = require( './../lib' );
 
-var x;
-var i;
-
-x = new Float64Array( 10 );
-for ( i = 0; i < x.length; i++ ) {
-	x[ i ] = round( (randu()*100.0) - 50.0 );
-}
+var x = linspace(-50, 50, 10);
 console.log( x );
 
 var v = range( x.length, x, 1 );

lib/node_modules/@stdlib/stats/base/range/lib/accessors.js

@@ -0,0 +1,91 @@
+/**
+* @license Apache-2.0
+*
+* Copyright (c) 2020 The Stdlib Authors.
+*
+* Licensed under the Apache License, Version 2.0 (the "License");
+* you may not use this file except in compliance with the License.
+* You may obtain a copy of the License at
+*
+*    http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+
+'use strict';
+
+// MODULES //
+
+var isnan = require( '@stdlib/math/base/assert/is-nan' );
+var stride2offset = require( '@stdlib/strided/base/stride2offset' );
+
+// MAIN //
+
+/**
+* Computes the range of a strided array using the accessor protocol.
+*
+* @param {PositiveInteger} N - number of indexed elements
+* @param {Object} x - input array-like object supporting the accessor protocol
+* @param {Function} get - accessor function to retrieve array values
+* @param {integer} stride - stride length
+* @returns {number} range (max - min)
+*
+* @example
+* function accessor( arr, idx ) {
+*     return arr.get( idx );
+* }
+*
+* var x = {
+*     data: [ -2.0, 1.0, 1.0, -5.0, 2.0, -1.0 ],
+*     get: function( i ) { return this.data[ i ]; }
+* };
+*
+* var v = range( 3, x, accessor, 2 );
+* // returns 4.0
+*/
+function range( N, x, get, stride ) {
+    var max;
+    var min;
+    var ix;
+    var v;
+    var i;
+
+    if ( N <= 0 ) {
+        return NaN;
+    }
+    if ( N === 1 || stride === 0 ) {
+        v = get( x, 0 );
+        if ( isnan( v ) ) {
+            return NaN;
+        }
+        return 0.0;
+    }
+    if ( stride < 0 ) {
+        ix = (1 - N) * stride;
+    } else {
+        ix = 0;
+    }
+    min = get( x, ix );
+    max = min;
+    for ( i = 1; i < N; i++ ) {
+        ix += stride;
+        v = get( x, ix );
+        if ( isnan( v ) ) {
+            return v;
+        }
+        if ( v < min ) {
+            min = v;
+        } else if ( v > max ) {
+            max = v;
+        }
+    }
+    return max - min;
+}
+
+// EXPORTS //
+
+module.exports = range;